From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64BD61873 for ; Sun, 21 Aug 2022 15:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661095402; x=1692631402; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8/iNi7dL+X0JQfBLWYDScHJZL12LFVVUc4/cZIXyHxU=; b=RkUIK7TIlHcNvgd29hQq3c5HsSi36Wkbi8RsgOuAJ1EjyoRbYQouq9uT /uyLME5i+JmqooKJO/aiBay2Id7LIf51sVx4QEDaHbbkYRz54BC5no9yS 3uRDCq5eXHntJkebEgvy9JQAdtep/eg2CkUEFh96srPfK8ccc26GAXopv pRXAhZrxx7aswtAFitkYTULTd4spKQ6W8s4c4814nRuom+Gq7TpiIAasZ iU5sRR34XH8pz+gH0DLBilZLTxofWw1udAs8+Hlz98tk4iwYcqURuyDhA 8nVhbKPwAMjnMQsYrg4sEs4HK7/9HlTapo0whW/QatZ/X79rUG43b+77R w==; X-IronPort-AV: E=McAfee;i="6500,9779,10446"; a="354990885" X-IronPort-AV: E=Sophos;i="5.93,253,1654585200"; d="scan'208";a="354990885" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2022 08:22:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,252,1654585200"; d="scan'208";a="698022770" Received: from lkp-server01.sh.intel.com (HELO 44b6dac04a33) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 21 Aug 2022 08:22:53 -0700 Received: from kbuild by 44b6dac04a33 with local (Exim 4.96) (envelope-from ) id 1oPmmq-0004EZ-1s; Sun, 21 Aug 2022 15:22:52 +0000 Date: Sun, 21 Aug 2022 23:22:22 +0800 From: kernel test robot To: Jacob Keller , netdev@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Jacob Keller , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Tom Lendacky , Shyam Sundar S K , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Siva Reddy Kallam , Prashant Sreedharan , Michael Chan , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Bryan Whitehead , Sergey Shtylyov , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Vivek Thampi Subject: Re: [net-next 10/14] ptp: lan743x: convert to .adjfine and diff_by_scaled_ppm Message-ID: <202208212326.87xlsbQB-lkp@intel.com> References: <20220818222742.1070935-11-jacob.e.keller@intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818222742.1070935-11-jacob.e.keller@intel.com> Hi Jacob, I love your patch! Yet something to improve: [auto build test ERROR on 9017462f006c4b686cb1e1e1a3a52ea8363076e6] url: https://github.com/intel-lab-lkp/linux/commits/Jacob-Keller/ptp-convert-drivers-to-adjfine/20220819-063154 base: 9017462f006c4b686cb1e1e1a3a52ea8363076e6 config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20220821/202208212326.87xlsbQB-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 01ffe31cbb54bfd8e38e71b3cf804a1d67ebf9c1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/d3c6eac5778f2ce74e7d6d7be90a60f616551718 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jacob-Keller/ptp-convert-drivers-to-adjfine/20220819-063154 git checkout d3c6eac5778f2ce74e7d6d7be90a60f616551718 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/microchip/lan743x_ptp.c:368:12: error: redefinition of 'lan743x_ptpci_adjfine' static int lan743x_ptpci_adjfine(struct ptp_clock_info *ptpci, long delta) ^ drivers/net/ethernet/microchip/lan743x_ptp.c:335:12: note: previous definition is here static int lan743x_ptpci_adjfine(struct ptp_clock_info *ptpci, long scaled_ppm) ^ >> drivers/net/ethernet/microchip/lan743x_ptp.c:386:3: error: use of undeclared identifier 'lan743_rate_adj'; did you mean 'lan743x_rate_adj'? lan743_rate_adj = (u32)diff; ^~~~~~~~~~~~~~~ lan743x_rate_adj drivers/net/ethernet/microchip/lan743x_ptp.c:374:6: note: 'lan743x_rate_adj' declared here u64 lan743x_rate_adj; ^ >> drivers/net/ethernet/microchip/lan743x_ptp.c:388:3: error: use of undeclared identifier 'lan74e_rage_adj'; did you mean 'lan743x_rate_adj'? lan74e_rage_adj = (u32)diff | PTP_CLOCK_RATE_ADJ_DIR_; ^~~~~~~~~~~~~~~ lan743x_rate_adj drivers/net/ethernet/microchip/lan743x_ptp.c:374:6: note: 'lan743x_rate_adj' declared here u64 lan743x_rate_adj; ^ 3 errors generated. vim +/lan743x_ptpci_adjfine +368 drivers/net/ethernet/microchip/lan743x_ptp.c 367 > 368 static int lan743x_ptpci_adjfine(struct ptp_clock_info *ptpci, long delta) 369 { 370 struct lan743x_ptp *ptp = 371 container_of(ptpci, struct lan743x_ptp, ptp_clock_info); 372 struct lan743x_adapter *adapter = 373 container_of(ptp, struct lan743x_adapter, ptp); 374 u64 lan743x_rate_adj; 375 s32 delta_ppb; 376 u64 diff; 377 378 delta_ppb = scaled_ppm_to_ppb(delta); 379 if ((delta_ppb < (-LAN743X_PTP_MAX_FREQ_ADJ_IN_PPB)) || 380 delta_ppb > LAN743X_PTP_MAX_FREQ_ADJ_IN_PPB) { 381 return -EINVAL; 382 } 383 384 /* diff_by_scaled_ppm returns true if the difference is negative */ 385 if (diff_by_scaled_ppm(1ULL << 35, delta, &diff)) > 386 lan743_rate_adj = (u32)diff; 387 else > 388 lan74e_rage_adj = (u32)diff | PTP_CLOCK_RATE_ADJ_DIR_; 389 390 lan743x_csr_write(adapter, PTP_CLOCK_RATE_ADJ, 391 lan743x_rate_adj); 392 393 return 0; 394 } 395 -- 0-DAY CI Kernel Test Service https://01.org/lkp