* [PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation
@ 2022-08-12 17:20 ` Tim Harvey
0 siblings, 0 replies; 4+ messages in thread
From: Tim Harvey @ 2022-08-12 17:20 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
get_caps") the phy-mode must be set otherwise the switch driver will
assume "NA" mode and invalidate the port.
Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index 24737e89038a..96cac0f969a7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -626,24 +626,28 @@ ports {
lan1: port@0 {
reg = <0>;
label = "lan1";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan2: port@1 {
reg = <1>;
label = "lan2";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan3: port@2 {
reg = <2>;
label = "lan3";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan4: port@3 {
reg = <3>;
label = "lan4";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation
@ 2022-08-12 17:20 ` Tim Harvey
0 siblings, 0 replies; 4+ messages in thread
From: Tim Harvey @ 2022-08-12 17:20 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
get_caps") the phy-mode must be set otherwise the switch driver will
assume "NA" mode and invalidate the port.
Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index 24737e89038a..96cac0f969a7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -626,24 +626,28 @@ ports {
lan1: port@0 {
reg = <0>;
label = "lan1";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan2: port@1 {
reg = <1>;
label = "lan2";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan3: port@2 {
reg = <2>;
label = "lan3";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan4: port@3 {
reg = <3>;
label = "lan4";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation
2022-08-12 17:20 ` Tim Harvey
@ 2022-08-22 1:55 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-08-22 1:55 UTC (permalink / raw)
To: Tim Harvey
Cc: Fabio Estevam, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Aug 12, 2022 at 10:20:54AM -0700, Tim Harvey wrote:
> Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
> get_caps") the phy-mode must be set otherwise the switch driver will
> assume "NA" mode and invalidate the port.
>
> Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation
@ 2022-08-22 1:55 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-08-22 1:55 UTC (permalink / raw)
To: Tim Harvey
Cc: Fabio Estevam, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Aug 12, 2022 at 10:20:54AM -0700, Tim Harvey wrote:
> Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
> get_caps") the phy-mode must be set otherwise the switch driver will
> assume "NA" mode and invalidate the port.
>
> Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-22 1:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 17:20 [PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation Tim Harvey
2022-08-12 17:20 ` Tim Harvey
2022-08-22 1:55 ` Shawn Guo
2022-08-22 1:55 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.