From: Steven Rostedt <rostedt@goodmis.org>
To: Song Liu <song@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Ingo Molnar <mingo@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: makes ops_references_rec() inline
Date: Mon, 22 Aug 2022 09:35:03 -0400 [thread overview]
Message-ID: <20220822093503.40cb4551@gandalf.local.home> (raw)
In-Reply-To: <CAPhsuW6gAHPeRF0cqpi0Z4znWbw+rhz3h4yXYOWQ-__zPY7LoA@mail.gmail.com>
On Mon, 22 Aug 2022 00:28:58 -0700
Song Liu <song@kernel.org> wrote:
> On Sun, Aug 21, 2022 at 7:31 PM Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> >
> > commit 53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the
> > same function") changed ops_references_rec() inline to function,
> > thus we will get below error if .config doesn't have CONFIG_MODULES.
> >
> > CC kernel/trace/ftrace.o
> > ${linux}/kernel/trace/ftrace.c:3149:1: error: 'ops_references_rec' \
> > defined but not used [-Werror=unused-function]
> > 3149 | ops_references_rec(struct ftrace_ops *ops, struct dyn_ftrace *rec)
> > | ^~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make[2]: *** [${linux}/scripts/Makefile.build:249: kernel/trace/ftrace.o] error 1
> > make[1]: *** [${linux}/scripts/Makefile.build:466: kernel/trace] error 2
> > make: *** [/opt/disk_cd/morimoto/linux/Makefile:1843: kernel] error 2
> >
> > This patch makes it to inline again, and fixes the issue.
> >
> > Fixes: 53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the same function")
> > CC: Song Liu <song@kernel.org>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Acked-by: Song Liu <song@kernel.org>
>
> Thanks for the fix!
Wrong fix.
The correct fix is here[1], and because the breakage went through the BPF
tree, I could not apply it. Now that both the BPF and my tree is in Linus's
tree, I can apply it and now will do so.
-- Steve
[1] https://lore.kernel.org/all/20220801084745.1187987-1-wangjingjin1@huawei.com/
next prev parent reply other threads:[~2022-08-22 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 2:31 [PATCH] ftrace: makes ops_references_rec() inline Kuninori Morimoto
2022-08-22 7:28 ` Song Liu
2022-08-22 13:35 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-09 23:56 Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822093503.40cb4551@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=daniel@iogearbox.net \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.