From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA60C28D13 for ; Mon, 22 Aug 2022 20:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231901AbiHVUBK (ORCPT ); Mon, 22 Aug 2022 16:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232359AbiHVT7n (ORCPT ); Mon, 22 Aug 2022 15:59:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F24744F183 for ; Mon, 22 Aug 2022 12:59:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93743B818BC for ; Mon, 22 Aug 2022 19:59:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AAA0C433D6; Mon, 22 Aug 2022 19:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661198380; bh=XSFkR3FGXT9WJQ8s+XvFV48zhCowUdvyg/afXYDK2go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FAB/Ez1uNC9O+WbGdkVqHBQ3vicurBj8Q7JmWzVs00eeh4w/oH9bl0EWoOHIGrulB 9MpPKbmzbWPDWiE4OKyk2xaTUgQCtZ2VnMK7oVOQB0qLsVfeUlSFFNn8Y7sa12d63+ PpbuMW+W2uHIBd9Svc9Sbn8sPRu2SZAraJ1093D6a0i97NpadLzESFshoOQQ47F3EM ZM3KAK2zIVRerzpqWgXhpUezrP7u2vxrOxZV+08xjUYMhT4Fuctt0SkDbP7IdGaoLU BjbTNzRbIYwR2jaEObPKjQh74hAts1XTD0uZhcaGf7N5Kp7Ew/obySDvnkC19icczx x9vaOK1wGv1lg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Dan Carpenter , Tariq Toukan Subject: [net 12/13] net/mlx5e: Fix use after free in mlx5e_fs_init() Date: Mon, 22 Aug 2022 12:59:16 -0700 Message-Id: <20220822195917.216025-13-saeed@kernel.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220822195917.216025-1-saeed@kernel.org> References: <20220822195917.216025-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Call mlx5e_fs_vlan_free(fs) before kvfree(fs). Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer") Signed-off-by: Dan Carpenter Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c index e2a9b9be5c1f..e0ce5a233d0b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c @@ -1395,10 +1395,11 @@ struct mlx5e_flow_steering *mlx5e_fs_init(const struct mlx5e_profile *profile, } return fs; -err_free_fs: - kvfree(fs); + err_free_vlan: mlx5e_fs_vlan_free(fs); +err_free_fs: + kvfree(fs); err: return NULL; } -- 2.37.1