[PATCH 1/2] drm: rcar-du: Drop unused encoder header files

[PATCH 1/2] drm: rcar-du: Drop unused encoder header files

[Biju Das]

Drop unused header files from rcar_du_encoder.c

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
index 60d6be78323b..bfd5c087eb0a 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
@@ -9,18 +9,13 @@
 
 #include <linux/export.h>
 #include <linux/of.h>
-#include <linux/slab.h>
 
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_managed.h>
-#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 
 #include "rcar_du_drv.h"
 #include "rcar_du_encoder.h"
-#include "rcar_du_kms.h"
 #include "rcar_lvds.h"
 
 /* -----------------------------------------------------------------------------
-- 
2.25.1

[PATCH 1/2] drm: rcar-du: Drop unused encoder header files

[Biju Das]

Drop unused header files from rcar_du_encoder.c

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
index 60d6be78323b..bfd5c087eb0a 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
@@ -9,18 +9,13 @@
 
 #include <linux/export.h>
 #include <linux/of.h>
-#include <linux/slab.h>
 
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_managed.h>
-#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 
 #include "rcar_du_drv.h"
 #include "rcar_du_encoder.h"
-#include "rcar_du_kms.h"
 #include "rcar_lvds.h"
 
 /* -----------------------------------------------------------------------------
-- 
2.25.1

[PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Biju Das]

Replace use of struct rcar_du_format_info with %p4cc for printing
4CC formats.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 21881fb5e84a..8c2719efda2a 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv,
 
 	format = rcar_du_format_info(mode_cmd->pixel_format);
 	if (format == NULL) {
-		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
-			mode_cmd->pixel_format);
+		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
+			&mode_cmd->pixel_format);
 		return ERR_PTR(-EINVAL);
 	}
 
-- 
2.25.1

[PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Biju Das]

Replace use of struct rcar_du_format_info with %p4cc for printing
4CC formats.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 21881fb5e84a..8c2719efda2a 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv,
 
 	format = rcar_du_format_info(mode_cmd->pixel_format);
 	if (format == NULL) {
-		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
-			mode_cmd->pixel_format);
+		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
+			&mode_cmd->pixel_format);
 		return ERR_PTR(-EINVAL);
 	}
 
-- 
2.25.1

Re: [PATCH 1/2] drm: rcar-du: Drop unused encoder header files

[Laurent Pinchart]

Hi Biju,

Thank you for the patch.

On Thu, Aug 25, 2022 at 11:39:04AM +0100, Biju Das wrote:
> Drop unused header files from rcar_du_encoder.c
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index 60d6be78323b..bfd5c087eb0a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -9,18 +9,13 @@
>  
>  #include <linux/export.h>
>  #include <linux/of.h>
> -#include <linux/slab.h>
>  
>  #include <drm/drm_bridge.h>
>  #include <drm/drm_bridge_connector.h>
> -#include <drm/drm_crtc.h>
> -#include <drm/drm_managed.h>
> -#include <drm/drm_modeset_helper_vtables.h>
>  #include <drm/drm_panel.h>
>  
>  #include "rcar_du_drv.h"
>  #include "rcar_du_encoder.h"
> -#include "rcar_du_kms.h"
>  #include "rcar_lvds.h"
>  
>  /* -----------------------------------------------------------------------------

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] drm: rcar-du: Drop unused encoder header files

[Laurent Pinchart]

Hi Biju,

Thank you for the patch.

On Thu, Aug 25, 2022 at 11:39:04AM +0100, Biju Das wrote:
> Drop unused header files from rcar_du_encoder.c
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index 60d6be78323b..bfd5c087eb0a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -9,18 +9,13 @@
>  
>  #include <linux/export.h>
>  #include <linux/of.h>
> -#include <linux/slab.h>
>  
>  #include <drm/drm_bridge.h>
>  #include <drm/drm_bridge_connector.h>
> -#include <drm/drm_crtc.h>
> -#include <drm/drm_managed.h>
> -#include <drm/drm_modeset_helper_vtables.h>
>  #include <drm/drm_panel.h>
>  
>  #include "rcar_du_drv.h"
>  #include "rcar_du_encoder.h"
> -#include "rcar_du_kms.h"
>  #include "rcar_lvds.h"
>  
>  /* -----------------------------------------------------------------------------

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Laurent Pinchart]

Hi Biju,

Thank you for the patch.

On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> Replace use of struct rcar_du_format_info with %p4cc for printing
> 4CC formats.

The code change looks good, but doesn't match the commit message. You're
not replacing usage of struct rcar_du_format_info. I propose the
following commit message:

Use the %p4cc format specifier to print 4CCs, which will provide a more
readable message than the raw hex value.

> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index 21881fb5e84a..8c2719efda2a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv,
>  
>  	format = rcar_du_format_info(mode_cmd->pixel_format);
>  	if (format == NULL) {
> -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> -			mode_cmd->pixel_format);
> +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> +			&mode_cmd->pixel_format);
>  		return ERR_PTR(-EINVAL);
>  	}
>  

There are two other occurrences:

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
index 26b25ca58968..83631ee2fff1 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
@@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane,

 	*format = rcar_du_format_info(state->fb->format->format);
 	if (*format == NULL) {
-		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
-			state->fb->format->format);
+		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n", __func__,
+			&state->fb->format->format);
 		return -EINVAL;
 	}

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
index 25f50a297c11..8cd37d7b8ae2 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
@@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct drm_encoder *encoder,

 	wb_state->format = rcar_du_format_info(fb->format->format);
 	if (wb_state->format == NULL) {
-		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
-			fb->format->format);
+		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n", __func__,
+			&fb->format->format);
 		return -EINVAL;
 	}

I can add these changes to the patch and update the commit message when
applying if you're fine with that. In that case,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Laurent Pinchart]

Hi Biju,

Thank you for the patch.

On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> Replace use of struct rcar_du_format_info with %p4cc for printing
> 4CC formats.

The code change looks good, but doesn't match the commit message. You're
not replacing usage of struct rcar_du_format_info. I propose the
following commit message:

Use the %p4cc format specifier to print 4CCs, which will provide a more
readable message than the raw hex value.

> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index 21881fb5e84a..8c2719efda2a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv,
>  
>  	format = rcar_du_format_info(mode_cmd->pixel_format);
>  	if (format == NULL) {
> -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> -			mode_cmd->pixel_format);
> +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> +			&mode_cmd->pixel_format);
>  		return ERR_PTR(-EINVAL);
>  	}
>  

There are two other occurrences:

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
index 26b25ca58968..83631ee2fff1 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
@@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane,

 	*format = rcar_du_format_info(state->fb->format->format);
 	if (*format == NULL) {
-		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
-			state->fb->format->format);
+		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n", __func__,
+			&state->fb->format->format);
 		return -EINVAL;
 	}

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
index 25f50a297c11..8cd37d7b8ae2 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
@@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct drm_encoder *encoder,

 	wb_state->format = rcar_du_format_info(fb->format->format);
 	if (wb_state->format == NULL) {
-		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
-			fb->format->format);
+		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n", __func__,
+			&fb->format->format);
 		return -EINVAL;
 	}

I can add these changes to the patch and update the commit message when
applying if you're fine with that. In that case,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

RE: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Biju Das]

Hi Laurent,

Thanks for the feedback.

> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > Replace use of struct rcar_du_format_info with %p4cc for printing 4CC
> > formats.
> 
> The code change looks good, but doesn't match the commit message. You're
> not replacing usage of struct rcar_du_format_info. I propose the
> following commit message:
> 
> Use the %p4cc format specifier to print 4CCs, which will provide a more
> readable message than the raw hex value.

OK.

> 
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > index 21881fb5e84a..8c2719efda2a 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct
> > drm_file *file_priv,
> >
> >  	format = rcar_du_format_info(mode_cmd->pixel_format);
> >  	if (format == NULL) {
> > -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > -			mode_cmd->pixel_format);
> > +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > +			&mode_cmd->pixel_format);
> >  		return ERR_PTR(-EINVAL);
> >  	}
> >
> 
> There are two other occurrences:
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> index 26b25ca58968..83631ee2fff1 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane
> *plane,
> 
>  	*format = rcar_du_format_info(state->fb->format->format);
>  	if (*format == NULL) {
> -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> -			state->fb->format->format);
> +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> __func__,
> +			&state->fb->format->format);
>  		return -EINVAL;
>  	}
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> index 25f50a297c11..8cd37d7b8ae2 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> drm_encoder *encoder,
> 
>  	wb_state->format = rcar_du_format_info(fb->format->format);
>  	if (wb_state->format == NULL) {
> -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> -			fb->format->format);
> +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> __func__,
> +			&fb->format->format);
>  		return -EINVAL;
>  	}
> 
> I can add these changes to the patch and update the commit message when
> applying if you're fine with that. In that case,

I am ok with it.

Is it possible for you to share the git tree with latest RCar DU changes?
so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.

Currently I am rebasing on top of drm_tip. Please let me know.

Thanks and regards,
Biju

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 

RE: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Biju Das]

Hi Laurent,

Thanks for the feedback.

> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > Replace use of struct rcar_du_format_info with %p4cc for printing 4CC
> > formats.
> 
> The code change looks good, but doesn't match the commit message. You're
> not replacing usage of struct rcar_du_format_info. I propose the
> following commit message:
> 
> Use the %p4cc format specifier to print 4CCs, which will provide a more
> readable message than the raw hex value.

OK.

> 
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > index 21881fb5e84a..8c2719efda2a 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct
> > drm_file *file_priv,
> >
> >  	format = rcar_du_format_info(mode_cmd->pixel_format);
> >  	if (format == NULL) {
> > -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > -			mode_cmd->pixel_format);
> > +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > +			&mode_cmd->pixel_format);
> >  		return ERR_PTR(-EINVAL);
> >  	}
> >
> 
> There are two other occurrences:
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> index 26b25ca58968..83631ee2fff1 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane
> *plane,
> 
>  	*format = rcar_du_format_info(state->fb->format->format);
>  	if (*format == NULL) {
> -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> -			state->fb->format->format);
> +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> __func__,
> +			&state->fb->format->format);
>  		return -EINVAL;
>  	}
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> index 25f50a297c11..8cd37d7b8ae2 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> drm_encoder *encoder,
> 
>  	wb_state->format = rcar_du_format_info(fb->format->format);
>  	if (wb_state->format == NULL) {
> -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> -			fb->format->format);
> +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> __func__,
> +			&fb->format->format);
>  		return -EINVAL;
>  	}
> 
> I can add these changes to the patch and update the commit message when
> applying if you're fine with that. In that case,

I am ok with it.

Is it possible for you to share the git tree with latest RCar DU changes?
so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.

Currently I am rebasing on top of drm_tip. Please let me know.

Thanks and regards,
Biju

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 

Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Laurent Pinchart]

Hi Biju,

On Sat, Aug 27, 2022 at 09:04:25AM +0000, Biju Das wrote:
> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> > On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > > Replace use of struct rcar_du_format_info with %p4cc for printing 4CC
> > > formats.
> > 
> > The code change looks good, but doesn't match the commit message. You're
> > not replacing usage of struct rcar_du_format_info. I propose the
> > following commit message:
> > 
> > Use the %p4cc format specifier to print 4CCs, which will provide a more
> > readable message than the raw hex value.
> 
> OK.
> 
> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > index 21881fb5e84a..8c2719efda2a 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct
> > > drm_file *file_priv,
> > >
> > >  	format = rcar_du_format_info(mode_cmd->pixel_format);
> > >  	if (format == NULL) {
> > > -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > > -			mode_cmd->pixel_format);
> > > +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > > +			&mode_cmd->pixel_format);
> > >  		return ERR_PTR(-EINVAL);
> > >  	}
> > >
> > 
> > There are two other occurrences:
> > 
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > index 26b25ca58968..83631ee2fff1 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane
> > *plane,
> > 
> >  	*format = rcar_du_format_info(state->fb->format->format);
> >  	if (*format == NULL) {
> > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > -			state->fb->format->format);
> > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > __func__,
> > +			&state->fb->format->format);
> >  		return -EINVAL;
> >  	}
> > 
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > index 25f50a297c11..8cd37d7b8ae2 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> > drm_encoder *encoder,
> > 
> >  	wb_state->format = rcar_du_format_info(fb->format->format);
> >  	if (wb_state->format == NULL) {
> > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > -			fb->format->format);
> > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > __func__,
> > +			&fb->format->format);
> >  		return -EINVAL;
> >  	}
> > 
> > I can add these changes to the patch and update the commit message when
> > applying if you're fine with that. In that case,
> 
> I am ok with it.
> 
> Is it possible for you to share the git tree with latest RCar DU changes?
> so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.
> 
> Currently I am rebasing on top of drm_tip. Please let me know.

Sure. The tree is available at git://linuxtv.org/pinchartl/media.git,
and my drm next branch for the DU driver is drm/du/next.

> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Laurent Pinchart]

Hi Biju,

On Sat, Aug 27, 2022 at 09:04:25AM +0000, Biju Das wrote:
> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> > On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > > Replace use of struct rcar_du_format_info with %p4cc for printing 4CC
> > > formats.
> > 
> > The code change looks good, but doesn't match the commit message. You're
> > not replacing usage of struct rcar_du_format_info. I propose the
> > following commit message:
> > 
> > Use the %p4cc format specifier to print 4CCs, which will provide a more
> > readable message than the raw hex value.
> 
> OK.
> 
> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > index 21881fb5e84a..8c2719efda2a 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct
> > > drm_file *file_priv,
> > >
> > >  	format = rcar_du_format_info(mode_cmd->pixel_format);
> > >  	if (format == NULL) {
> > > -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > > -			mode_cmd->pixel_format);
> > > +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > > +			&mode_cmd->pixel_format);
> > >  		return ERR_PTR(-EINVAL);
> > >  	}
> > >
> > 
> > There are two other occurrences:
> > 
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > index 26b25ca58968..83631ee2fff1 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane
> > *plane,
> > 
> >  	*format = rcar_du_format_info(state->fb->format->format);
> >  	if (*format == NULL) {
> > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > -			state->fb->format->format);
> > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > __func__,
> > +			&state->fb->format->format);
> >  		return -EINVAL;
> >  	}
> > 
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > index 25f50a297c11..8cd37d7b8ae2 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> > drm_encoder *encoder,
> > 
> >  	wb_state->format = rcar_du_format_info(fb->format->format);
> >  	if (wb_state->format == NULL) {
> > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > -			fb->format->format);
> > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > __func__,
> > +			&fb->format->format);
> >  		return -EINVAL;
> >  	}
> > 
> > I can add these changes to the patch and update the commit message when
> > applying if you're fine with that. In that case,
> 
> I am ok with it.
> 
> Is it possible for you to share the git tree with latest RCar DU changes?
> so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.
> 
> Currently I am rebasing on top of drm_tip. Please let me know.

Sure. The tree is available at git://linuxtv.org/pinchartl/media.git,
and my drm next branch for the DU driver is drm/du/next.

> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

RE: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Biju Das]

Hi Laurent,

> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> 
> Hi Biju,
> 
> On Sat, Aug 27, 2022 at 09:04:25AM +0000, Biju Das wrote:
> > Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> > > On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > > > Replace use of struct rcar_du_format_info with %p4cc for printing
> > > > 4CC formats.
> > >
> > > The code change looks good, but doesn't match the commit message.
> > > You're not replacing usage of struct rcar_du_format_info. I propose
> > > the following commit message:
> > >
> > > Use the %p4cc format specifier to print 4CCs, which will provide a
> > > more readable message than the raw hex value.
> >
> > OK.
> >
> > > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > ---
> > > >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > index 21881fb5e84a..8c2719efda2a 100644
> > > > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev,
> > > > struct drm_file *file_priv,
> > > >
> > > >  	format = rcar_du_format_info(mode_cmd->pixel_format);
> > > >  	if (format == NULL) {
> > > > -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > > > -			mode_cmd->pixel_format);
> > > > +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > > > +			&mode_cmd->pixel_format);
> > > >  		return ERR_PTR(-EINVAL);
> > > >  	}
> > > >
> > >
> > > There are two other occurrences:
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > index 26b25ca58968..83631ee2fff1 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct
> > > drm_plane *plane,
> > >
> > >  	*format = rcar_du_format_info(state->fb->format->format);
> > >  	if (*format == NULL) {
> > > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > > -			state->fb->format->format);
> > > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > > __func__,
> > > +			&state->fb->format->format);
> > >  		return -EINVAL;
> > >  	}
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > index 25f50a297c11..8cd37d7b8ae2 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> > > drm_encoder *encoder,
> > >
> > >  	wb_state->format = rcar_du_format_info(fb->format->format);
> > >  	if (wb_state->format == NULL) {
> > > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > > -			fb->format->format);
> > > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > > __func__,
> > > +			&fb->format->format);
> > >  		return -EINVAL;
> > >  	}
> > >
> > > I can add these changes to the patch and update the commit message
> > > when applying if you're fine with that. In that case,
> >
> > I am ok with it.
> >
> > Is it possible for you to share the git tree with latest RCar DU
> changes?
> > so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.
> >
> > Currently I am rebasing on top of drm_tip. Please let me know.
> 
> Sure. The tree is available at git://linuxtv.org/pinchartl/media.git,
> and my drm next branch for the DU driver is drm/du/next.

Thank you, Will rebase on drm/du/next

Cheers,
Biju

 
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> --
> Regards,
> 
> Laurent Pinchart

RE: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format

[Biju Das]

Hi Laurent,

> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> 
> Hi Biju,
> 
> On Sat, Aug 27, 2022 at 09:04:25AM +0000, Biju Das wrote:
> > Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> > > On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > > > Replace use of struct rcar_du_format_info with %p4cc for printing
> > > > 4CC formats.
> > >
> > > The code change looks good, but doesn't match the commit message.
> > > You're not replacing usage of struct rcar_du_format_info. I propose
> > > the following commit message:
> > >
> > > Use the %p4cc format specifier to print 4CCs, which will provide a
> > > more readable message than the raw hex value.
> >
> > OK.
> >
> > > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > ---
> > > >  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > index 21881fb5e84a..8c2719efda2a 100644
> > > > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev,
> > > > struct drm_file *file_priv,
> > > >
> > > >  	format = rcar_du_format_info(mode_cmd->pixel_format);
> > > >  	if (format == NULL) {
> > > > -		dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > > > -			mode_cmd->pixel_format);
> > > > +		dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > > > +			&mode_cmd->pixel_format);
> > > >  		return ERR_PTR(-EINVAL);
> > > >  	}
> > > >
> > >
> > > There are two other occurrences:
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > index 26b25ca58968..83631ee2fff1 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > > @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct
> > > drm_plane *plane,
> > >
> > >  	*format = rcar_du_format_info(state->fb->format->format);
> > >  	if (*format == NULL) {
> > > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > > -			state->fb->format->format);
> > > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > > __func__,
> > > +			&state->fb->format->format);
> > >  		return -EINVAL;
> > >  	}
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > index 25f50a297c11..8cd37d7b8ae2 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > > @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> > > drm_encoder *encoder,
> > >
> > >  	wb_state->format = rcar_du_format_info(fb->format->format);
> > >  	if (wb_state->format == NULL) {
> > > -		dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > > -			fb->format->format);
> > > +		dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > > __func__,
> > > +			&fb->format->format);
> > >  		return -EINVAL;
> > >  	}
> > >
> > > I can add these changes to the patch and update the commit message
> > > when applying if you're fine with that. In that case,
> >
> > I am ok with it.
> >
> > Is it possible for you to share the git tree with latest RCar DU
> changes?
> > so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.
> >
> > Currently I am rebasing on top of drm_tip. Please let me know.
> 
> Sure. The tree is available at git://linuxtv.org/pinchartl/media.git,
> and my drm next branch for the DU driver is drm/du/next.

Thank you, Will rebase on drm/du/next

Cheers,
Biju

 
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> --
> Regards,
> 
> Laurent Pinchart