From: Hawkins Jiawei <yin31149@gmail.com>
To: yin31149@gmail.com
Cc: akpm@linux-foundation.org, anton@tuxera.com,
chenxiaosong2@huawei.com, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net,
syzbot+5f8dcabe4a3b2c51c607@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] ntfs: change check order in ntfs_attr_find
Date: Fri, 26 Aug 2022 23:54:05 +0800 [thread overview]
Message-ID: <20220826155405.7506-1-yin31149@gmail.com> (raw)
In-Reply-To: <20220826154231.6634-1-yin31149@gmail.com>
On Fri, 26 Aug 2022 at 23:49, Hawkins Jiawei <yin31149@gmail.com> wrote:
>
> >
> > Btw, this was in the original code, but those casts are ugly. Ideally
> > there would be some way to get rid of them. But otherwise at least
> > put a space after the u8. "(u8 *)a < (u8 *)ctx->mrec".
> >
> > > u8 *name_end = (u8 *)a + le16_to_cpu(a->name_offset) +
> > > a->name_length * sizeof(ntfschar);
> > > - if ((u8*)a < (u8*)ctx->mrec || (u8*)a > mrec_end ||
> > > - name_end > mrec_end)
> > > + if (name_end > mrec_end)
> > > break;
> >
> > regards,
> > dan carpenter
> So maybe I can try to refactor these codes. But I wonder if this can be
> done in a seperate bug
Sorry for the typing error. I mean refactoring these code
in another seperate patch seems better.
next prev parent reply other threads:[~2022-08-26 15:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 18:25 [syzbot] KASAN: use-after-free Read in ntfs_attr_find syzbot
2022-08-25 18:32 ` Siddh Raman Pant
2022-08-25 18:34 ` Siddh Raman Pant
2022-08-26 12:27 ` [PATCH] ntfs: change check order " Hawkins Jiawei
2022-08-26 12:32 ` Hawkins Jiawei
2022-08-26 14:16 ` [syzbot] KASAN: use-after-free Read " syzbot
2022-08-26 15:15 ` [PATCH] ntfs: change check order " Dan Carpenter
2022-08-26 15:42 ` Hawkins Jiawei
2022-08-26 15:54 ` Hawkins Jiawei [this message]
2022-08-27 6:42 ` Dan Carpenter
2022-08-27 9:02 ` Hawkins Jiawei
2022-08-27 10:58 ` Dan Carpenter
2022-08-28 16:15 ` Hawkins Jiawei
2022-08-27 2:42 ` Andrew Morton
2022-08-27 8:38 ` Hawkins Jiawei
2022-08-27 1:28 ` chenxiaosong (A)
2022-08-27 7:51 ` Hawkins Jiawei
2022-08-27 14:49 ` Hawkins Jiawei
2022-08-29 9:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826155405.7506-1-yin31149@gmail.com \
--to=yin31149@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anton@tuxera.com \
--cc=chenxiaosong2@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=syzbot+5f8dcabe4a3b2c51c607@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.