From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55520ECAAD6 for ; Fri, 26 Aug 2022 19:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243811AbiHZTHG (ORCPT ); Fri, 26 Aug 2022 15:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235293AbiHZTHF (ORCPT ); Fri, 26 Aug 2022 15:07:05 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4339F65261 for ; Fri, 26 Aug 2022 12:07:04 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A69EC5C0423; Fri, 26 Aug 2022 15:07:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Aug 2022 15:07:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1661540823; x=1661627223; bh=Exk195AyM7 P1/5PWxUSceTzP0jfwUbbF1dWiDPom9Fo=; b=i7G7RlYa7fHAZzuN7we0Q5YU8y VckSh4eWKKviwHxjd1xcKijiSiXnbi3MrNyWHf4k0AaS9djWdbU3q3E4dMXnRxse xyl5QFceQnuXQ7UAoZDgXibiouJj6IfMdO0Q5W4K0D4p+Qc1Fa1HvqRqjCGGVb/B nU7pDQyThdFZE7vnqkug8ZLvg0gF45efTYIiOal78azLPctk26WN7DaEzOCT/fP1 GkPqZR/4HXAW4J1ji5FmgEFj0NrFhMyA6xmkQZ7FLN8s1WKzOdvlr1/McGxIniTH 88QmhNK3vHD4tlDAx9eSMny5bLOUcNeaQXwFuiEkASib7kICDJl2e34/E+dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661540823; x=1661627223; bh=Exk195AyM7P1/5PWxUSceTzP0jfw UbbF1dWiDPom9Fo=; b=SaRjvS1KQaQIbCjJsRxuBH6Zn2quzo0qwFDFcMemj+kt EvojNGdaEicoY59yJTp8h4AZi0FMGrlGZHhy9fH200hUe4J4bof9r18firpEOcC5 0OFodDxHjl+41yAkbZfKWE8aOe2gG9gqspKWNhvB9EF/PX7SykBmxiAZHTGFsLSZ N9lVhW46tPE1GSEQtc2qqaZWIvjHwNhi6mk2fB5kuP6dR3Y0vyyBZDcNRCx9MNgL BdgDxhPNAcM+8aDVGxpELuI9D6e110+SZ5RtSuVMeXUXrQYdjYxLCTcHFrocexUJ lHaSwjQrD1+8zjeKx90MgtOyJzr5jxMNjJa3L8hglA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejhedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttdejnecuhfhrohhmpeffrghf nhgrucfjihhrshgthhhfvghlugcuoegurghfnhgrsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepheeivdejhedvffelkeffvdejvdeiheehtdethfdvtdeufeeu keelhfetuddugfejnecuffhomhgrihhnpehinhhfrhgruggvrggurdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggrfhhnrgesfhgr shhtmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i0e894699:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Aug 2022 15:07:01 -0400 (EDT) Date: Fri, 26 Aug 2022 22:06:58 +0300 From: Dafna Hirschfeld To: Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, Heiko Stuebner , Florian Sylvestre , Paul Elder Subject: Re: [PATCH v1.1 4/5] media: rkisp1: Use correct macro for gradient registers Message-ID: <20220826190658.il7m6pws3dgzfweb@guri> References: <20220817021850.20460-5-laurent.pinchart@ideasonboard.com> <20220823172136.9342-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20220823172136.9342-1-laurent.pinchart@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 23.08.2022 20:21, Laurent Pinchart wrote: >The rkisp1_lsc_config() function incorrectly uses the >RKISP1_CIF_ISP_LSC_SECT_SIZE() macro for the gradient registers. Replace >it with the correct macro, and rename it from >RKISP1_CIF_ISP_LSC_GRAD_SIZE() to RKISP1_CIF_ISP_LSC_SECT_GRAD() as the >corresponding registers store the gradients for each sector, not a size. >This doesn't cause any functional change as the two macros are defined >identically (the size and gradient registers store fields in the same >number of bits at the same positions). > >Signed-off-by: Laurent Pinchart Reviewed-by: Dafna Hirschfeld >--- >Changes since v1: > >- Rename RKISP1_CIF_ISP_LSC_GRAD_SIZE to RKISP1_CIF_ISP_LSC_SECT_GRAD >--- > drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 4 ++-- > drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c >index aa6efa4c6e9e..123c26fc1679 100644 >--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c >+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c >@@ -334,7 +334,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params, > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XSIZE(i), data); > > /* program x grad tables */ >- data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->x_grad_tbl[i * 2], >+ data = RKISP1_CIF_ISP_LSC_SECT_GRAD(arg->x_grad_tbl[i * 2], > arg->x_grad_tbl[i * 2 + 1]); > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XGRAD(i), data); > >@@ -344,7 +344,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params, > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YSIZE(i), data); > > /* program y grad tables */ >- data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->y_grad_tbl[i * 2], >+ data = RKISP1_CIF_ISP_LSC_SECT_GRAD(arg->y_grad_tbl[i * 2], > arg->y_grad_tbl[i * 2 + 1]); > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YGRAD(i), data); > } >diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h >index 2ad24deedec8..39b2ac58196e 100644 >--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h >+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h >@@ -619,7 +619,7 @@ > (((v0) & 0x1FFF) | (((v1) & 0x1FFF) << 13)) > #define RKISP1_CIF_ISP_LSC_SECT_SIZE(v0, v1) \ > (((v0) & 0xFFF) | (((v1) & 0xFFF) << 16)) >-#define RKISP1_CIF_ISP_LSC_GRAD_SIZE(v0, v1) \ >+#define RKISP1_CIF_ISP_LSC_SECT_GRAD(v0, v1) \ > (((v0) & 0xFFF) | (((v1) & 0xFFF) << 16)) > > /* LSC: ISP_LSC_TABLE_SEL */ >-- >Regards, > >Laurent Pinchart > > >_______________________________________________ >Linux-rockchip mailing list >Linux-rockchip@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6554ECAAA3 for ; Fri, 26 Aug 2022 19:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F209ByvDFhwRUGHDCQF79Nf0tu9tXx53D9qpYIZtaNg=; b=YVMT3PQ4/VsiAp0ZJltQ5iFBWq 0Uqj32EE9v8c+xCHOsqd4kDLm2EqkKJfjg740Pxf7tR4wc2uh6fPskE/oNSsXXd8sgYbcSA/CrxRI yGfWFuBrcgB84iMkcEzWG3kv1rSSKE4J4/PX9EJkadfuI9eWLK3SNWqWriZNatDUpXIEZZ8StPEMb eL/821jJcfiisQBqC0nNAGF0oNfE3kRvfZm1tpLlxQlYxTgDdojrj9GbuCAn96AR79Fk60J8au1QI dRNGHleggJI+twD8nX9BAAIWLNRpBhZ629iPPPtolDbncgf1J68Hisl35PVPrQll5AKT750tXE2At iCOOkMWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRezf-00Aejf-Ey; Fri, 26 Aug 2022 19:27:51 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRefY-00AOKX-Cq for linux-rockchip@lists.infradead.org; Fri, 26 Aug 2022 19:07:06 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A69EC5C0423; Fri, 26 Aug 2022 15:07:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Aug 2022 15:07:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1661540823; x=1661627223; bh=Exk195AyM7 P1/5PWxUSceTzP0jfwUbbF1dWiDPom9Fo=; b=i7G7RlYa7fHAZzuN7we0Q5YU8y VckSh4eWKKviwHxjd1xcKijiSiXnbi3MrNyWHf4k0AaS9djWdbU3q3E4dMXnRxse xyl5QFceQnuXQ7UAoZDgXibiouJj6IfMdO0Q5W4K0D4p+Qc1Fa1HvqRqjCGGVb/B nU7pDQyThdFZE7vnqkug8ZLvg0gF45efTYIiOal78azLPctk26WN7DaEzOCT/fP1 GkPqZR/4HXAW4J1ji5FmgEFj0NrFhMyA6xmkQZ7FLN8s1WKzOdvlr1/McGxIniTH 88QmhNK3vHD4tlDAx9eSMny5bLOUcNeaQXwFuiEkASib7kICDJl2e34/E+dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661540823; x=1661627223; bh=Exk195AyM7P1/5PWxUSceTzP0jfw UbbF1dWiDPom9Fo=; b=SaRjvS1KQaQIbCjJsRxuBH6Zn2quzo0qwFDFcMemj+kt EvojNGdaEicoY59yJTp8h4AZi0FMGrlGZHhy9fH200hUe4J4bof9r18firpEOcC5 0OFodDxHjl+41yAkbZfKWE8aOe2gG9gqspKWNhvB9EF/PX7SykBmxiAZHTGFsLSZ N9lVhW46tPE1GSEQtc2qqaZWIvjHwNhi6mk2fB5kuP6dR3Y0vyyBZDcNRCx9MNgL BdgDxhPNAcM+8aDVGxpELuI9D6e110+SZ5RtSuVMeXUXrQYdjYxLCTcHFrocexUJ lHaSwjQrD1+8zjeKx90MgtOyJzr5jxMNjJa3L8hglA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejhedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttdejnecuhfhrohhmpeffrghf nhgrucfjihhrshgthhhfvghlugcuoegurghfnhgrsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepheeivdejhedvffelkeffvdejvdeiheehtdethfdvtdeufeeu keelhfetuddugfejnecuffhomhgrihhnpehinhhfrhgruggvrggurdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggrfhhnrgesfhgr shhtmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i0e894699:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Aug 2022 15:07:01 -0400 (EDT) Date: Fri, 26 Aug 2022 22:06:58 +0300 From: Dafna Hirschfeld To: Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, Heiko Stuebner , Florian Sylvestre , Paul Elder Subject: Re: [PATCH v1.1 4/5] media: rkisp1: Use correct macro for gradient registers Message-ID: <20220826190658.il7m6pws3dgzfweb@guri> References: <20220817021850.20460-5-laurent.pinchart@ideasonboard.com> <20220823172136.9342-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220823172136.9342-1-laurent.pinchart@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_120704_541031_9F459CFD X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 23.08.2022 20:21, Laurent Pinchart wrote: >The rkisp1_lsc_config() function incorrectly uses the >RKISP1_CIF_ISP_LSC_SECT_SIZE() macro for the gradient registers. Replace >it with the correct macro, and rename it from >RKISP1_CIF_ISP_LSC_GRAD_SIZE() to RKISP1_CIF_ISP_LSC_SECT_GRAD() as the >corresponding registers store the gradients for each sector, not a size. >This doesn't cause any functional change as the two macros are defined >identically (the size and gradient registers store fields in the same >number of bits at the same positions). > >Signed-off-by: Laurent Pinchart Reviewed-by: Dafna Hirschfeld >--- >Changes since v1: > >- Rename RKISP1_CIF_ISP_LSC_GRAD_SIZE to RKISP1_CIF_ISP_LSC_SECT_GRAD >--- > drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 4 ++-- > drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c >index aa6efa4c6e9e..123c26fc1679 100644 >--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c >+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c >@@ -334,7 +334,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params, > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XSIZE(i), data); > > /* program x grad tables */ >- data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->x_grad_tbl[i * 2], >+ data = RKISP1_CIF_ISP_LSC_SECT_GRAD(arg->x_grad_tbl[i * 2], > arg->x_grad_tbl[i * 2 + 1]); > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XGRAD(i), data); > >@@ -344,7 +344,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params, > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YSIZE(i), data); > > /* program y grad tables */ >- data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->y_grad_tbl[i * 2], >+ data = RKISP1_CIF_ISP_LSC_SECT_GRAD(arg->y_grad_tbl[i * 2], > arg->y_grad_tbl[i * 2 + 1]); > rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YGRAD(i), data); > } >diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h >index 2ad24deedec8..39b2ac58196e 100644 >--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h >+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h >@@ -619,7 +619,7 @@ > (((v0) & 0x1FFF) | (((v1) & 0x1FFF) << 13)) > #define RKISP1_CIF_ISP_LSC_SECT_SIZE(v0, v1) \ > (((v0) & 0xFFF) | (((v1) & 0xFFF) << 16)) >-#define RKISP1_CIF_ISP_LSC_GRAD_SIZE(v0, v1) \ >+#define RKISP1_CIF_ISP_LSC_SECT_GRAD(v0, v1) \ > (((v0) & 0xFFF) | (((v1) & 0xFFF) << 16)) > > /* LSC: ISP_LSC_TABLE_SEL */ >-- >Regards, > >Laurent Pinchart > > >_______________________________________________ >Linux-rockchip mailing list >Linux-rockchip@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip