From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Wolfgang Denk <wd@denx.de>, Simon Glass <sjg@chromium.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2] xyz-modem: Allow to configure initial timeout for loadx and loady
Date: Sat, 27 Aug 2022 10:30:05 -0400 [thread overview]
Message-ID: <20220827143005.GJ7942@bill-the-cat> (raw)
In-Reply-To: <20220827125615.t4obqj43vb53raiy@pali>
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
On Sat, Aug 27, 2022 at 02:56:15PM +0200, Pali Rohár wrote:
> On Saturday 27 August 2022 08:53:08 Tom Rini wrote:
> > On Sat, Aug 27, 2022 at 01:48:35PM +0200, Pali Rohár wrote:
> >
> > > Now when loadx and loady commands could be aborted / cancelled by CTRL+C,
> > > allow to configure timeout for initial x/y-modem packet via env variable
> > > $loadxy_timeout and by default use value from new compile-time config
> > > option CONFIG_CMD_LOADXY_TIMEOUT. Value is in seconds and zero value means
> > > infinite timeout. Default value is 90s which is the measured value used
> > > before this change for loadx and loady commands.
> > >
> > > Other load commands loadb and loads already waits infinitely. Same behavior
> > > for loadx and loady commands can be achieved by setting $loadxy_timeout or
> > > CONFIG_CMD_LOADXY_TIMEOUT to 0.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > > Changes in v2:
> > > * Allow to set timeout via env instead of permanent infinite timeout
> >
> > This breaks platforms like "porter" where we have SPL_YMODEM support but
> > do not have environment support.
>
> By "breaks" do you mean compile error? Because if env is not set then
> CONFIG_CMD_LOADXY_TIMEOUT is used. Just I'm not sure if env_get()
> function returns NULL or what when there is no environment support.
Yes, it fails to link.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-08-27 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 20:46 [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet Pali Rohár
2021-09-10 20:46 ` [PATCH 2/2] xyz-modem: Wait infinitely for initial x-modem packet Pali Rohár
2021-09-13 10:43 ` Wolfgang Denk
2021-09-13 10:42 ` [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet Wolfgang Denk
2021-09-13 11:08 ` Pali Rohár
2021-09-13 12:12 ` Wolfgang Denk
2021-09-13 12:22 ` Pali Rohár
2021-09-13 13:02 ` Wolfgang Denk
2022-08-27 11:50 ` Pali Rohár
2021-09-13 14:32 ` Tom Rini
2022-08-27 11:48 ` [PATCH v2] xyz-modem: Allow to configure initial timeout for loadx and loady Pali Rohár
2022-08-27 12:53 ` Tom Rini
2022-08-27 12:56 ` Pali Rohár
2022-08-27 14:30 ` Tom Rini [this message]
2022-08-27 14:32 ` Pali Rohár
2022-08-27 14:41 ` Tom Rini
2022-08-27 14:47 ` Pali Rohár
2022-08-29 14:54 ` Heinrich Schuchardt
2022-08-27 14:37 ` [PATCH v3] " Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827143005.GJ7942@bill-the-cat \
--to=trini@konsulko.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.