From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C97B6C0502C for ; Sun, 28 Aug 2022 19:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbiH1TaO (ORCPT ); Sun, 28 Aug 2022 15:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbiH1TaM (ORCPT ); Sun, 28 Aug 2022 15:30:12 -0400 Received: from vorpal.se (vorpal.se [IPv6:2a01:7e00::f03c:91ff:fe73:398e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46BEF10FCA; Sun, 28 Aug 2022 12:29:55 -0700 (PDT) Received: by vorpal.se (Postfix) with ESMTPSA id 4896114629; Sun, 28 Aug 2022 19:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vorpal.se; s=2019; t=1661714993; bh=27gm5R3zURqjI4/mvmf25FHer+yapIFUWqt2wrWO/M0=; h=From:To:Cc:Subject:Date:From; b=ZUUwVq6R3IKwoT37UflOBJburjgXVo6F9yF03FydtrP40IjIbQn903VFMhT4E0vVM SpnxNhCFyNjlT9gOV5D7xgtPVysKh67IvYJW8zxDrvwi6bhQPq7fX7Ohw06VOBHMAZ 0g39Ve7Sm9pHSFErDYzobU0o9WYQtpl8agKo72fOj2KG0hz37zn97JL3i8gUWqF0j6 bwL/OoQS8LSYmwO64p6FzpF8RwoOTP/4VXoTaf2Bv7pomAkUF4iNSmfmNNqvrqynGG erhuODdre76rwdBGXNDl7psszo1syrRBLx04aszG2qebC4EGKSfvgvSAaGDxT5tQpe 0yAeWG1XQVKTA== From: Arvid Norlander To: platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org Cc: Sebastian Reichel , Hans de Goede , Azael Avalos , Arvid Norlander Subject: [PATCH 0/3] platform/x86: Battery charge mode in toshiba_acpi Date: Sun, 28 Aug 2022 21:29:17 +0200 Message-Id: <20220828192920.805253-1-lkml@vorpal.se> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org This is an improved version of the battery charge control for Toshiba Satellite Z830. The full background is available in the two emails linked below, but a short summary will follow, including only what is relevant for battery charge control. Background (from link 1) ========== The Toshiba Satellite/Portege Z830 supports not charging the battery fully in order to prolong battery life. Unlike for example ThinkPads where this control is granular here it is just off/on. When off it charges to 100%. When on it charges to about 80%. According to the Windows program used to control the feature the setting will not take effect until the battery has been discharged to around 50%. However, in my testing it takes effect as soon as the charge drops below 80%. On Windows Toshiba branded this feature as "Eco charging" In the following example ACPI calls I will use the following newly defined constants: #define HCI_BATTERY_CHARGE_MODE 0xba #define BATTERY_CHARGE_FULL 0 #define BATTERY_CHARGE_80_PERCENT 1 To set the feature: {HCI_SET, HCI_BATTERY_CHARGE_MODE, charge_mode, 0, 0, 0} To query for the existence of the feature: {HCI_GET, HCI_BATTERY_CHARGE_MODE, 0, 0, 0, 0} To read the feature: {HCI_GET, HCI_BATTERY_CHARGE_MODE, 0, 0, 0, 1} The read may need to be retried if TOS_DATA_NOT_AVAILABLE is returned as the status code. This rarely happens (I have never observed it on Linux), but I have seen it happen under Windows once, and the software did retry it. Improvements ============ As discussed in link 2 & 3 below, the original approach was suboptimal. This patch series instead consists of two patches. The first patch implements detecting the feature as well as internal getter/setter methods. The second patch adds battery hooks (heavily based on the code for this in thinkpad_acpi) which creates the standard charge_control_end_threshold file under /sys/class/power_supply/BAT1. Side note: There is no BAT0 on this Toshiba, I'm not sure why the numbering ends up starting from 1 instead of 0 here. This differs from my Thinkpads, where the numbering starts from 0, with BAT1 being the second battery. However, I haven't spent much effort investigating this, as it did not seem important. Patch 3 updates the ABI test documentation as suggested by Hans de Goede. Note that only the charge_control_end_threshold is updated, as this is the only limit supported by the Toshiba Z830. Possibly charge_control_start_threshold should also be updated similarly, or would it be better to wait for an actual example of this in the wild first? Link (1): https://www.spinics.net/lists/platform-driver-x86/msg34314.html Link (2): https://www.spinics.net/lists/platform-driver-x86/msg34354.html Link (3): https://www.spinics.net/lists/platform-driver-x86/msg34320.html Arvid Norlander (3): platform/x86: Battery charge mode in toshiba_acpi (internals) platform/x86: Battery charge mode in toshiba_acpi (sysfs) docs: ABI: charge_control_end_threshold may not support all values Documentation/ABI/testing/sysfs-class-power | 5 +- drivers/platform/x86/toshiba_acpi.c | 162 ++++++++++++++++++++ 2 files changed, 166 insertions(+), 1 deletion(-) base-commit: 1c23f9e627a7b412978b4e852793c5e3c3efc555 -- 2.37.2