From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90834ECAAA1 for ; Tue, 30 Aug 2022 07:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231324AbiH3H6E (ORCPT ); Tue, 30 Aug 2022 03:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiH3H6B (ORCPT ); Tue, 30 Aug 2022 03:58:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE5BD11E2 for ; Tue, 30 Aug 2022 00:58:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BBA23B816CE for ; Tue, 30 Aug 2022 07:57:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B516C433D6; Tue, 30 Aug 2022 07:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661846278; bh=tMezW17H30QYH+rtqSZLpnK9Zmp87zjX0uCL3+xUkqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tV6oBMpm8Q7OvzGU0kdTL7C8kgKDOwa39BWo+lhO5mOdnUsOAVhk52V2fbzv24ZnQ +RnMsJ0TIPrf/uhtoyHS/EbpuMYrm9G5MwcYfWEoK3W+UHXmFclIvIvH8VMtQxhzy6 D513r5dPHqTXnSZhZPHRQBuoANbJdhdfgNmLG+nmUT9Uwl8YHhZp1QvKjgcybZ2cAw iwW4MVZBn9ND7Tp3nu2VWNfbvF96sNTvb2Djlg4eTm7Gp9GziKL6T6Kx6dqfgBTVmn ba4YAOPC7QMXH8xlJSCF0vjwNUF+cnkO+BgOSLIQyD/tFhh7eqM9/NcNK7nSZZI2Wj I1KlExypp76kQ== Date: Tue, 30 Aug 2022 09:57:52 +0200 From: Christian Brauner To: Carlos Llamas Cc: Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Suren Baghdasaryan , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] binder: remove unused binder_alloc->buffer_free Message-ID: <20220830075752.6lueoqmaskhygb5z@wittgenstein> References: <20220829201254.1814484-1-cmllamas@google.com> <20220829201254.1814484-6-cmllamas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220829201254.1814484-6-cmllamas@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 08:12:52PM +0000, Carlos Llamas wrote: > The ->buffer_free member was introduced in the first revision of the > driver under staging but it appears like it was never actually used > according to git's history. Remove it from binder_alloc. > > Signed-off-by: Carlos Llamas > --- Looks good, Reviewed-by: Christian Brauner (Microsoft)