From: Sean Christopherson <seanjc@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Like Xu <like.xu.linux@gmail.com>
Subject: [PATCH v3 0/3] KVM: x86: Intel LBR related perf cleanups.
Date: Wed, 31 Aug 2022 00:00:48 +0000 [thread overview]
Message-ID: <20220831000051.4015031-1-seanjc@google.com> (raw)
WAS: Bug fixes and cleanups related to KVM's handling of PERF_CAPABILITIES.
Fix a bug where KVM incorrectly advertises PMU_CAP_LBR_FMT to userspace if
perf has disabled LBRs, e.g. because probing one or more LBR MSRs during
setup hit a #GP.
The non-KVM patches remove unnecessary stubs and unreachable error paths,
which allows for a cleaner fix for said bug.
v3:
- Drop patches for bug #1 (already merged).
- Drop misguided "clean up the capability check" patch. [Like]
v2:
- https://lore.kernel.org/all/20220803192658.860033-1-seanjc@google.com
- Add patches to fix bug #2. [Like]
- Add a patch to clean up the capability check.
- Tweak the changelog for the PMU refresh bug fix to call out that
KVM should disallow changing feature MSRs after KVM_RUN. [Like]
v1: https://lore.kernel.org/all/20220727233424.2968356-1-seanjc@google.com
Sean Christopherson (3):
perf/x86/core: Remove unnecessary stubs provided for KVM-only helpers
perf/x86/core: Drop the unnecessary return value from
x86_perf_get_lbr()
KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs
arch/x86/events/intel/lbr.c | 6 +---
arch/x86/include/asm/perf_event.h | 55 ++++++++-----------------------
arch/x86/kvm/vmx/capabilities.h | 5 ++-
3 files changed, 19 insertions(+), 47 deletions(-)
base-commit: 372d07084593dc7a399bf9bee815711b1fb1bcf2
--
2.37.2.672.g94769d06f0-goog
next reply other threads:[~2022-08-31 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 0:00 Sean Christopherson [this message]
2022-08-31 0:00 ` [PATCH v3 1/3] perf/x86/core: Remove unnecessary stubs provided for KVM-only helpers Sean Christopherson
2022-08-31 0:00 ` [PATCH v3 2/3] perf/x86/core: Drop the unnecessary return value from x86_perf_get_lbr() Sean Christopherson
2022-08-31 0:00 ` [PATCH v3 3/3] KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs Sean Christopherson
2022-08-31 9:49 ` kernel test robot
2022-08-31 11:12 ` kernel test robot
2022-08-31 19:54 ` Sean Christopherson
2022-08-31 19:54 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831000051.4015031-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.