From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A7AECAAD3 for ; Thu, 1 Sep 2022 12:55:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233286AbiIAMzm (ORCPT ); Thu, 1 Sep 2022 08:55:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233048AbiIAMzi (ORCPT ); Thu, 1 Sep 2022 08:55:38 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 670D452FFA for ; Thu, 1 Sep 2022 05:55:37 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CDCA35C00E5; Thu, 1 Sep 2022 08:55:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 01 Sep 2022 08:55:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1662036934; x= 1662123334; bh=yCxLNBFGSZRqkuML/VFgGHBhSSM6CHEUn/5kwqQufZ0=; b=J x4GRMiXMqZhv/vKd2o8BiWANJJLYz3WKd5QGf4csZpCG9cZO16EX1zqY87aHLdI2 FFGE/vkG771KuFIJmItNzvjB6KN4JcJwLZYdKQe6/1wyFUsJsVhI1+lBT9IQVqCi qwVOn30fzyVWlD/u3m7HLpJl7YbnAXm5nx37Yi6Z39+9OQFelcnu6kQnY5s6Caqy rq97aMut+ZGgdtQptWC1oTKnreJAJ5BxaWXCSh2kmBkCTnyuhPwrbDjq2EwBUVrP hL5BHjM5wlUV77BPr3ZIv8OftM6K7XMJyXNBrFPZUZcRGsBbFdT+37M8KqgXQABT 3onWHgyg5ws4IwKP2dNOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662036934; x= 1662123334; bh=yCxLNBFGSZRqkuML/VFgGHBhSSM6CHEUn/5kwqQufZ0=; b=m /zcrSii3w5zxhxGrHJs9ZSB5nW8pWOEtE0Gyg3Ti9KJry8F4gm/df2KiCq8RbNST qR8hxXMt6wZEe3FnyMDTzCvUUIi2f6sQGkGxi0FeG4RBfMAY4sgNlxX66RHMDYJV 9LHORQls0jTD/Hy3MPAez+cXmI6f0b4nwdVu8mHAkEtWFAR69VHBgSSovv1E4+sb qftjpbx0ap7hYGhadVT6yKVkFBcIFeeMpQnaFR9DTBnhqKGNQpDK2v77rWlUXQ84 ixh0tu2LcohohcJtopU9gj9zGSKl8wg47yVTPEbhAWKzVXGrBhgnsGxJiobjTl5Q OErJq1f9vEDSIiW+VUUzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekkedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtqhertddttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepjeevffdtheevvdefveffffejkedtgfekvdeigfefhfefgfethfejjeei geeiueegnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgv tghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 08:55:32 -0400 (EDT) Date: Thu, 1 Sep 2022 14:55:30 +0200 From: Maxime Ripard To: =?utf-8?B?TWHDrXJh?= Canal Cc: Isabella Basso , magalilemes00@gmail.com, tales.aparecida@gmail.com, mwen@igalia.com, andrealmeid@riseup.net, siqueirajordao@riseup.net, Trevor Woerner , Daniel Vetter , David Airlie , Javier Martinez Canillas , David Gow , brendanhiggins@google.com, Arthur Grillo , michal.winiarski@intel.com, =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Jani Nikula , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com Subject: Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_" Message-ID: <20220901125530.b56s4zisnkfuigvc@houat> References: <20220901124210.591994-1-mairacanal@riseup.net> <20220901124210.591994-2-mairacanal@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220901124210.591994-2-mairacanal@riseup.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Sep 01, 2022 at 09:42:10AM -0300, Ma=EDra Canal wrote: > With the introduction of KUnit, IGT is no longer the only option to run > the DRM unit tests, as the tests can be run through kunit-tool or on > real hardware with CONFIG_KUNIT. >=20 > Therefore, remove the "igt_" prefix from the tests and replace it with > the "test_drm_" prefix, making the tests' names independent from the tool > used. >=20 > Signed-off-by: Ma=EDra Canal > > --- > v1 -> v2: https://lore.kernel.org/dri-devel/20220830211603.191734-1-maira= canal@riseup.net/ > - Change "drm_" prefix to "test_drm_", as "drm_" can be a bit confusing (= Jani Nikula). I appreciate it's a bit of a bikeshed but I disagree with this. The majority of the kunit tests already out there start with the framework name, including *all* the examples in the kunit doc. Plus, it's fairly obvious that it's a test, kunit is only about running tests in the first place. Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 890E4ECAAD1 for ; Thu, 1 Sep 2022 12:55:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 563B210E6FB; Thu, 1 Sep 2022 12:55:44 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9532010E6FB for ; Thu, 1 Sep 2022 12:55:37 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CDCA35C00E5; Thu, 1 Sep 2022 08:55:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 01 Sep 2022 08:55:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1662036934; x= 1662123334; bh=yCxLNBFGSZRqkuML/VFgGHBhSSM6CHEUn/5kwqQufZ0=; b=J x4GRMiXMqZhv/vKd2o8BiWANJJLYz3WKd5QGf4csZpCG9cZO16EX1zqY87aHLdI2 FFGE/vkG771KuFIJmItNzvjB6KN4JcJwLZYdKQe6/1wyFUsJsVhI1+lBT9IQVqCi qwVOn30fzyVWlD/u3m7HLpJl7YbnAXm5nx37Yi6Z39+9OQFelcnu6kQnY5s6Caqy rq97aMut+ZGgdtQptWC1oTKnreJAJ5BxaWXCSh2kmBkCTnyuhPwrbDjq2EwBUVrP hL5BHjM5wlUV77BPr3ZIv8OftM6K7XMJyXNBrFPZUZcRGsBbFdT+37M8KqgXQABT 3onWHgyg5ws4IwKP2dNOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1662036934; x= 1662123334; bh=yCxLNBFGSZRqkuML/VFgGHBhSSM6CHEUn/5kwqQufZ0=; b=m /zcrSii3w5zxhxGrHJs9ZSB5nW8pWOEtE0Gyg3Ti9KJry8F4gm/df2KiCq8RbNST qR8hxXMt6wZEe3FnyMDTzCvUUIi2f6sQGkGxi0FeG4RBfMAY4sgNlxX66RHMDYJV 9LHORQls0jTD/Hy3MPAez+cXmI6f0b4nwdVu8mHAkEtWFAR69VHBgSSovv1E4+sb qftjpbx0ap7hYGhadVT6yKVkFBcIFeeMpQnaFR9DTBnhqKGNQpDK2v77rWlUXQ84 ixh0tu2LcohohcJtopU9gj9zGSKl8wg47yVTPEbhAWKzVXGrBhgnsGxJiobjTl5Q OErJq1f9vEDSIiW+VUUzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekkedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtqhertddttddunecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepjeevffdtheevvdefveffffejkedtgfekvdeigfefhfefgfethfejjeei geeiueegnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgv tghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 08:55:32 -0400 (EDT) Date: Thu, 1 Sep 2022 14:55:30 +0200 From: Maxime Ripard To: =?utf-8?B?TWHDrXJh?= Canal Subject: Re: [PATCH v2 2/2] drm/tests: Change "igt_" prefix to "test_drm_" Message-ID: <20220901125530.b56s4zisnkfuigvc@houat> References: <20220901124210.591994-1-mairacanal@riseup.net> <20220901124210.591994-2-mairacanal@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220901124210.591994-2-mairacanal@riseup.net> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michal.winiarski@intel.com, David Gow , siqueirajordao@riseup.net, magalilemes00@gmail.com, David Airlie , tales.aparecida@gmail.com, Arthur Grillo , brendanhiggins@google.com, Javier Martinez Canillas , linux-kernel@vger.kernel.org, mwen@igalia.com, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Isabella Basso , andrealmeid@riseup.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Thu, Sep 01, 2022 at 09:42:10AM -0300, Ma=EDra Canal wrote: > With the introduction of KUnit, IGT is no longer the only option to run > the DRM unit tests, as the tests can be run through kunit-tool or on > real hardware with CONFIG_KUNIT. >=20 > Therefore, remove the "igt_" prefix from the tests and replace it with > the "test_drm_" prefix, making the tests' names independent from the tool > used. >=20 > Signed-off-by: Ma=EDra Canal > > --- > v1 -> v2: https://lore.kernel.org/dri-devel/20220830211603.191734-1-maira= canal@riseup.net/ > - Change "drm_" prefix to "test_drm_", as "drm_" can be a bit confusing (= Jani Nikula). I appreciate it's a bit of a bikeshed but I disagree with this. The majority of the kunit tests already out there start with the framework name, including *all* the examples in the kunit doc. Plus, it's fairly obvious that it's a test, kunit is only about running tests in the first place. Maxime