From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5111EECAAD3 for ; Thu, 1 Sep 2022 14:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234291AbiIAODI (ORCPT ); Thu, 1 Sep 2022 10:03:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiIAODD (ORCPT ); Thu, 1 Sep 2022 10:03:03 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5934311A0D; Thu, 1 Sep 2022 07:03:02 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C1DFF5C0134; Thu, 1 Sep 2022 10:02:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 01 Sep 2022 10:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1662040979; x=1662127379; bh=Ffc/RZEQI4 hjFuUkxRf9nBYDShUEErzbXtlvMQHYkoU=; b=JtK+h8hcUlm1NBTcBPP1ao8LIV gFvg9ADICearOe/rAgHMR3oV+RyOIVH7vj295WLfGPdjSFpObwGBvfQ4HlAsgfaU flgYVjBvyC3QKanLZokwOTRdNjZLuFQtrNP4chO9SogHjPV9DW7Ug44sC9/9gy60 j2rhWqJ6ro+sdjAajm5G2ksU2BdmnMJuHHsLBhacGm+vseyulSyzsVDTQRaYpmcQ j7yKtHf8hyjY2TJWs0eCS1N1rFKR2V0XMKniXPLj94B/wFQjIObVvhwwID12D0i7 7pZ+TffkyQC1e2yw9BXpoMIFx2OfY33xzpOtl8l435+NhSp9jcmi2wBWfRzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1662040979; x=1662127379; bh=Ffc/RZEQI4hjFuUkxRf9nBYDShUE ErzbXtlvMQHYkoU=; b=v/7DXqkmseCudlaTbZ4YE06w4cJJdyzbaqa2mxX1XcKy Qn8uqghouxGkwFG9pEuN6vORLUx7HKE4jBXrEM37vNJewbZ8OwEVoIZ/DT7uDc94 s7O4oW4dksqVmhhavz6UN1SRMcErQpdlG38IjfWl19TCRhGTXvBDXYlKVVHSLzrr zDi8Z3Xl6n7kDCapB8k+mM2vTtDD47fphkPykSTh6cOTH8JSyksXZl++nPFrP6P4 JlQiLNcUrj6yA/8uM5F1FavkUEPBwL60LLGlvERXn47A6DRIJLSFurUZMFtDuGE/ 1xr6Xzf7ofsLCYkwa28OmBM0LH8PUEF6yerw/T6fJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekkedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfev teefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 10:02:57 -0400 (EDT) Date: Thu, 1 Sep 2022 16:02:53 +0200 From: Maxime Ripard To: =?utf-8?Q?Micha=C5=82?= Winiarski Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , David Gow , Javier Martinez Canillas , Maarten Lankhorst , Thomas Zimmermann , Jonathan Corbet , Helge Deller , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py Message-ID: <20220901140253.6ebvykv35kyc3v3w@houat> References: <20220901133621.353270-1-michal.winiarski@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lymi6tif3g4nxejp" Content-Disposition: inline In-Reply-To: <20220901133621.353270-1-michal.winiarski@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lymi6tif3g4nxejp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Sep 01, 2022 at 03:36:21PM +0200, Micha=C5=82 Winiarski wrote: > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in > IOMEM and DMA emulation on UML. > Since --kconfig_add usage is no longer needed, remove it from > documentation. >=20 > Signed-off-by: Micha=C5=82 Winiarski > --- > Documentation/gpu/drm-internals.rst | 7 +------ > drivers/video/Kconfig | 4 ++++ > 2 files changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-= internals.rst > index 5fd20a306718..c264a9587d21 100644 > --- a/Documentation/gpu/drm-internals.rst > +++ b/Documentation/gpu/drm-internals.rst > @@ -228,16 +228,11 @@ follows: > =20 > .. code-block:: bash > =20 > - $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/te= sts \ > - --kconfig_add CONFIG_VIRTIO_UML=3Dy \ > - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy > + $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/te= sts > =20 > .. note:: > The configuration included in ``.kunitconfig`` should be as generic as > possible. > - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not > - included in it because they are only required for User Mode Linux. > - I'm all for removing that part of the documentation, but because 6fc3a8636a7b, in 6.0 should address this entirely? Why would we need that other symbol? Maxime --lymi6tif3g4nxejp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYxC7jQAKCRDj7w1vZxhR xQglAP9zmZdegnfQtBGMTWrj4fjVJG3GP2M4l3bTsoldBLBhWwEAvG3BsOVQM1Lq eqk061Y9Ou0biCjvdHK/I9lNIvRPiAM= =uNx+ -----END PGP SIGNATURE----- --lymi6tif3g4nxejp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57A1EC54EE9 for ; Thu, 1 Sep 2022 14:03:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D57610E719; Thu, 1 Sep 2022 14:03:08 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C7EA10E711 for ; Thu, 1 Sep 2022 14:03:02 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C1DFF5C0134; Thu, 1 Sep 2022 10:02:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 01 Sep 2022 10:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1662040979; x=1662127379; bh=Ffc/RZEQI4 hjFuUkxRf9nBYDShUEErzbXtlvMQHYkoU=; b=JtK+h8hcUlm1NBTcBPP1ao8LIV gFvg9ADICearOe/rAgHMR3oV+RyOIVH7vj295WLfGPdjSFpObwGBvfQ4HlAsgfaU flgYVjBvyC3QKanLZokwOTRdNjZLuFQtrNP4chO9SogHjPV9DW7Ug44sC9/9gy60 j2rhWqJ6ro+sdjAajm5G2ksU2BdmnMJuHHsLBhacGm+vseyulSyzsVDTQRaYpmcQ j7yKtHf8hyjY2TJWs0eCS1N1rFKR2V0XMKniXPLj94B/wFQjIObVvhwwID12D0i7 7pZ+TffkyQC1e2yw9BXpoMIFx2OfY33xzpOtl8l435+NhSp9jcmi2wBWfRzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1662040979; x=1662127379; bh=Ffc/RZEQI4hjFuUkxRf9nBYDShUE ErzbXtlvMQHYkoU=; b=v/7DXqkmseCudlaTbZ4YE06w4cJJdyzbaqa2mxX1XcKy Qn8uqghouxGkwFG9pEuN6vORLUx7HKE4jBXrEM37vNJewbZ8OwEVoIZ/DT7uDc94 s7O4oW4dksqVmhhavz6UN1SRMcErQpdlG38IjfWl19TCRhGTXvBDXYlKVVHSLzrr zDi8Z3Xl6n7kDCapB8k+mM2vTtDD47fphkPykSTh6cOTH8JSyksXZl++nPFrP6P4 JlQiLNcUrj6yA/8uM5F1FavkUEPBwL60LLGlvERXn47A6DRIJLSFurUZMFtDuGE/ 1xr6Xzf7ofsLCYkwa28OmBM0LH8PUEF6yerw/T6fJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekkedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfev teefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Sep 2022 10:02:57 -0400 (EDT) Date: Thu, 1 Sep 2022 16:02:53 +0200 From: Maxime Ripard To: =?utf-8?Q?Micha=C5=82?= Winiarski Subject: Re: [PATCH] drm: Simplify testing on UML with kunit.py Message-ID: <20220901140253.6ebvykv35kyc3v3w@houat> References: <20220901133621.353270-1-michal.winiarski@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lymi6tif3g4nxejp" Content-Disposition: inline In-Reply-To: <20220901133621.353270-1-michal.winiarski@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Gow , linux-doc@vger.kernel.org, David Airlie , Thomas Zimmermann , Helge Deller , Jonathan Corbet , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --lymi6tif3g4nxejp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Sep 01, 2022 at 03:36:21PM +0200, Micha=C5=82 Winiarski wrote: > DRM depends on IOMEM and DMA, introduce an additional Kconfig to pull in > IOMEM and DMA emulation on UML. > Since --kconfig_add usage is no longer needed, remove it from > documentation. >=20 > Signed-off-by: Micha=C5=82 Winiarski > --- > Documentation/gpu/drm-internals.rst | 7 +------ > drivers/video/Kconfig | 4 ++++ > 2 files changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-= internals.rst > index 5fd20a306718..c264a9587d21 100644 > --- a/Documentation/gpu/drm-internals.rst > +++ b/Documentation/gpu/drm-internals.rst > @@ -228,16 +228,11 @@ follows: > =20 > .. code-block:: bash > =20 > - $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/te= sts \ > - --kconfig_add CONFIG_VIRTIO_UML=3Dy \ > - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy > + $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/te= sts > =20 > .. note:: > The configuration included in ``.kunitconfig`` should be as generic as > possible. > - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not > - included in it because they are only required for User Mode Linux. > - I'm all for removing that part of the documentation, but because 6fc3a8636a7b, in 6.0 should address this entirely? Why would we need that other symbol? Maxime --lymi6tif3g4nxejp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYxC7jQAKCRDj7w1vZxhR xQglAP9zmZdegnfQtBGMTWrj4fjVJG3GP2M4l3bTsoldBLBhWwEAvG3BsOVQM1Lq eqk061Y9Ou0biCjvdHK/I9lNIvRPiAM= =uNx+ -----END PGP SIGNATURE----- --lymi6tif3g4nxejp--