From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4516ECAAD2 for ; Thu, 1 Sep 2022 21:18:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5018284A04; Thu, 1 Sep 2022 23:18:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ZoJ4GQqp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 68DE4844D6; Thu, 1 Sep 2022 23:18:40 +0200 (CEST) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B3F4849F4 for ; Thu, 1 Sep 2022 23:18:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82b.google.com with SMTP id l5so138678qtv.4 for ; Thu, 01 Sep 2022 14:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=kLpjBbmEdvGluucpsgDv69uUmo9X547LD9fhHRAHqYo=; b=ZoJ4GQqp/hHZJI8dXsEfaqpoBBe/x4RRbvfpJdb/vs7BfQTFjm/Nd/2TEChnXibFvP CLZe4UtodMDaP1jhhsE4oysqbROYSJrTKsXP06dt+hmP+2951M520RAWKmi+BBgj27dl qI1Do/TiFbaT6DodHTMmyC6MBITS3FRZsd74M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=kLpjBbmEdvGluucpsgDv69uUmo9X547LD9fhHRAHqYo=; b=GeQ76Fxs6b5DWSYNIXMIv/PEiXSocs9+3EgYTke4DczI0IrtxydnSzKWs++x2t3GuA /SZGiRWLdS2JpqZNCN9L4nind8UHpY+1HJy0KKKiAx67OpIAPUZPvnee7G9FLtn4tDyJ 3cB9gvpa58Va4YR9ww8Z8oY78Fd8ktSVdk6ZysDL6x8+VI+0SPdAi3SXNvCD0ITAFCy/ /mw6yp4YbyYavwlUeO5xT4O/Y5K/ywTo/ZF6AikrSVqZa6ksDZB3Q4EERZWndv9l7bJs lN2TodoGwdBIkSPTwsxB4+kwqDfWukCTzHXim4mstigTO8M1p4PGCDHwSaaJs0bgJJo/ W5QQ== X-Gm-Message-State: ACgBeo3Y+hfLxXbm/egpSccEvvPrRwtoH/DF1KS/3rdDcqdTjq4SXLf9 Utl8Z+aAIqzdZC/h2Vg/f8D9bA== X-Google-Smtp-Source: AA6agR4y3E3SAufxPGS4VXWNTjmf/xoBmBUyMTcq6KxOFa1bu9zK9zlZHaikxnaOE5SP5275H3Dr3Q== X-Received: by 2002:a05:622a:5cb:b0:344:551a:c804 with SMTP id d11-20020a05622a05cb00b00344551ac804mr25425857qtb.645.1662067116206; Thu, 01 Sep 2022 14:18:36 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id fv23-20020a05622a4a1700b0034454067d24sm11168038qtb.64.2022.09.01.14.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 14:18:35 -0700 (PDT) Date: Thu, 1 Sep 2022 17:18:33 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Fabio Estevam , Kirill Kapranov , Peng Fan , Peter Robinson , Simon Glass , Stefano Babic , Uri Mashiach , Valentin Raevsky , Ying-Chun Liu Subject: Re: [PATCH] board_init: Convert CONFIG_MALLOC_F_ADDR to Kconfig Message-ID: <20220901211833.GA3400311@bill-the-cat> References: <20220709010804.141636-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <20220709010804.141636-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 09, 2022 at 03:08:04AM +0200, Marek Vasut wrote: > Convert CONFIG_MALLOC_F_ADDR to Kconfig. >=20 > The CL IoT gate board used MALLOC_F_ADDR 0x912000 on i.MX8M Mini unlike > all the other platforms which use 0x930000 . This has been aligned with > the other i.MX8M Mini platforms. >=20 > Signed-off-by: Marek Vasut [snip] > diff --git a/common/init/board_init.c b/common/init/board_init.c > index 6a550261778..35506f2ed35 100644 > --- a/common/init/board_init.c > +++ b/common/init/board_init.c > @@ -78,10 +78,8 @@ __weak void board_init_f_init_stack_protection(void) > ulong board_init_f_alloc_reserve(ulong top) > { > /* Reserve early malloc arena */ > -#ifndef CONFIG_MALLOC_F_ADDR > -#if CONFIG_VAL(SYS_MALLOC_F_LEN) > +#if CONFIG_VAL(MALLOC_F_ADDR) && CONFIG_VAL(SYS_MALLOC_F_LEN) > top -=3D CONFIG_VAL(SYS_MALLOC_F_LEN); > -#endif > #endif > /* LAST : reserve GD (rounded up to a multiple of 16 bytes) */ > top =3D rounddown(top-sizeof(struct global_data), 16); This isn't equivalent. It was "if we don't have MALLOC_F_ADDR but do have SYS_MALLOC_F_LEN ..." and now is "if we have MALLOC_F_ADDR and SYS_MALLOC_F_LEN ...". I changed this, and then nokia_rx51 passed in CI again (it was failing to boot at all). But still riscv and qemux86-64 and evb-ast2600 still fail to boot: https://source.denx.de/u-boot/u-boot/-/pipelines/13296 Please re-check the migration, thanks. --=20 Tom --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMRIaYACgkQFHw5/5Y0 tyyTjgv/Q46qY0xkeV40VIZh1C3BPVNvUev1x4+7ZC0TnCP8x6YgNplmQJ0pbbij jWu5kBe9zfFTkBoMQOSUasEc+0qLoAJaWbZLasZNMct8E2r4pISldkn9KjTZ4pEw v6LyYBdzRg9HlAZvFhi+8zn8qlQD4PVz5JzC3NknZpoUm/cU8wdEQz7EnTB0MEut lFx/8jrZzXgAYbQMoCpLabXTmt/uDZ0pyi+uF3bpagrDUBjdH82xKdrMWTvlcQv5 LEswQUkjGMfyNU733I1bJ9QSnQjf6xD2dd9g4grEk5CDen/pr+1OeRuDAHnEaQVO nU2hQl6oYfx1aI5Rt9dU9NSVJH6IqRM+yJxhc0/3V8HwCgDDNMllPlysDOrqBR4n s/OmQvXgKDqo3usHA7ppddkGxtL7O4BHM0HcWbWjtLinlpKjFmlpl+HvzehPiKrs 3g15zf4M1RfU7esm5LLtQRqGPvfaRzOIgzbc6vS1X5pwrF56CBl/6xCUxixGrfPp vDpzS90T =0+vA -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--