From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45035C54EE9 for ; Fri, 2 Sep 2022 12:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236424AbiIBM0Y (ORCPT ); Fri, 2 Sep 2022 08:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236389AbiIBMZm (ORCPT ); Fri, 2 Sep 2022 08:25:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B6C7DD4D8; Fri, 2 Sep 2022 05:23:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 13D4CB82A93; Fri, 2 Sep 2022 12:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74E2FC433C1; Fri, 2 Sep 2022 12:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662121342; bh=ZInOCaMgOjPOKeWmmts0Tfou07gi463oQhOSGGKGQxI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DOCitJcXsve2w9OT27KQ6W/yxjDM93ARDrxCNSH+gM4fMUdYXU8aQjzsnCrsTsNjE PdGk1xfFZxhzATNF+QlQc9TYo8YgsYcMQ26zy34mR7MVLT57NOOaRi273XFhMiXmxt FgFUrO0leTp91VxKW4zVQJLIQqmCsl3rPVeLsUl8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kuniyuki Iwashima , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 19/42] net: Fix a data-race around sysctl_somaxconn. Date: Fri, 2 Sep 2022 14:18:43 +0200 Message-Id: <20220902121359.465606034@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220902121358.773776406@linuxfoundation.org> References: <20220902121358.773776406@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuniyuki Iwashima [ Upstream commit 3c9ba81d72047f2e81bb535d42856517b613aba7 ] While reading sysctl_somaxconn, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Kuniyuki Iwashima Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index c74cfe1ee1699..7bcd7053e61f2 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1509,7 +1509,7 @@ SYSCALL_DEFINE2(listen, int, fd, int, backlog) sock = sockfd_lookup_light(fd, &err, &fput_needed); if (sock) { - somaxconn = sock_net(sock->sk)->core.sysctl_somaxconn; + somaxconn = READ_ONCE(sock_net(sock->sk)->core.sysctl_somaxconn); if ((unsigned int)backlog > somaxconn) backlog = somaxconn; -- 2.35.1