From: David Sterba <dsterba@suse.cz>
To: cgel.zte@gmail.com
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
zhang songyi <zhang.songyi@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] btrfs: Remove the unneeded result variable
Date: Fri, 2 Sep 2022 14:23:47 +0200 [thread overview]
Message-ID: <20220902122346.GT13489@twin.jikos.cz> (raw)
In-Reply-To: <20220902074810.319914-1-zhang.songyi@zte.com.cn>
On Fri, Sep 02, 2022 at 07:48:10AM +0000, cgel.zte@gmail.com wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return the sysfs_emit() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
There's another patch doing a similar cleanup in btrfs_load_inode_props,
can you please resend so it's all done in one patch? I did not want to
apply a single fix but now that there are a few more instances of the
pattern it makes slightly more sense to apply it. Thanks.
https://lore.kernel.org/linux-btrfs/20220830083914.276926-1-ye.xingchen@zte.com.cn/
next prev parent reply other threads:[~2022-09-02 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 7:48 [PATCH linux-next] btrfs: Remove the unneeded result variable cgel.zte
2022-09-02 12:23 ` David Sterba [this message]
2022-09-05 3:26 ` Anand Jain
-- strict thread matches above, loose matches on Subject: below --
2022-08-30 8:39 cgel.zte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902122346.GT13489@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=cgel.zte@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zealci@zte.com.cn \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.