All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Bin Meng" <bin.meng@windriver.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alexander Bulekov" <alxndr@bu.edu>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Ani Sinha" <ani@anisinha.ca>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Fam Zheng" <fam@euphon.net>, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Bandan Das" <bsd@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"Hannes Reinecke" <hare@suse.com>,
	"Qiuhao Li" <Qiuhao.Li@outlook.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>
Subject: [PATCH 2/8] qtest: Set "-net none" in qtest_init()
Date: Fri,  2 Sep 2022 18:51:20 +0200	[thread overview]
Message-ID: <20220902165126.1482-3-quintela@redhat.com> (raw)
In-Reply-To: <20220902165126.1482-1-quintela@redhat.com>

This way, we don't have networking by default.  If test needs it,
configure it.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/qtest/bios-tables-test.c | 2 +-
 tests/qtest/libqtest.c         | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 9c68f3658a..a0853744ae 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -725,7 +725,7 @@ static char *test_acpi_create_args(test_data *data, const char *params,
         }
     } else {
         args = g_strdup_printf("-machine %s %s -accel tcg "
-            "-net none %s "
+            "%s "
             "-drive id=hd0,if=none,file=%s,format=raw "
             "-device %s,drive=hd0 ",
              data->machine, data->tcg_only ? "" : "-accel kvm",
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7c9fc07de4..ee84dbfc36 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -290,6 +290,7 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)
                               "-chardev socket,path=%s,id=char0 "
                               "-mon chardev=char0,mode=control "
                               "-display none "
+                              "-net none "
                               "%s"
                               " -accel qtest",
                               qemu_binary, tracearg, socket_path,
-- 
2.37.2



  parent reply	other threads:[~2022-09-02 16:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 16:51 [PATCH 0/8] tests: Make expliction defaults for tests Juan Quintela
2022-09-02 16:51 ` [PATCH 1/8] qtest: "-display none" is set in qtest_init() Juan Quintela
2022-09-19 17:59   ` Thomas Huth
2022-09-20  9:20   ` Thomas Huth
2022-09-02 16:51 ` Juan Quintela [this message]
2022-09-04 13:41   ` [PATCH 2/8] qtest: Set "-net none" " Philippe Mathieu-Daudé via
2022-09-02 16:51 ` [PATCH 3/8] tests/acpi: The new default is -vga none Juan Quintela
2022-09-02 16:51 ` [PATCH 4/8] tests/qtest: Add -vga none by default Juan Quintela
2022-09-02 16:51 ` [PATCH 5/8] tests/acpi: Regenerate all needed tables Juan Quintela
2022-09-02 16:51 ` [PATCH 6/8] tests: Fix error strings Juan Quintela
2022-09-04 13:41   ` Philippe Mathieu-Daudé via
2022-09-02 16:51 ` [PATCH 7/8] meson-build: Enable CONFIG_REPLICATION only when replication is set Juan Quintela
2022-09-19 18:05   ` Thomas Huth
2022-09-02 16:51 ` [PATCH 8/8] meson-build: test-crypto-secret depends on CONFIG_SECRET_KEYRING Juan Quintela
2022-09-19 18:06   ` Thomas Huth
2022-09-20  8:06   ` Daniel P. Berrangé
2022-09-02 17:16 ` [PATCH 0/8] tests: Make expliction defaults for tests Alexander Bulekov
2022-09-19 18:09   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220902165126.1482-3-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=Qiuhao.Li@outlook.com \
    --cc=alxndr@bu.edu \
    --cc=ani@anisinha.ca \
    --cc=bin.meng@windriver.com \
    --cc=bsd@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=hare@suse.com \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.