From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F01C6FA89 for ; Mon, 5 Sep 2022 19:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232037AbiIETZj (ORCPT ); Mon, 5 Sep 2022 15:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbiIETZS (ORCPT ); Mon, 5 Sep 2022 15:25:18 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F98C1A814; Mon, 5 Sep 2022 12:25:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DF790CE13B1; Mon, 5 Sep 2022 19:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE930C433D6; Mon, 5 Sep 2022 19:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662405914; bh=fO/Wpv5YcoIkYZ8e/EM1T7nTT0WkvQ0tJJN+l68UVfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OqF26oiIozeAHlSt/R2brCxL80bI3tHLkT5oMQIRgpa2FGqWNIXUGNh920b2bVz6R CoqozJtZU9OJe9tWMLdlXY5nrTifi6CwSeJozAVkZ9u3Lzw2Pivs9oqtK84aIv6ILC c1b1QdrGLyCZqgzT2YiQO4u9k7c1UtRFmS2YA/pcpjiCYFQptqkN1uEZ8YzSz7geZB ESBsYwMJeJhk17cQ5AX8hBpmX5J4PPuUPq5CaoHwadk8u5IdyXdJ2o0omB3jSPpdHF 8RzQ0HSz+XvyPY4FIWuo17xaPMn/BSGCX1orNZN/b85WCegEdq8W3nAD7Q28wYIAAr cWTWTUgZrAk8g== Received: by pali.im (Postfix) id 217687D7; Mon, 5 Sep 2022 21:25:11 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/7] PCI: mvebu: add support for orion soc Date: Mon, 5 Sep 2022 21:23:03 +0200 Message-Id: <20220905192310.22786-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220718202843.6766-1-maukka@ext.kapsi.fi> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! This patch series add support for Orion PCIe controller into pci-mvebu.c driver. V3 version has completely rewritten pci-mvebu.c code to parse all physical addresses from device tree files according to mvebu-pci.txt documentation, allow access to all extended PCIe config space registers and use modern kernel API pci_remap_cfgspace() and mvebu_mbus_add_window_by_id() fir mapping PCIe config space. Most of Marvell device tree code in pci-mvebu.c is giant magic, but it was there because this change and it is de-facto API between dts files and kernel used for a long time. Note that it is misused according to PCI device tree bindings, but we have to follow this Marvell bindings to do not introduce backward incompatibility issues for other non-Orion platforms. Mauri tested these changes on DNS323 board with both DT and non-DT builds. PCIe AER is working too (one of the feature which proved that access to extended PCIe config registers is working fine). After this patch is accepted we are planning to look at existing Orion arch specific code and covert it to use this new DT based pci-mvebu.c code. Later this would allow to kill arch specific Orion PCIe code, which is in arch/arm/plat-orion/pcie.c and parts also in file arch/arm/mach-orion5x/pci.c (shared with old-PCI bus code). This patch series depends on another patches: https://lore.kernel.org/linux-pci/20220524122817.7199-1-pali@kernel.org/ https://lore.kernel.org/linux-pci/20220817230036.817-3-pali@kernel.org/ Mauri Sandberg (2): bus: mvebu-mbus: add configuration space aperture dt-bindings: PCI: mvebu: Add orion5x compatible Pali Rohár (5): ARM: orion: Move PCIe mbus window mapping from orion5x_setup_wins() to pcie_setup() PCI: mvebu: Remove unused busn member PCI: mvebu: Cleanup error handling in mvebu_pcie_probe() PCI: mvebu: Add support for Orion PCIe controller ARM: dts: orion5x: Add PCIe node .../devicetree/bindings/pci/mvebu-pci.txt | 4 +- arch/arm/boot/dts/orion5x.dtsi | 51 +++++ arch/arm/mach-orion5x/common.c | 13 -- arch/arm/mach-orion5x/pci.c | 14 ++ drivers/bus/mvebu-mbus.c | 26 ++- drivers/pci/controller/Kconfig | 4 +- drivers/pci/controller/pci-mvebu.c | 202 ++++++++++++++---- include/linux/mbus.h | 1 + 8 files changed, 256 insertions(+), 59 deletions(-) -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45E08ECAAD5 for ; Mon, 5 Sep 2022 19:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1cBj41v8oxnMJDWgUaITsTNn/ogtdYQT+z/XEADRC8=; b=HPAjdnw9+IFBaF kHykUntaNgWq12k02YiAVi8Jm0ibaHF1dHH4svsRIFvQc8KxMes/y+s/A2rnum9S0M6cyCtx7NypU HQ5RsIGZo2ZTvXuFaZ3c+JrA6C+o9aQ0KjinoJ0E4Ra3tRc5ukE/8kM151bA6/vdcegUUBigSjQEy kqZEnnsXz9KvhKyivK9uyUt7VdnBtp8KkPuUJiW/UtXp499COsR7MYFhD4wMel9r/zWJ2CRGhmGTY deAfO/4pnOFG12ucJ5zij/ghjwdKLaMqCDgg19qxr/1w8Vk7EBEtOAKBDvbHETFVCm9MeyMxtD8RR kNvVo5CMw5qQREgb4yGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVI5k-009eZQ-Qf; Mon, 05 Sep 2022 19:49:09 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVHik-009Fcd-S4 for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 19:25:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B3C75CE112D; Mon, 5 Sep 2022 19:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE930C433D6; Mon, 5 Sep 2022 19:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662405914; bh=fO/Wpv5YcoIkYZ8e/EM1T7nTT0WkvQ0tJJN+l68UVfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OqF26oiIozeAHlSt/R2brCxL80bI3tHLkT5oMQIRgpa2FGqWNIXUGNh920b2bVz6R CoqozJtZU9OJe9tWMLdlXY5nrTifi6CwSeJozAVkZ9u3Lzw2Pivs9oqtK84aIv6ILC c1b1QdrGLyCZqgzT2YiQO4u9k7c1UtRFmS2YA/pcpjiCYFQptqkN1uEZ8YzSz7geZB ESBsYwMJeJhk17cQ5AX8hBpmX5J4PPuUPq5CaoHwadk8u5IdyXdJ2o0omB3jSPpdHF 8RzQ0HSz+XvyPY4FIWuo17xaPMn/BSGCX1orNZN/b85WCegEdq8W3nAD7Q28wYIAAr cWTWTUgZrAk8g== Received: by pali.im (Postfix) id 217687D7; Mon, 5 Sep 2022 21:25:11 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/7] PCI: mvebu: add support for orion soc Date: Mon, 5 Sep 2022 21:23:03 +0200 Message-Id: <20220905192310.22786-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220718202843.6766-1-maukka@ext.kapsi.fi> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_122523_302415_C48C0087 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8hIFRoaXMgcGF0Y2ggc2VyaWVzIGFkZCBzdXBwb3J0IGZvciBPcmlvbiBQQ0llIGNvbnRy b2xsZXIgaW50bwpwY2ktbXZlYnUuYyBkcml2ZXIuIFYzIHZlcnNpb24gaGFzIGNvbXBsZXRlbHkg cmV3cml0dGVuIHBjaS1tdmVidS5jIGNvZGUKdG8gcGFyc2UgYWxsIHBoeXNpY2FsIGFkZHJlc3Nl cyBmcm9tIGRldmljZSB0cmVlIGZpbGVzIGFjY29yZGluZyB0bwptdmVidS1wY2kudHh0IGRvY3Vt ZW50YXRpb24sIGFsbG93IGFjY2VzcyB0byBhbGwgZXh0ZW5kZWQgUENJZSBjb25maWcKc3BhY2Ug cmVnaXN0ZXJzIGFuZCB1c2UgbW9kZXJuIGtlcm5lbCBBUEkgcGNpX3JlbWFwX2NmZ3NwYWNlKCkg YW5kCm12ZWJ1X21idXNfYWRkX3dpbmRvd19ieV9pZCgpIGZpciBtYXBwaW5nIFBDSWUgY29uZmln IHNwYWNlLgoKTW9zdCBvZiBNYXJ2ZWxsIGRldmljZSB0cmVlIGNvZGUgaW4gcGNpLW12ZWJ1LmMg aXMgZ2lhbnQgbWFnaWMsIGJ1dCBpdCB3YXMKdGhlcmUgYmVjYXVzZSB0aGlzIGNoYW5nZSBhbmQg aXQgaXMgZGUtZmFjdG8gQVBJIGJldHdlZW4gZHRzIGZpbGVzIGFuZAprZXJuZWwgdXNlZCBmb3Ig YSBsb25nIHRpbWUuIE5vdGUgdGhhdCBpdCBpcyBtaXN1c2VkIGFjY29yZGluZyB0byBQQ0kKZGV2 aWNlIHRyZWUgYmluZGluZ3MsIGJ1dCB3ZSBoYXZlIHRvIGZvbGxvdyB0aGlzIE1hcnZlbGwgYmlu ZGluZ3MgdG8gZG8Kbm90IGludHJvZHVjZSBiYWNrd2FyZCBpbmNvbXBhdGliaWxpdHkgaXNzdWVz IGZvciBvdGhlciBub24tT3Jpb24KcGxhdGZvcm1zLgoKTWF1cmkgdGVzdGVkIHRoZXNlIGNoYW5n ZXMgb24gRE5TMzIzIGJvYXJkIHdpdGggYm90aCBEVCBhbmQgbm9uLURUIGJ1aWxkcy4KUENJZSBB RVIgaXMgd29ya2luZyB0b28gKG9uZSBvZiB0aGUgZmVhdHVyZSB3aGljaCBwcm92ZWQgdGhhdCBh Y2Nlc3MgdG8KZXh0ZW5kZWQgUENJZSBjb25maWcgcmVnaXN0ZXJzIGlzIHdvcmtpbmcgZmluZSku CgpBZnRlciB0aGlzIHBhdGNoIGlzIGFjY2VwdGVkIHdlIGFyZSBwbGFubmluZyB0byBsb29rIGF0 IGV4aXN0aW5nIE9yaW9uCmFyY2ggc3BlY2lmaWMgY29kZSBhbmQgY292ZXJ0IGl0IHRvIHVzZSB0 aGlzIG5ldyBEVCBiYXNlZCBwY2ktbXZlYnUuYwpjb2RlLiBMYXRlciB0aGlzIHdvdWxkIGFsbG93 IHRvIGtpbGwgYXJjaCBzcGVjaWZpYyBPcmlvbiBQQ0llIGNvZGUsCndoaWNoIGlzIGluIGFyY2gv YXJtL3BsYXQtb3Jpb24vcGNpZS5jIGFuZCBwYXJ0cyBhbHNvIGluIGZpbGUKYXJjaC9hcm0vbWFj aC1vcmlvbjV4L3BjaS5jIChzaGFyZWQgd2l0aCBvbGQtUENJIGJ1cyBjb2RlKS4KClRoaXMgcGF0 Y2ggc2VyaWVzIGRlcGVuZHMgb24gYW5vdGhlciBwYXRjaGVzOgpodHRwczovL2xvcmUua2VybmVs Lm9yZy9saW51eC1wY2kvMjAyMjA1MjQxMjI4MTcuNzE5OS0xLXBhbGlAa2VybmVsLm9yZy8KaHR0 cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtcGNpLzIwMjIwODE3MjMwMDM2LjgxNy0zLXBhbGlA a2VybmVsLm9yZy8KCk1hdXJpIFNhbmRiZXJnICgyKToKICBidXM6IG12ZWJ1LW1idXM6IGFkZCBj b25maWd1cmF0aW9uIHNwYWNlIGFwZXJ0dXJlCiAgZHQtYmluZGluZ3M6IFBDSTogbXZlYnU6IEFk ZCBvcmlvbjV4IGNvbXBhdGlibGUKClBhbGkgUm9ow6FyICg1KToKICBBUk06IG9yaW9uOiBNb3Zl IFBDSWUgbWJ1cyB3aW5kb3cgbWFwcGluZyBmcm9tIG9yaW9uNXhfc2V0dXBfd2lucygpIHRvCiAg ICBwY2llX3NldHVwKCkKICBQQ0k6IG12ZWJ1OiBSZW1vdmUgdW51c2VkIGJ1c24gbWVtYmVyCiAg UENJOiBtdmVidTogQ2xlYW51cCBlcnJvciBoYW5kbGluZyBpbiBtdmVidV9wY2llX3Byb2JlKCkK ICBQQ0k6IG12ZWJ1OiBBZGQgc3VwcG9ydCBmb3IgT3Jpb24gUENJZSBjb250cm9sbGVyCiAgQVJN OiBkdHM6IG9yaW9uNXg6IEFkZCBQQ0llIG5vZGUKCiAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9w Y2kvbXZlYnUtcGNpLnR4dCAgICAgfCAgIDQgKy0KIGFyY2gvYXJtL2Jvb3QvZHRzL29yaW9uNXgu ZHRzaSAgICAgICAgICAgICAgICB8ICA1MSArKysrKwogYXJjaC9hcm0vbWFjaC1vcmlvbjV4L2Nv bW1vbi5jICAgICAgICAgICAgICAgIHwgIDEzIC0tCiBhcmNoL2FybS9tYWNoLW9yaW9uNXgvcGNp LmMgICAgICAgICAgICAgICAgICAgfCAgMTQgKysKIGRyaXZlcnMvYnVzL212ZWJ1LW1idXMuYyAg ICAgICAgICAgICAgICAgICAgICB8ICAyNiArKy0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvS2Nv bmZpZyAgICAgICAgICAgICAgICB8ICAgNCArLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2kt bXZlYnUuYyAgICAgICAgICAgIHwgMjAyICsrKysrKysrKysrKysrLS0tLQogaW5jbHVkZS9saW51 eC9tYnVzLmggICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxICsKIDggZmlsZXMgY2hhbmdl ZCwgMjU2IGluc2VydGlvbnMoKyksIDU5IGRlbGV0aW9ucygtKQoKLS0gCjIuMjAuMQoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK