All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] net: dp83822: backport fix interrupt floods
@ 2022-09-07 10:45 Enguerrand de Ribaucourt
  2022-09-07 10:45 ` [PATCH v3 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Enguerrand de Ribaucourt @ 2022-09-07 10:45 UTC (permalink / raw)
  To: stable; +Cc: gregkh, andrew

This series backports the following fixes from 5.10 to 5.4.
This backport should also apply to 4.19.

A git conflict was solved involving DP83822_ANEG_COMPLETE_INT_EN which was moved
to a conditional in 5.10.

Original commit IDs:
c96614eeab663646f57f67aa591e015abd8bd0ba net: dp83822: disable false carrier interrupt
0e597e2affb90d6ea48df6890d882924acf71e19 net: dp83822: disable rx error interrupt



^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] net: dp83822: disable false carrier interrupt
@ 2022-06-17 17:55 Andrew Lunn
  2022-06-23 13:46 ` [PATCH v3 0/2] net: dp83822: fix interrupt floods Enguerrand de Ribaucourt
  0 siblings, 1 reply; 14+ messages in thread
From: Andrew Lunn @ 2022-06-17 17:55 UTC (permalink / raw)
  To: Enguerrand de Ribaucourt; +Cc: davem, netdev, linux-kernel, linux, hkallweit1

On Fri, Jun 17, 2022 at 03:46:11PM +0200, Enguerrand de Ribaucourt wrote:
> When unplugging an Ethernet cable, false carrier events were produced by
> the PHY at a very high rate. Once the false carrier counter full, an
> interrupt was triggered every few clock cycles until the cable was
> replugged. This resulted in approximately 10k/s interrupts.
> 
> Since the false carrier counter (FCSCR) is never used, we can safely
> disable this interrupt.
> 
> In addition to improving performance, this also solved MDIO read
> timeouts I was randomly encountering with an i.MX8 fec MAC because of
> the interrupt flood. The interrupt count and MDIO timeout fix were
> tested on a v5.4.110 kernel.
> 
> Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>
> ---
>  drivers/net/phy/dp83822.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
> index e6ad3a494d32..95ef507053a6 100644
> --- a/drivers/net/phy/dp83822.c
> +++ b/drivers/net/phy/dp83822.c
> @@ -230,7 +230,6 @@ static int dp83822_config_intr(struct phy_device *phydev)
>  			return misr_status;
>  
>  		misr_status |= (DP83822_RX_ERR_HF_INT_EN |
> -				DP83822_FALSE_CARRIER_HF_INT_EN |

Does the same problem exist for RX_ERR_HF_INT ? That appears to be
that the RX error counter has reached half full. I don't see anything
using register 0x15.

      Andrew

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-09-16  9:34 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 10:45 [PATCH v3 0/2] net: dp83822: backport fix interrupt floods Enguerrand de Ribaucourt
2022-09-07 10:45 ` [PATCH v3 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-09-07 10:45 ` [PATCH v3 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-09-08 17:09   ` Greg KH
2022-09-12 10:07     ` Enguerrand de Ribaucourt
2022-09-12 14:39       ` Greg KH
2022-09-13  8:17       ` [PATCH v3] " Enguerrand de Ribaucourt
2022-09-13 11:30         ` Greg KH
2022-09-14  7:07           ` Enguerrand de Ribaucourt
2022-09-16  9:35             ` Greg KH
2022-09-08 17:07 ` [PATCH v3 0/2] net: dp83822: backport fix interrupt floods Greg KH
2022-09-12 10:02   ` Enguerrand de Ribaucourt
  -- strict thread matches above, loose matches on Subject: below --
2022-06-17 17:55 [PATCH] net: dp83822: disable false carrier interrupt Andrew Lunn
2022-06-23 13:46 ` [PATCH v3 0/2] net: dp83822: fix interrupt floods Enguerrand de Ribaucourt
2022-06-23 13:46   ` [PATCH v3 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-06-23 18:27     ` Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.