From: paul.elder@ideasonboard.com
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Rui Miguel Silva <rmfrfs@gmail.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jacopo Mondi <jacopo@jmondi.org>,
kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH 4/6] staging: media: imx: Drop IMX_MEDIA_GRP_ID_CSI
Date: Thu, 8 Sep 2022 13:10:50 +0900 [thread overview]
Message-ID: <20220908041050.GH1140330@pyrite.rasen.tech> (raw)
In-Reply-To: <20220907200424.32136-5-laurent.pinchart@ideasonboard.com>
On Wed, Sep 07, 2022 at 11:04:22PM +0300, Laurent Pinchart wrote:
> The IMX_MEDIA_GRP_ID_CSI group ID isn't used anymore. Drop it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> drivers/staging/media/imx/imx-media-dev-common.c | 1 -
> drivers/staging/media/imx/imx-media.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
> index 8f7ced3a9cca..991820a8500f 100644
> --- a/drivers/staging/media/imx/imx-media-dev-common.c
> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
> @@ -39,7 +39,6 @@ static void imx_media_create_csi2_links(struct imx_media_dev *imxmd)
> list_for_each_entry(sd, &imxmd->v4l2_dev.subdevs, list) {
> /* skip if not a CSI or a CSI mux */
> if (!(sd->grp_id & IMX_MEDIA_GRP_ID_IPU_CSI) &&
> - !(sd->grp_id & IMX_MEDIA_GRP_ID_CSI) &&
> !(sd->grp_id & IMX_MEDIA_GRP_ID_CSI_MUX))
> continue;
>
> diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-media.h
> index f263fc3adbb9..5e794f291da6 100644
> --- a/drivers/staging/media/imx/imx-media.h
> +++ b/drivers/staging/media/imx/imx-media.h
> @@ -299,7 +299,6 @@ void imx_media_csc_scaler_device_unregister(struct imx_media_video_dev *vdev);
>
> /* subdev group ids */
> #define IMX_MEDIA_GRP_ID_CSI2 BIT(8)
> -#define IMX_MEDIA_GRP_ID_CSI BIT(9)
> #define IMX_MEDIA_GRP_ID_IPU_CSI_BIT 10
> #define IMX_MEDIA_GRP_ID_IPU_CSI (0x3 << IMX_MEDIA_GRP_ID_IPU_CSI_BIT)
> #define IMX_MEDIA_GRP_ID_IPU_CSI0 BIT(IMX_MEDIA_GRP_ID_IPU_CSI_BIT)
next prev parent reply other threads:[~2022-09-08 4:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 20:04 [PATCH 0/6] media: imx: imx7-media-csi: Destage driver Laurent Pinchart
2022-09-07 20:04 ` [PATCH 1/6] media: imx: Decouple imx8mq-mipi-csi2 from imx7-media-csi Laurent Pinchart
2022-09-08 3:58 ` paul.elder
2022-09-09 18:22 ` Laurent Pinchart
2022-09-13 15:10 ` Martin Kepplinger
2022-09-13 15:26 ` Laurent Pinchart
2022-09-07 20:04 ` [PATCH 2/6] media: imx: Unstage the imx7-media-csi driver Laurent Pinchart
2022-09-08 4:04 ` paul.elder
2022-09-08 15:06 ` Rui Miguel Silva
2022-09-08 15:18 ` Laurent Pinchart
2022-09-08 15:46 ` Rui Miguel Silva
2022-09-07 20:04 ` [PATCH 3/6] staging: media: imx: Drop imx_media_subdev_bound() Laurent Pinchart
2022-09-08 4:08 ` paul.elder
2022-09-07 20:04 ` [PATCH 4/6] staging: media: imx: Drop IMX_MEDIA_GRP_ID_CSI Laurent Pinchart
2022-09-08 4:10 ` paul.elder [this message]
2022-09-07 20:04 ` [PATCH 5/6] staging: media: imx: Drop unused helper functions Laurent Pinchart
2022-09-08 4:12 ` paul.elder
2022-09-07 20:04 ` [PATCH 6/6] staging: media: imx: Make imx_media_of_add_csi() static Laurent Pinchart
2022-09-08 4:16 ` paul.elder
2022-09-13 9:48 ` [PATCH 0/6] media: imx: imx7-media-csi: Destage driver Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908041050.GH1140330@pyrite.rasen.tech \
--to=paul.elder@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmfrfs@gmail.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.