From: eadavis@sina.com
To: syzbot+c4d950787fd5553287b7@syzkaller.appspotmail.com
Cc: almaz.alexandrovich@paragon-software.com,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
nathan@kernel.org, ndesaulniers@google.com,
ntfs3@lists.linux.dev, syzkaller-bugs@googlegroups.com,
trix@redhat.com, Edward Adam Davis <eadavis@sina.com>
Subject: [PATCH v2] fs/netfs3: add a boundary check for EA_FULL
Date: Mon, 12 Sep 2022 14:54:31 +0800 [thread overview]
Message-ID: <20220912065431.3043731-1-eadavis@sina.com> (raw)
In-Reply-To: <0000000000005af92105e80510f2@google.com>
From: Edward Adam Davis <eadavis@sina.com>
the root cause is:
The remaining space after the offset is less than the space needed to
accommodate the next EA_FULL struct.
Link: https://syzkaller.appspot.com/bug?extid=c4d950787fd5553287b7
Reported-by: syzbot+c4d950787fd5553287b7@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@sina.com>
---
fs/ntfs3/xattr.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
index 7de8718c68a9..c90cc453390d 100644
--- a/fs/ntfs3/xattr.c
+++ b/fs/ntfs3/xattr.c
@@ -52,6 +52,7 @@ static inline bool find_ea(const struct EA_FULL *ea_all, u32 bytes,
for (;;) {
const struct EA_FULL *ea = Add2Ptr(ea_all, *off);
u32 next_off = *off + unpacked_ea_size(ea);
+ u32 next_len = 0;
if (next_off > bytes)
return false;
@@ -63,6 +64,13 @@ static inline bool find_ea(const struct EA_FULL *ea_all, u32 bytes,
*off = next_off;
if (next_off >= bytes)
return false;
+
+ next_len = next_off + 8;
+ if (next_len >= bytes ||
+ ((!ea->size) &&
+ (next_len + ea->name_len +
+ le16_to_cpu(ea->elength) >= bytes)))
+ return false;
}
}
--
2.37.2
next prev parent reply other threads:[~2022-09-12 6:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:55 [syzbot] KASAN: slab-out-of-bounds Read in ntfs_get_ea syzbot
2022-09-12 3:41 ` [PATCH] fs/netfs3: add a boundary check for EA_FULL eadavis
2022-09-12 6:16 ` kernel test robot
2022-09-12 6:16 ` kernel test robot
2022-09-19 5:19 ` [PATCH] fs/ntfs3: "add a boundary check for EA_FULL" lose right parenthesis eadavis
2022-09-19 10:42 ` Dan Carpenter
2022-09-19 11:19 ` [PATCH v3] fs/ntfs3: add a boundary check for EA_FULL eadavis
2022-09-19 12:04 ` Dan Carpenter
2022-09-19 13:21 ` [PATCH v4] fs/ntfs3: Fix buffer overflow and integer overflow eadavis
2022-09-19 13:32 ` eadavis
2022-09-12 6:54 ` eadavis [this message]
2022-09-14 15:34 ` [PATCH v2] fs/netfs3: add a boundary check for EA_FULL Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912065431.3043731-1-eadavis@sina.com \
--to=eadavis@sina.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ntfs3@lists.linux.dev \
--cc=syzbot+c4d950787fd5553287b7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=trix@redhat.com \
--subject='Re: [PATCH v2] fs/netfs3: add a boundary check for EA_FULL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.