All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org
Cc: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: [PATCH 1/7] drm/sched: move calling drm_sched_entity_select_rq
Date: Mon, 12 Sep 2022 14:36:34 +0200	[thread overview]
Message-ID: <20220912123640.20058-2-christian.koenig@amd.com> (raw)
In-Reply-To: <20220912123640.20058-1-christian.koenig@amd.com>

We already discussed that the call to drm_sched_entity_select_rq() needs
to move to drm_sched_job_arm() to be able to set a new scheduler list
between _init() and _arm(). This was just not applied for some reason.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
---
 drivers/gpu/drm/scheduler/sched_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 68317d3a7a27..e0ab14e0fb6b 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -592,7 +592,6 @@ int drm_sched_job_init(struct drm_sched_job *job,
 		       struct drm_sched_entity *entity,
 		       void *owner)
 {
-	drm_sched_entity_select_rq(entity);
 	if (!entity->rq)
 		return -ENOENT;
 
@@ -628,7 +627,7 @@ void drm_sched_job_arm(struct drm_sched_job *job)
 	struct drm_sched_entity *entity = job->entity;
 
 	BUG_ON(!entity);
-
+	drm_sched_entity_select_rq(entity);
 	sched = entity->rq->sched;
 
 	job->sched = sched;
-- 
2.25.1


  reply	other threads:[~2022-09-12 12:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 12:36 Christian König
2022-09-12 12:36 ` Christian König [this message]
2022-09-12 12:36 ` [PATCH 2/7] drm/amdgpu: remove SRIOV and MCBP dependencies from the CS Christian König
2022-09-12 12:36 ` [PATCH 3/7] drm/amdgpu: move setting the job resources Christian König
2022-09-12 12:36 ` [PATCH 4/7] drm/amdgpu: revert "partial revert "remove ctx->lock" v2" Christian König
2022-09-12 12:36 ` [PATCH 5/7] drm/amdgpu: use DMA_RESV_USAGE_BOOKKEEP v2 Christian König
2022-09-13 20:52   ` Felix Kuehling
2022-09-14  7:23     ` Christian König
2022-09-12 12:36 ` [PATCH 6/7] drm/amdgpu: cleanup CS init/fini and pass1 Christian König
2022-09-12 12:36 ` [PATCH 7/7] drm/amdgpu: reorder CS code Christian König
2022-09-13  2:04 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220912123640.20058-2-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.