* [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 20:55 ` Nathan Huckleberry
0 siblings, 0 replies; 15+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:55 UTC (permalink / raw)
Cc: Nathan Huckleberry, Dan Carpenter, llvm, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie,
Daniel Vetter, Nathan Chancellor, Nick Desaulniers, Tom Rix,
Matt Roper, Lucas De Marchi, intel-gfx, dri-devel, linux-kernel
All of the functions used for intel_dvo_dev_ops.mode_valid have a return
type of enum drm_mode_status, but the mode_valid field in the struct
definition has a return type of int.
The mismatched return type breaks forward edge kCFI since the underlying
function definitions do not match the function hook definition.
The return type of the mode_valid field should be changed from int to
enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
index d96c3cc46e50..50205f064d93 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
+++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
*
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/
- int (*mode_valid)(struct intel_dvo_device *dvo,
- struct drm_display_mode *mode);
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
+ struct drm_display_mode *mode);
/*
* Callback for preparing mode changes on an output
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 20:55 ` Nathan Huckleberry
0 siblings, 0 replies; 15+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:55 UTC (permalink / raw)
Cc: Nathan Huckleberry, Dan Carpenter, llvm, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie,
Daniel Vetter, Nathan Chancellor, Nick Desaulniers, Tom Rix,
Matt Roper, Lucas De Marchi, intel-gfx, dri-devel, linux-kernel
All of the functions used for intel_dvo_dev_ops.mode_valid have a return
type of enum drm_mode_status, but the mode_valid field in the struct
definition has a return type of int.
The mismatched return type breaks forward edge kCFI since the underlying
function definitions do not match the function hook definition.
The return type of the mode_valid field should be changed from int to
enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
index d96c3cc46e50..50205f064d93 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
+++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
*
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/
- int (*mode_valid)(struct intel_dvo_device *dvo,
- struct drm_display_mode *mode);
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
+ struct drm_display_mode *mode);
/*
* Callback for preparing mode changes on an output
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 20:55 ` Nathan Huckleberry
0 siblings, 0 replies; 15+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:55 UTC (permalink / raw)
Cc: Lucas De Marchi, Tvrtko Ursulin, llvm, Dan Carpenter,
David Airlie, Tom Rix, intel-gfx, Nick Desaulniers, linux-kernel,
Nathan Huckleberry, Nathan Chancellor, dri-devel, Rodrigo Vivi
All of the functions used for intel_dvo_dev_ops.mode_valid have a return
type of enum drm_mode_status, but the mode_valid field in the struct
definition has a return type of int.
The mismatched return type breaks forward edge kCFI since the underlying
function definitions do not match the function hook definition.
The return type of the mode_valid field should be changed from int to
enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
index d96c3cc46e50..50205f064d93 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
+++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
*
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/
- int (*mode_valid)(struct intel_dvo_device *dvo,
- struct drm_display_mode *mode);
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
+ struct drm_display_mode *mode);
/*
* Callback for preparing mode changes on an output
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 20:55 ` Nathan Huckleberry
0 siblings, 0 replies; 15+ messages in thread
From: Nathan Huckleberry @ 2022-09-13 20:55 UTC (permalink / raw)
Cc: Lucas De Marchi, llvm, Dan Carpenter, David Airlie, Tom Rix,
intel-gfx, Nick Desaulniers, linux-kernel, Nathan Huckleberry,
Nathan Chancellor, dri-devel, Daniel Vetter, Rodrigo Vivi
All of the functions used for intel_dvo_dev_ops.mode_valid have a return
type of enum drm_mode_status, but the mode_valid field in the struct
definition has a return type of int.
The mismatched return type breaks forward edge kCFI since the underlying
function definitions do not match the function hook definition.
The return type of the mode_valid field should be changed from int to
enum drm_mode_status.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
index d96c3cc46e50..50205f064d93 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
+++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
*
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/
- int (*mode_valid)(struct intel_dvo_device *dvo,
- struct drm_display_mode *mode);
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
+ struct drm_display_mode *mode);
/*
* Callback for preparing mode changes on an output
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Fix return type of mode_valid function hook
2022-09-13 20:55 ` Nathan Huckleberry
(?)
@ 2022-09-13 23:19 ` Nathan Chancellor
-1 siblings, 0 replies; 15+ messages in thread
From: Nathan Chancellor @ 2022-09-13 23:19 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Dan Carpenter, llvm, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, Nick Desaulniers,
Tom Rix, Matt Roper, Lucas De Marchi, intel-gfx, dri-devel,
linux-kernel
On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote:
> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
> type of enum drm_mode_status, but the mode_valid field in the struct
> definition has a return type of int.
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definitions do not match the function hook definition.
>
> The return type of the mode_valid field should be changed from int to
> enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> index d96c3cc46e50..50205f064d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> - struct drm_display_mode *mode);
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> + struct drm_display_mode *mode);
>
> /*
> * Callback for preparing mode changes on an output
> --
> 2.37.2.789.g6183377224-goog
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 23:19 ` Nathan Chancellor
0 siblings, 0 replies; 15+ messages in thread
From: Nathan Chancellor @ 2022-09-13 23:19 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Lucas De Marchi, Tvrtko Ursulin, llvm, Dan Carpenter,
David Airlie, Tom Rix, intel-gfx, Nick Desaulniers, linux-kernel,
dri-devel, Rodrigo Vivi
On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote:
> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
> type of enum drm_mode_status, but the mode_valid field in the struct
> definition has a return type of int.
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definitions do not match the function hook definition.
>
> The return type of the mode_valid field should be changed from int to
> enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> index d96c3cc46e50..50205f064d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> - struct drm_display_mode *mode);
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> + struct drm_display_mode *mode);
>
> /*
> * Callback for preparing mode changes on an output
> --
> 2.37.2.789.g6183377224-goog
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-13 23:19 ` Nathan Chancellor
0 siblings, 0 replies; 15+ messages in thread
From: Nathan Chancellor @ 2022-09-13 23:19 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Lucas De Marchi, llvm, Dan Carpenter, David Airlie, Tom Rix,
intel-gfx, Nick Desaulniers, linux-kernel, dri-devel,
Daniel Vetter, Rodrigo Vivi
On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote:
> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
> type of enum drm_mode_status, but the mode_valid field in the struct
> definition has a return type of int.
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definitions do not match the function hook definition.
>
> The return type of the mode_valid field should be changed from int to
> enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> index d96c3cc46e50..50205f064d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> - struct drm_display_mode *mode);
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> + struct drm_display_mode *mode);
>
> /*
> * Callback for preparing mode changes on an output
> --
> 2.37.2.789.g6183377224-goog
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix return type of mode_valid function hook
2022-09-13 20:55 ` Nathan Huckleberry
` (3 preceding siblings ...)
(?)
@ 2022-09-14 10:36 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-14 10:36 UTC (permalink / raw)
To: Nathan Huckleberry; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4279 bytes --]
== Series Details ==
Series: drm/i915: Fix return type of mode_valid function hook
URL : https://patchwork.freedesktop.org/series/108553/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12133 -> Patchwork_108553v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/index.html
Participating hosts (42 -> 38)
------------------------------
Additional (1): fi-icl-u2
Missing (5): fi-ctg-p8600 fi-hsw-4770 bat-adln-1 bat-jsl-1 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_108553v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@engines@basic:
- fi-icl-u2: NOTRUN -> [INCOMPLETE][1] ([i915#4890])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/fi-icl-u2/igt@gem_exec_parallel@engines@basic.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: NOTRUN -> [DMESG-FAIL][2] ([i915#4528])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [PASS][3] -> [INCOMPLETE][4] ([i915#4418])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][5] -> [INCOMPLETE][6] ([i915#146] / [i915#6598] / [i915#6712])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-snb-2600: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/fi-snb-2600/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][8] ([i915#4312] / [i915#6599])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/fi-icl-u2/igt@runner@aborted.html
- bat-dg1-5: NOTRUN -> [FAIL][9] ([i915#4312] / [i915#5257])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/bat-dg1-5/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [DMESG-FAIL][10] ([i915#4528]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/fi-blb-e6850/igt@i915_selftest@live@requests.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
Build changes
-------------
* Linux: CI_DRM_12133 -> Patchwork_108553v1
CI-20190529: 20190529
CI_DRM_12133: 81bd7da6c37f2197b9767a9c45091273ca688bdb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6655: 1c26b484df1d07ddb403883c88b8b82db7d63877 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108553v1: 81bd7da6c37f2197b9767a9c45091273ca688bdb @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
387591e74632 drm/i915: Fix return type of mode_valid function hook
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/index.html
[-- Attachment #2: Type: text/html, Size: 5194 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
2022-09-13 20:55 ` Nathan Huckleberry
(?)
@ 2022-09-14 13:47 ` Andrzej Hajda
-1 siblings, 0 replies; 15+ messages in thread
From: Andrzej Hajda @ 2022-09-14 13:47 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Lucas De Marchi, llvm, Dan Carpenter, David Airlie, Tom Rix,
intel-gfx, Nick Desaulniers, linux-kernel, Nathan Chancellor,
dri-devel, Daniel Vetter, Rodrigo Vivi
On 13.09.2022 22:55, Nathan Huckleberry wrote:
> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
> type of enum drm_mode_status, but the mode_valid field in the struct
> definition has a return type of int.
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definitions do not match the function hook definition.
>
> The return type of the mode_valid field should be changed from int to
> enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> index d96c3cc46e50..50205f064d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> - struct drm_display_mode *mode);
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> + struct drm_display_mode *mode);
>
> /*
> * Callback for preparing mode changes on an output
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-14 13:47 ` Andrzej Hajda
0 siblings, 0 replies; 15+ messages in thread
From: Andrzej Hajda @ 2022-09-14 13:47 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Nick Desaulniers, Dan Carpenter, David Airlie, Tom Rix,
intel-gfx, llvm, Lucas De Marchi, linux-kernel, dri-devel,
Nathan Chancellor, Rodrigo Vivi
On 13.09.2022 22:55, Nathan Huckleberry wrote:
> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
> type of enum drm_mode_status, but the mode_valid field in the struct
> definition has a return type of int.
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definitions do not match the function hook definition.
>
> The return type of the mode_valid field should be changed from int to
> enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> index d96c3cc46e50..50205f064d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> - struct drm_display_mode *mode);
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> + struct drm_display_mode *mode);
>
> /*
> * Callback for preparing mode changes on an output
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-14 13:47 ` Andrzej Hajda
0 siblings, 0 replies; 15+ messages in thread
From: Andrzej Hajda @ 2022-09-14 13:47 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: Nick Desaulniers, Dan Carpenter, David Airlie, Tom Rix,
intel-gfx, llvm, Lucas De Marchi, linux-kernel, dri-devel,
Nathan Chancellor, Daniel Vetter, Rodrigo Vivi
On 13.09.2022 22:55, Nathan Huckleberry wrote:
> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
> type of enum drm_mode_status, but the mode_valid field in the struct
> definition has a return type of int.
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definitions do not match the function hook definition.
>
> The return type of the mode_valid field should be changed from int to
> enum drm_mode_status.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> index d96c3cc46e50..50205f064d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> - struct drm_display_mode *mode);
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> + struct drm_display_mode *mode);
>
> /*
> * Callback for preparing mode changes on an output
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix return type of mode_valid function hook
2022-09-13 20:55 ` Nathan Huckleberry
` (5 preceding siblings ...)
(?)
@ 2022-09-15 1:31 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-09-15 1:31 UTC (permalink / raw)
To: Nathan Huckleberry; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 35907 bytes --]
== Series Details ==
Series: drm/i915: Fix return type of mode_valid function hook
URL : https://patchwork.freedesktop.org/series/108553/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12133_full -> Patchwork_108553v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_108553v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_108553v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_108553v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
Known issues
------------
Here are the changes found in Patchwork_108553v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#4525]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb4/igt@gem_exec_balancer@parallel-out-fence.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb5/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][8] -> [SKIP][9] ([i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@gem_lmem_swapping@heavy-verify-multi.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#5566] / [i915#716])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl2/igt@gen9_exec_parse@allowed-single.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#1937])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#165] / [i915#62]) +4 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl6/igt@i915_pm_rpm@debugfs-forcewake-user.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@i915_pm_rpm@debugfs-forcewake-user.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglb: [PASS][18] -> [FAIL][19] ([i915#3743]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3886]) +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color_chamelium@ctm-blue-to-red:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_color_chamelium@ctm-blue-to-red.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][22] ([i915#1319])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_content_protection@lic.html
* igt@kms_cursor_edge_walk@top-edge@pipe-c-dp-1-256x256:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#62]) +42 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl6/igt@kms_cursor_edge_walk@top-edge@pipe-c-dp-1-256x256.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_cursor_edge_walk@top-edge@pipe-c-dp-1-256x256.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-apl: NOTRUN -> [DMESG-WARN][25] ([i915#62]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [PASS][26] -> [FAIL][27] ([i915#79])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [PASS][28] -> [DMESG-WARN][29] ([i915#1982] / [i915#62])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl6/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#2672]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#2672] / [i915#3555])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#2587] / [i915#2672]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][33] -> [SKIP][34] ([i915#3555]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_plane_multiple@tiling-yf@pipe-a-dp-1:
- shard-apl: [PASS][35] -> [SKIP][36] ([fdo#109271])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_plane_multiple@tiling-yf@pipe-a-dp-1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_plane_multiple@tiling-yf@pipe-a-dp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [PASS][37] -> [SKIP][38] ([i915#5235]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#658]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109642] / [fdo#111068] / [i915#658])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb8/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][42] -> [SKIP][43] ([fdo#109441]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271]) +64 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_sysfs_edid_timing:
- shard-apl: [PASS][45] -> [DMESG-FAIL][46] ([i915#62])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_sysfs_edid_timing.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_sysfs_edid_timing.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#2437])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@kms_writeback@writeback-pixel-formats.html
* igt@prime_nv_api@i915_nv_import_twice_check_flink_name:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109291])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb1/igt@prime_nv_api@i915_nv_import_twice_check_flink_name.html
* igt@sysfs_clients@sema-50:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#2994])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb1/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [SKIP][50] ([i915#6252]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-rkl-6/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_eio@kms:
- shard-tglb: [FAIL][52] ([i915#5784]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb5/igt@gem_eio@kms.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb2/igt@gem_eio@kms.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][54] ([i915#4525]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb7/igt@gem_exec_balancer@parallel-keep-in-fence.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_capture@pi@rcs0:
- {shard-tglu}: [INCOMPLETE][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglu-3/igt@gem_exec_capture@pi@rcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglu-1/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][58] ([i915#2842]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][60] ([i915#2842]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-glk2/igt@gem_exec_fair@basic-none@vcs0.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-glk6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-sync@rcs0:
- shard-tglb: [SKIP][62] ([i915#2848]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb2/igt@gem_exec_fair@basic-sync@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb5/igt@gem_exec_fair@basic-sync@rcs0.html
* igt@gem_exec_reloc@basic-concurrent16:
- shard-apl: [DMESG-WARN][64] ([i915#5904] / [i915#62]) -> [PASS][65] +9 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@gem_exec_reloc@basic-concurrent16.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@gem_exec_reloc@basic-concurrent16.html
* igt@gem_exec_reloc@basic-wc-cpu-active:
- shard-tglb: [DMESG-WARN][66] ([i915#1982]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb2/igt@gem_exec_reloc@basic-wc-cpu-active.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb1/igt@gem_exec_reloc@basic-wc-cpu-active.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [DMESG-WARN][68] ([i915#180]) -> [PASS][69] +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@gem_exec_suspend@basic-s3@smem.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_userptr_blits@huge-split:
- shard-tglb: [FAIL][70] ([i915#3376]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb1/igt@gem_userptr_blits@huge-split.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb2/igt@gem_userptr_blits@huge-split.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [INCOMPLETE][72] ([i915#6775]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb1/igt@i915_module_load@reload-with-fault-injection.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb1/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][74] ([i915#4281]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb2/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-tglu}: [FAIL][76] ([i915#3825]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglu-4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglu-1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][78] ([i915#6537]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl4/igt@i915_pm_rps@engine-order.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl2/igt@i915_pm_rps@engine-order.html
* igt@i915_selftest@perf@engine_cs:
- shard-apl: [DMESG-WARN][80] ([i915#5904]) -> [PASS][81] +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@i915_selftest@perf@engine_cs.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@i915_selftest@perf@engine_cs.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-tglb: [FAIL][82] ([i915#3743]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- {shard-rkl}: [SKIP][84] ([i915#1845] / [i915#4098]) -> [PASS][85] +7 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-rkl-5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-apl: [SKIP][86] ([fdo#109271]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][88] ([i915#2346]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][90] ([i915#79]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_flip@flip-vs-panning-interruptible@b-dp1:
- shard-apl: [DMESG-WARN][92] ([i915#180] / [i915#5904] / [i915#62]) -> [PASS][93] +9 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_flip@flip-vs-panning-interruptible@b-dp1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@kms_flip@flip-vs-panning-interruptible@b-dp1.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][94] ([i915#1849] / [i915#4098]) -> [PASS][95] +8 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-badstride.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- {shard-rkl}: [SKIP][96] ([i915#1849] / [i915#3546] / [i915#4098]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-rkl-5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_properties@plane-properties-legacy:
- {shard-rkl}: [SKIP][98] ([i915#1849]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-rkl-5/igt@kms_properties@plane-properties-legacy.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-rkl-6/igt@kms_properties@plane-properties-legacy.html
* igt@kms_psr@no_drrs:
- {shard-rkl}: [SKIP][100] ([i915#1072]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-rkl-5/igt@kms_psr@no_drrs.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-rkl-6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][102] ([fdo#109441]) -> [PASS][103] +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [SKIP][104] ([i915#5519]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-tglb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-tglb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
#### Warnings ####
* igt@gem_eio@wait-wedge-10ms:
- shard-apl: [DMESG-WARN][106] ([i915#5904] / [i915#62]) -> [DMESG-WARN][107] ([i915#62]) +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@gem_eio@wait-wedge-10ms.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@gem_eio@wait-wedge-10ms.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-180:
- shard-apl: [DMESG-WARN][108] ([i915#1982] / [i915#5904] / [i915#62]) -> [DMESG-WARN][109] ([i915#1982] / [i915#62])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][110] ([i915#180] / [i915#1982] / [i915#4939] / [i915#6598]) -> [DMESG-WARN][111] ([i915#1982] / [i915#62])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@basic-flip-vs-modeset@a-dp1:
- shard-apl: [DMESG-WARN][112] ([i915#180] / [i915#5904] / [i915#62]) -> [DMESG-WARN][113] ([i915#1982] / [i915#62])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-valid-mode:
- shard-apl: [DMESG-WARN][114] ([i915#180] / [i915#5904] / [i915#62]) -> [DMESG-WARN][115] ([i915#62]) +9 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-valid-mode.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-valid-mode.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: [DMESG-FAIL][116] ([fdo#108145] / [i915#180] / [i915#62]) -> [DMESG-FAIL][117] ([fdo#108145] / [i915#62])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: [SKIP][118] ([fdo#109271] / [i915#3546]) -> [FAIL][119] ([fdo#108145] / [i915#265])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_multiple@tiling-yf@pipe-c-dp-1:
- shard-apl: [DMESG-WARN][120] ([i915#180] / [i915#5904] / [i915#62]) -> [SKIP][121] ([fdo#109271]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@kms_plane_multiple@tiling-yf@pipe-c-dp-1.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@kms_plane_multiple@tiling-yf@pipe-c-dp-1.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][122] ([i915#2920]) -> [SKIP][123] ([fdo#111068] / [i915#658])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [SKIP][124] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][125] ([i915#5939])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-iclb3/igt@kms_psr2_su@page_flip-p010.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
* igt@runner@aborted:
- shard-apl: ([FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl2/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl6/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl1/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12133/shard-apl8/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl3/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl1/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl8/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/shard-apl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2848]: https://gitlab.freedesktop.org/drm/intel/issues/2848
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6775]: https://gitlab.freedesktop.org/drm/intel/issues/6775
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12133 -> Patchwork_108553v1
CI-20190529: 20190529
CI_DRM_12133: 81bd7da6c37f2197b9767a9c45091273ca688bdb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6655: 1c26b484df1d07ddb403883c88b8b82db7d63877 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108553v1: 81bd7da6c37f2197b9767a9c45091273ca688bdb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108553v1/index.html
[-- Attachment #2: Type: text/html, Size: 40309 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Fix return type of mode_valid function hook
2022-09-13 23:19 ` Nathan Chancellor
(?)
@ 2022-09-15 7:39 ` Jani Nikula
-1 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-09-15 7:39 UTC (permalink / raw)
To: Nathan Chancellor, Nathan Huckleberry
Cc: Dan Carpenter, llvm, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, Nick Desaulniers,
Tom Rix, Matt Roper, Lucas De Marchi, intel-gfx, dri-devel,
linux-kernel
On Tue, 13 Sep 2022, Nathan Chancellor <nathan@kernel.org> wrote:
> On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote:
>> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
>> type of enum drm_mode_status, but the mode_valid field in the struct
>> definition has a return type of int.
>>
>> The mismatched return type breaks forward edge kCFI since the underlying
>> function definitions do not match the function hook definition.
>>
>> The return type of the mode_valid field should be changed from int to
>> enum drm_mode_status.
>>
>> Reported-by: Dan Carpenter <error27@gmail.com>
>> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
>> Cc: llvm@lists.linux.dev
>> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Thanks for the patch and reviews, pushed to drm-intel-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> index d96c3cc46e50..50205f064d93 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
>> *
>> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
>> */
>> - int (*mode_valid)(struct intel_dvo_device *dvo,
>> - struct drm_display_mode *mode);
>> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
>> + struct drm_display_mode *mode);
>>
>> /*
>> * Callback for preparing mode changes on an output
>> --
>> 2.37.2.789.g6183377224-goog
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-15 7:39 ` Jani Nikula
0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-09-15 7:39 UTC (permalink / raw)
To: Nathan Chancellor, Nathan Huckleberry
Cc: Lucas De Marchi, Tvrtko Ursulin, llvm, Dan Carpenter,
David Airlie, Tom Rix, intel-gfx, Nick Desaulniers, linux-kernel,
dri-devel, Rodrigo Vivi
On Tue, 13 Sep 2022, Nathan Chancellor <nathan@kernel.org> wrote:
> On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote:
>> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
>> type of enum drm_mode_status, but the mode_valid field in the struct
>> definition has a return type of int.
>>
>> The mismatched return type breaks forward edge kCFI since the underlying
>> function definitions do not match the function hook definition.
>>
>> The return type of the mode_valid field should be changed from int to
>> enum drm_mode_status.
>>
>> Reported-by: Dan Carpenter <error27@gmail.com>
>> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
>> Cc: llvm@lists.linux.dev
>> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Thanks for the patch and reviews, pushed to drm-intel-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> index d96c3cc46e50..50205f064d93 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
>> *
>> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
>> */
>> - int (*mode_valid)(struct intel_dvo_device *dvo,
>> - struct drm_display_mode *mode);
>> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
>> + struct drm_display_mode *mode);
>>
>> /*
>> * Callback for preparing mode changes on an output
>> --
>> 2.37.2.789.g6183377224-goog
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook
@ 2022-09-15 7:39 ` Jani Nikula
0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-09-15 7:39 UTC (permalink / raw)
To: Nathan Chancellor, Nathan Huckleberry
Cc: Lucas De Marchi, llvm, Dan Carpenter, David Airlie, Tom Rix,
intel-gfx, Nick Desaulniers, linux-kernel, dri-devel,
Daniel Vetter, Rodrigo Vivi
On Tue, 13 Sep 2022, Nathan Chancellor <nathan@kernel.org> wrote:
> On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote:
>> All of the functions used for intel_dvo_dev_ops.mode_valid have a return
>> type of enum drm_mode_status, but the mode_valid field in the struct
>> definition has a return type of int.
>>
>> The mismatched return type breaks forward edge kCFI since the underlying
>> function definitions do not match the function hook definition.
>>
>> The return type of the mode_valid field should be changed from int to
>> enum drm_mode_status.
>>
>> Reported-by: Dan Carpenter <error27@gmail.com>
>> Link: https://github.com/ClangBuiltLinux/linux/issues/1703
>> Cc: llvm@lists.linux.dev
>> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Thanks for the patch and reviews, pushed to drm-intel-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> index d96c3cc46e50..50205f064d93 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
>> @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
>> *
>> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
>> */
>> - int (*mode_valid)(struct intel_dvo_device *dvo,
>> - struct drm_display_mode *mode);
>> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
>> + struct drm_display_mode *mode);
>>
>> /*
>> * Callback for preparing mode changes on an output
>> --
>> 2.37.2.789.g6183377224-goog
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-09-19 13:29 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 20:55 [PATCH] drm/i915: Fix return type of mode_valid function hook Nathan Huckleberry
2022-09-13 20:55 ` [Intel-gfx] " Nathan Huckleberry
2022-09-13 20:55 ` Nathan Huckleberry
2022-09-13 20:55 ` Nathan Huckleberry
2022-09-13 23:19 ` Nathan Chancellor
2022-09-13 23:19 ` [Intel-gfx] " Nathan Chancellor
2022-09-13 23:19 ` Nathan Chancellor
2022-09-15 7:39 ` Jani Nikula
2022-09-15 7:39 ` [Intel-gfx] " Jani Nikula
2022-09-15 7:39 ` Jani Nikula
2022-09-14 10:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-14 13:47 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2022-09-14 13:47 ` Andrzej Hajda
2022-09-14 13:47 ` Andrzej Hajda
2022-09-15 1:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.