From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C80ECAAD3 for ; Wed, 14 Sep 2022 18:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiINSFQ (ORCPT ); Wed, 14 Sep 2022 14:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiINSFJ (ORCPT ); Wed, 14 Sep 2022 14:05:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 437A5C46; Wed, 14 Sep 2022 11:05:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF54161DD9; Wed, 14 Sep 2022 18:05:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EDD9C433D6; Wed, 14 Sep 2022 18:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663178708; bh=e2slHSgeoUgIh3zoiTFJXIXJMSZ4aPFjE289S3cMQXc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CtRKZzYcmdo9mBSod6ZxSQ9g/KI0FkHzt63GRo9Z5DDOVT5i9b/Gz3YIRgJvTb+V+ I0wtOcGf5epD8SP8k63ozUjFRZe39PFNghx5I+UYQa1nmthhRT0bOZZ3q82isApGL1 /xyvHo5LZMTR9y4dapbH32H8Y29c7n1kH4cAh2IOo/Vm7Kx2XiZA6mM6tZHpQqu6/p uYlXXcVqpYyI0aVHJT0oTej5Heg9JyY+do6Qz9p68+nNA7+WdjJcWqHdN2LiPCgFQr xomfQcBAI0WsHa8zm2gETtS7zRs0e24stjyb4zwiPcC2eq5p2HvTeFiK5+kH1dGYKW F1gcNlftXe4pw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> References: <20220815-rpi-fix-4k-60-v1-0-c52bd642f7c6@cerno.tech> <20220815-rpi-fix-4k-60-v1-2-c52bd642f7c6@cerno.tech> <20220914155035.88E45C433C1@smtp.kernel.org> <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> Subject: Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Broadcom internal kernel review list , Daniel Vetter , David Airlie , Emma Anholt , Florian Fainelli , Maxime Ripard , Maxime Ripard , Michael Turquette , Ray Jui , Scott Branden , Stefan Wahren Date: Wed, 14 Sep 2022 11:05:06 -0700 User-Agent: alot/0.10 Message-Id: <20220914180508.0EDD9C433D6@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stefan Wahren (2022-09-14 10:45:48) > Am 14.09.22 um 17:50 schrieb Stephen Boyd: > > > > Furthermore, I wonder if even that part needs to be implemented. Why > > not make a direct call to rpi_firmware_property() and get the max rate? > > All of that can live in the drm driver. Making it a generic API that > > takes a 'struct clk' means that it looks like any clk can be passed, > > when that isn't true. It would be better to restrict it to the one use > > case so that the scope of the problem doesn't grow. I understand that it > > duplicates a few lines of code, but that looks like a fair tradeoff vs. > > exposing an API that can be used for other clks in the future. > it would be nice to keep all the Rpi specific stuff out of the DRM=20 > driver, since there more users of it. Instead of 'all' did you mean 'any'? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A273DC6FA82 for ; Wed, 14 Sep 2022 18:05:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A744810E0C8; Wed, 14 Sep 2022 18:05:13 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2064A10E0C8 for ; Wed, 14 Sep 2022 18:05:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55D76B81C4D; Wed, 14 Sep 2022 18:05:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EDD9C433D6; Wed, 14 Sep 2022 18:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663178708; bh=e2slHSgeoUgIh3zoiTFJXIXJMSZ4aPFjE289S3cMQXc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CtRKZzYcmdo9mBSod6ZxSQ9g/KI0FkHzt63GRo9Z5DDOVT5i9b/Gz3YIRgJvTb+V+ I0wtOcGf5epD8SP8k63ozUjFRZe39PFNghx5I+UYQa1nmthhRT0bOZZ3q82isApGL1 /xyvHo5LZMTR9y4dapbH32H8Y29c7n1kH4cAh2IOo/Vm7Kx2XiZA6mM6tZHpQqu6/p uYlXXcVqpYyI0aVHJT0oTej5Heg9JyY+do6Qz9p68+nNA7+WdjJcWqHdN2LiPCgFQr xomfQcBAI0WsHa8zm2gETtS7zRs0e24stjyb4zwiPcC2eq5p2HvTeFiK5+kH1dGYKW F1gcNlftXe4pw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> References: <20220815-rpi-fix-4k-60-v1-0-c52bd642f7c6@cerno.tech> <20220815-rpi-fix-4k-60-v1-2-c52bd642f7c6@cerno.tech> <20220914155035.88E45C433C1@smtp.kernel.org> <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> Subject: Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum From: Stephen Boyd To: Broadcom internal kernel review list , Daniel Vetter , David Airlie , Emma Anholt , Florian Fainelli , Maxime Ripard , Maxime Ripard , Michael Turquette , Ray Jui , Scott Branden , Stefan Wahren Date: Wed, 14 Sep 2022 11:05:06 -0700 User-Agent: alot/0.10 Message-Id: <20220914180508.0EDD9C433D6@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, Dom Cobley , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Stefan Wahren (2022-09-14 10:45:48) > Am 14.09.22 um 17:50 schrieb Stephen Boyd: > > > > Furthermore, I wonder if even that part needs to be implemented. Why > > not make a direct call to rpi_firmware_property() and get the max rate? > > All of that can live in the drm driver. Making it a generic API that > > takes a 'struct clk' means that it looks like any clk can be passed, > > when that isn't true. It would be better to restrict it to the one use > > case so that the scope of the problem doesn't grow. I understand that it > > duplicates a few lines of code, but that looks like a fair tradeoff vs. > > exposing an API that can be used for other clks in the future. > it would be nice to keep all the Rpi specific stuff out of the DRM=20 > driver, since there more users of it. Instead of 'all' did you mean 'any'? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4444ECAAD3 for ; Wed, 14 Sep 2022 18:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y39uNLKVBS7cNMZ7Z90qW7d9Zku+HGmhARzLCbk73yw=; b=LMDD25JfdNIgvr hGzgvxI3Yk8bjBUE8MXl695f3WL0nxS83WRJlM3MZ75uqXsnHRGlCjfvoTMS5lu32d56z4jOd0t98 bK+Bh4bjQE2kIwKHhUHpndnFRb0fjiS2kbOwOddAGKhY5SghBz7CXhtwEyQKT03lEQAS/z1d6ilv0 Sxime7nffYUaV92nleQB+pqsHIR+4DCvnTxXoUTjmQs21EtOeSZbNpcPiSrCxqO8trYW/SbDhzeCK 0G7UTWEMLPLC/uI7C9nCJRYP4SZoCayUPxHtpeWg8p5WaZ6KVAapYYVvMuot0u9OsszDD5ZIc8+0l ZPMFE3PdcEi3hXJlcu+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYWl8-006Sdg-Ce; Wed, 14 Sep 2022 18:05:14 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYWl5-006SSW-0C; Wed, 14 Sep 2022 18:05:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55D76B81C4D; Wed, 14 Sep 2022 18:05:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EDD9C433D6; Wed, 14 Sep 2022 18:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663178708; bh=e2slHSgeoUgIh3zoiTFJXIXJMSZ4aPFjE289S3cMQXc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CtRKZzYcmdo9mBSod6ZxSQ9g/KI0FkHzt63GRo9Z5DDOVT5i9b/Gz3YIRgJvTb+V+ I0wtOcGf5epD8SP8k63ozUjFRZe39PFNghx5I+UYQa1nmthhRT0bOZZ3q82isApGL1 /xyvHo5LZMTR9y4dapbH32H8Y29c7n1kH4cAh2IOo/Vm7Kx2XiZA6mM6tZHpQqu6/p uYlXXcVqpYyI0aVHJT0oTej5Heg9JyY+do6Qz9p68+nNA7+WdjJcWqHdN2LiPCgFQr xomfQcBAI0WsHa8zm2gETtS7zRs0e24stjyb4zwiPcC2eq5p2HvTeFiK5+kH1dGYKW F1gcNlftXe4pw== MIME-Version: 1.0 In-Reply-To: <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> References: <20220815-rpi-fix-4k-60-v1-0-c52bd642f7c6@cerno.tech> <20220815-rpi-fix-4k-60-v1-2-c52bd642f7c6@cerno.tech> <20220914155035.88E45C433C1@smtp.kernel.org> <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> Subject: Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Broadcom internal kernel review list , Daniel Vetter , David Airlie , Emma Anholt , Florian Fainelli , Maxime Ripard , Maxime Ripard , Michael Turquette , Ray Jui , Scott Branden , Stefan Wahren Date: Wed, 14 Sep 2022 11:05:06 -0700 User-Agent: alot/0.10 Message-Id: <20220914180508.0EDD9C433D6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_110511_212272_D92B8622 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Stefan Wahren (2022-09-14 10:45:48) > Am 14.09.22 um 17:50 schrieb Stephen Boyd: > > > > Furthermore, I wonder if even that part needs to be implemented. Why > > not make a direct call to rpi_firmware_property() and get the max rate? > > All of that can live in the drm driver. Making it a generic API that > > takes a 'struct clk' means that it looks like any clk can be passed, > > when that isn't true. It would be better to restrict it to the one use > > case so that the scope of the problem doesn't grow. I understand that it > > duplicates a few lines of code, but that looks like a fair tradeoff vs. > > exposing an API that can be used for other clks in the future. > it would be nice to keep all the Rpi specific stuff out of the DRM > driver, since there more users of it. Instead of 'all' did you mean 'any'? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel