Hi, On Thu, Sep 15, 2022 at 12:30:14AM +0800, cy_huang wrote: > From: ChiYuan Huang > > Add support for the RT9471 3A 1-Cell Li+ battery charger. > > The RT9471 is a highly-integrated 3A switch mode battery charger with > low impedance power path to better optimize the charging efficiency. > > Co-developed-by: Alina Yu > Signed-off-by: Alina Yu > Signed-off-by: ChiYuan Huang > --- > [...] > +static DEVICE_ATTR_RW(sysoff_enable); > +static DEVICE_ATTR_RW(port_detect_enable); > + > +static struct attribute *rt9471_sysfs_entries[] = { > + &dev_attr_sysoff_enable.attr, > + &dev_attr_port_detect_enable.attr, > + NULL > +}; > + > +static const struct attribute_group rt9471_attr_group = { > + .attrs = rt9471_sysfs_entries, > +}; > + > +static const struct attribute_group *rt9471_attr_groups[] = { > + &rt9471_attr_group, > + NULL > +}; Iff these custom properties are required (see response to the last patch), then 'ATTRIBUTE_GROUPS()' can be used to simplify this part a bit. -- Sebastian