All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haoyue Xu <xuhaoyue1@hisilicon.com>
To: <davem@davemloft.net>, <kuba@kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<michal.simek@xilinx.com>
Cc: <huangdaode@huawei.com>, <liyangyang20@huawei.com>,
	<xuhaoyue1@hisilicon.com>, <huangjunxian6@hisilicon.com>,
	<linuxarm@huawei.com>, <liangwenpeng@huawei.com>
Subject: [PATCH net-next 2/7] net: ll_temac: Cleanup for function name in a string
Date: Sat, 17 Sep 2022 18:38:38 +0800	[thread overview]
Message-ID: <20220917103843.526877-3-xuhaoyue1@hisilicon.com> (raw)
In-Reply-To: <20220917103843.526877-1-xuhaoyue1@hisilicon.com>

As Checkpatch.pl warns, prefer using '"%s...", __func__'
to using 'temac_device_reset', this function's name, in a string.

Signed-off-by: Haoyue Xu <xuhaoyue1@hisilicon.com>
---
 drivers/net/ethernet/xilinx/ll_temac_main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 1dfbd85b848d..26fbe60e2cf4 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -642,7 +642,7 @@ static void temac_device_reset(struct net_device *ndev)
 		udelay(1);
 		if (--timeout == 0) {
 			dev_err(&ndev->dev,
-				"temac_device_reset RX reset timeout!!\n");
+				"%s RX reset timeout!!\n", __func__);
 			break;
 		}
 	}
@@ -654,7 +654,7 @@ static void temac_device_reset(struct net_device *ndev)
 		udelay(1);
 		if (--timeout == 0) {
 			dev_err(&ndev->dev,
-				"temac_device_reset TX reset timeout!!\n");
+				"%s TX reset timeout!!\n", __func__);
 			break;
 		}
 	}
@@ -673,7 +673,7 @@ static void temac_device_reset(struct net_device *ndev)
 		udelay(1);
 		if (--timeout == 0) {
 			dev_err(&ndev->dev,
-				"temac_device_reset DMA reset timeout!!\n");
+				"%s DMA reset timeout!!\n", __func__);
 			break;
 		}
 	}
@@ -681,7 +681,8 @@ static void temac_device_reset(struct net_device *ndev)
 
 	if (temac_dma_bd_init(ndev)) {
 		dev_err(&ndev->dev,
-				"temac_device_reset descriptor allocation failed\n");
+			"%s descriptor allocation failed\n", __func__);
+
 	}
 
 	spin_lock_irqsave(lp->indirect_lock, flags);
-- 
2.30.0


  parent reply	other threads:[~2022-09-17 10:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17 10:38 [PATCH net-next 0/7] net: ll_temac: Cleanup for clearing static warnings Haoyue Xu
2022-09-17 10:38 ` [PATCH net-next 1/7] net: ll_temac: fix the format of block comments Haoyue Xu
2022-09-17 10:38 ` Haoyue Xu [this message]
2022-09-17 10:38 ` [PATCH net-next 3/7] net: ll_temac: axienet: align with open parenthesis Haoyue Xu
2022-09-17 10:38 ` [PATCH net-next 4/7] net: ll_temac: delete unnecessary else branch Haoyue Xu
2022-09-17 10:38 ` [PATCH net-next 5/7] net: ll_temac: fix the missing spaces around '=' Haoyue Xu
2022-09-17 10:38 ` [PATCH net-next 6/7] net: ll_temac: move trailing statements to next line Haoyue Xu
2022-09-17 10:38 ` [PATCH net-next 7/7] net: ll_temac: axienet: delete unnecessary blank lines and spaces Haoyue Xu
2022-09-20  5:30 ` [PATCH net-next 0/7] net: ll_temac: Cleanup for clearing static warnings Harini Katakam
2022-09-22  1:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220917103843.526877-3-xuhaoyue1@hisilicon.com \
    --to=xuhaoyue1@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=huangdaode@huawei.com \
    --cc=huangjunxian6@hisilicon.com \
    --cc=kuba@kernel.org \
    --cc=liangwenpeng@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liyangyang20@huawei.com \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.