From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE41C6FA86 for ; Sun, 18 Sep 2022 20:48:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46FCE94000B; Sun, 18 Sep 2022 16:48:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA37940008; Sun, 18 Sep 2022 16:48:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24BE094000B; Sun, 18 Sep 2022 16:48:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 16DA8940008 for ; Sun, 18 Sep 2022 16:48:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E0D1081048 for ; Sun, 18 Sep 2022 20:48:05 +0000 (UTC) X-FDA: 79926393330.03.7D0D862 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf14.hostedemail.com (Postfix) with ESMTP id 9594A100008 for ; Sun, 18 Sep 2022 20:48:05 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-349e6acbac9so89567637b3.2 for ; Sun, 18 Sep 2022 13:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date; bh=9fbu9/AcjqREk+tOcTZ0vFQGumfdYFLY0ujIQ9fmw6U=; b=DT/BXh3iJqzMhyJl9tq44ENviA2gqUFRt1e0POy5yIY6e6a1ZU2f2UbjtBSizGG3n2 ngXv5hn+GpRCNyo4i3umQ6g2rRyHUnW8BNz5GOFUB5cNzroNH7MzsKMOKY0qJaCv4SMP CB0uzpXNB9W2/rGxeC9q+gjBoFpXjhBob6nJ/hTflbgN+QglBbMC8PM771rV1jY4VKaU MWdrkx9Xwa3fsQfiAGixdtnUAIm+fZWdT68QClwccdrOoS8zHllPBgOruk6AZZWzrQfS UtmVPZZIBYQ+AkqVMkxxo6VBmvri7R29/kAqYPT2lSLPXaejWDdbtT1gOfrN25fpf8kT No7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=9fbu9/AcjqREk+tOcTZ0vFQGumfdYFLY0ujIQ9fmw6U=; b=sdD0CKyjJBoLt7l99WB4ebhU2d+2LeLYP71VbJzFnDkdFOTpSJxnnmetva2GmbYx7w gJPRHyy9kSJFixbvOGOkLbz2RrJ/lSPcI5NobzZA1O9ub3aXo85ilYexiUk/29wNBmpO MO/5Fm0TLg8Y3Xe8Hf14woD4/kUWseFTWprFhd0eLyFDI21GUBe5zajwOKnus1FzaK2p Bhpdp5Fmf2/epYjbmLVz5B6PmTg4oTGxkHJNQRb6WNdpB56opZ4X8kQKCO9AP9Z5nRnV tDaO7f29aAa4trA95sTHlq2w9IasC6TJqTllFo0OuUvHZVcLjreLSzRDqwAQu0OprEqP i3Sg== X-Gm-Message-State: ACrzQf29NpU0sbWQM1OCeSlKLX340Sl17FqelGnsToXNF1OsuFVaIW/4 G5B2YP1u6iPkJ1sp4l7ULCC1051Kz1c= X-Google-Smtp-Source: AMsMyM67plZ1qP8bFbUsVexyiFwS2xUKgwLHoQkzH5A5xCnZ9z4ssVrJrMYYXPUL1E81yD/3jrPT4HkL6N4= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:ccff:7b62:4ed6:2946]) (user=yuzhao job=sendgmr) by 2002:a25:24c1:0:b0:6aa:11fe:9136 with SMTP id k184-20020a2524c1000000b006aa11fe9136mr11994402ybk.373.1663534084973; Sun, 18 Sep 2022 13:48:04 -0700 (PDT) Date: Sun, 18 Sep 2022 14:47:49 -0600 In-Reply-To: <20220918204755.3135720-1-yuzhao@google.com> Message-Id: <20220918204755.3135720-5-yuzhao@google.com> Mime-Version: 1.0 References: <20220918204755.3135720-1-yuzhao@google.com> X-Mailer: git-send-email 2.37.3.968.ga6b4b080e4-goog Subject: [PATCH v14-fix 05/11] mm: multi-gen LRU: fix warning from seq_is_valid() From: Yu Zhao To: Andrew Morton Cc: linux-mm@kvack.org, Yu Zhao , David Rientjes Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663534085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9fbu9/AcjqREk+tOcTZ0vFQGumfdYFLY0ujIQ9fmw6U=; b=mH7t60XoZxnKuxPJhZE5UybxPue53SrBKCIIKl6rZMXMUTytBU58F06aCB9zr7zff0Vw1w Sij+hzpK2mV/tvTzhN6k36aC0qUTGedfxJFxFqAwl3l8eLii9To7DQ2l/W0oPXCEgEv9q2 a71/AcSCp812pYxR7hkBh5quIG1FTjU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="DT/BXh3i"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3BIQnYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3BIQnYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663534085; a=rsa-sha256; cv=none; b=jubonHeaZgI8OdZd52z06u3almDNoWMvGvs2IELcs8CBU65KzWt2iImuCR/IgfTZUQKC6Z X99dz0swowB0paPJtSDBfC9FX6zY9grSw6+4a1AJ7jYjAwHRlyJFwB4jOYSJEZepZUjhti lHYNNwgAP9OAjHQkvad5oYQP8QjbxW0= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="DT/BXh3i"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3BIQnYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3BIQnYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com X-Rspam-User: X-Stat-Signature: jqttmyx1jkecsyqi7fwwkinkjidbqaim X-Rspamd-Queue-Id: 9594A100008 X-Rspamd-Server: rspam12 X-HE-Tag: 1663534085-461811 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: v5 (link below) calls inc_min_seq() in the correct order but rewrites in the later versions broke it. WARNING: CPU: 0 PID: 0 at ./include/linux/mm_types.h:613 context_switch+0x375/0x3e0 __schedule+0x443/0x610 schedule_idle+0x27/0x40 do_idle+0x322/0x360 cpu_startup_entry+0x65/0x70 rest_init+0x1e7/0x1f0 start_kernel+0x529/0x5a0 x86_64_start_reservations+0x13f/0x150 x86_64_start_kernel+0x1f2/0x200 secondary_startup_64+0xa6/0xb0 Link: https://lore.kernel.org/linux-mm/20211111041510.402534-7-yuzhao@google.com/ Reported-by: David Rientjes Signed-off-by: Yu Zhao --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 8291808ec535..e509e896c019 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4307,7 +4307,7 @@ static void inc_max_seq(struct lruvec *lruvec, bool can_swap, bool force_scan) VM_WARN_ON_ONCE(!seq_is_valid(lruvec)); - for (type = 0; type < ANON_AND_FILE; type++) { + for (type = ANON_AND_FILE - 1; type >= 0; type--) { if (get_nr_gens(lruvec, type) != MAX_NR_GENS) continue; -- 2.37.3.968.ga6b4b080e4-goog