From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54FB5ECAAD8 for ; Sun, 18 Sep 2022 20:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0C5C94000C; Sun, 18 Sep 2022 16:48:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6DFB940008; Sun, 18 Sep 2022 16:48:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B259D94000C; Sun, 18 Sep 2022 16:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4DE4940008 for ; Sun, 18 Sep 2022 16:48:07 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78CA0C012A for ; Sun, 18 Sep 2022 20:48:07 +0000 (UTC) X-FDA: 79926393414.08.869B832 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf04.hostedemail.com (Postfix) with ESMTP id 1FCCF40010 for ; Sun, 18 Sep 2022 20:48:06 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id u12-20020a25094c000000b006a9ad6b2cebso23623255ybm.15 for ; Sun, 18 Sep 2022 13:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date; bh=ADjZhLB2lH6XDF/bluSQyDYiqynm0JA4dN820og+pN0=; b=EKBvpt34rlhTK5I0GzuLGC8jyVXUC0KpgyukD4r5rAEYDacS720kmut1oA8mJjm+3n STilIqNq6htNbfcq+OvkYN5PdVhRFOhuGlYsjB7Dl8g94rjLv6q7VrRrjwzplvOUjxxd N7TEgHbk65sbS6caMP+kOfyBRkLwJk7PtxP8kQorx4XVG/B5j0ZF2EMRTEtxwznM4/Lv EYli7mpYWzi0gnYoAJIoY5oMbUDksCsq7Vvq2lZS8EJY+o40LeVA4Nw4sYqM8LM3Ijou acV/kG0ki44dDdfybZrU1RwDxjBb6SIeu8M4qZnjw7KKG1MXJcvtmH/j4ohFIkIn+PyH OL3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=ADjZhLB2lH6XDF/bluSQyDYiqynm0JA4dN820og+pN0=; b=Iul7ck08RksEENcQRWzVlqbZUOHEUrS4WRS3kZrbAV8d9EIJ13RxZXlj5DZ/oWoikC aGJkuRm72oEzTZu3DH/SmJENNEf4Q3kcAHI5QpyOlTEVZ1/JwWOOBrSMZQPvBjpnE1BU WlWv34HncjXMBXJSpbbSQEyviFHKf/NpEbVFjUsytXP8a1+9UmN+YA+NMVvKMNHZdB7F 0Gvle+J6sSFYtL8Jdd4KBNrpjSolVQFNze6hAovMLKjeAJbAngZbDT/2pRW4TJ8OHL2F +surHFt9F6N+sILzqMp+ZhdeLRQwX6/N5A+glUbo1U4kQ7v/3hFhbnOTZGzNHZFuRLqm //fA== X-Gm-Message-State: ACrzQf3/St41TynnCOJAQ9wEw97ByIvv0LUSLG6f+9KqbYSo23BbGyob RBw+ynU3O0SS3JzeiLnaZCB8s2SajuI= X-Google-Smtp-Source: AMsMyM5D6LMhndcaLHs/g0PMv4A6e/Blkb6flfK2s8k2DE/ZlN4ZC43SwHhh91v8K+zpiIgrBJ4WuL27ZaU= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:ccff:7b62:4ed6:2946]) (user=yuzhao job=sendgmr) by 2002:a05:6902:1146:b0:6ae:72f2:62cb with SMTP id p6-20020a056902114600b006ae72f262cbmr13337927ybu.615.1663534086599; Sun, 18 Sep 2022 13:48:06 -0700 (PDT) Date: Sun, 18 Sep 2022 14:47:50 -0600 In-Reply-To: <20220918204755.3135720-1-yuzhao@google.com> Message-Id: <20220918204755.3135720-6-yuzhao@google.com> Mime-Version: 1.0 References: <20220918204755.3135720-1-yuzhao@google.com> X-Mailer: git-send-email 2.37.3.968.ga6b4b080e4-goog Subject: [PATCH v14-fix 06/11] mm: multi-gen LRU: delete overcautious VM_WARN_ON_ONCE() From: Yu Zhao To: Andrew Morton Cc: linux-mm@kvack.org, Yu Zhao , David Rientjes Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EKBvpt34; spf=pass (imf04.hostedemail.com: domain of 3BoQnYwYKCMsFBGyr5x55x2v.t532z4BE-331Crt1.58x@flex--yuzhao.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3BoQnYwYKCMsFBGyr5x55x2v.t532z4BE-331Crt1.58x@flex--yuzhao.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663534087; a=rsa-sha256; cv=none; b=1Qu906BCZeAE9bU/7QUIBFnzKEE5nmTrGVA1naaGWCaElrFxTiujcs7jWIgS1wGyanyEEf y1dUMfA1cQJxOYLmMByza2OY05BfRyk44xBAPAu6KmGNHLl0+4bl8/cQ06FDERryybkHdm urvxiwHP1qbtgSpes90XqfSzXdgX/BQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663534087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ADjZhLB2lH6XDF/bluSQyDYiqynm0JA4dN820og+pN0=; b=QE4TAPn/Pe/0KNnVJZMhx9RHkKJKh6rJFkp0BitXApfSA70zp5Q1t3HtOBahlakiMByAQ3 vMpCdI437G2E3rKVCjxknuRoHwtNrMQ9FO3SfNoKXpuXK/npjWALD2YRPwJEpxolR/B17g 98XgyT6NyRM6PCOp/mALzBIvFTMaRcU= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EKBvpt34; spf=pass (imf04.hostedemail.com: domain of 3BoQnYwYKCMsFBGyr5x55x2v.t532z4BE-331Crt1.58x@flex--yuzhao.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3BoQnYwYKCMsFBGyr5x55x2v.t532z4BE-331Crt1.58x@flex--yuzhao.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 6t4nk311fcox1w7cxduutoy5t6ruk4un X-Rspamd-Queue-Id: 1FCCF40010 X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1663534086-945354 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As commented, it is "unlikely but not a bug when reset_batch_size() is pending". This one was never reported but another similar one in lru_gen_use_mm(), which is already deleted, indeed happened. kernel BUG at mm/vmscan.c:4592! Call Trace: ? get_nr_to_scan+0x89/0x2a0 lru_gen_shrink_lruvec+0x1aa/0x2b0 shrink_node_memcg+0x68/0x450 shrink_node+0x25c/0x620 shrink_zones+0xf4/0x170 do_try_to_free_pages+0xa5/0x280 try_to_free_mem_cgroup_pages+0x161/0x1f0 try_charge+0x2b1/0x940 __mem_cgroup_try_charge+0x102/0x3d0 do_anonymous_page+0x152/0x440 handle_mm_fault+0x9d2/0x1030 __do_page_fault+0x388/0x550 do_page_fault+0x2b/0x60 page_fault+0x45/0x50 Reported-by: David Rientjes Signed-off-by: Yu Zhao --- mm/vmscan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index e509e896c019..77d2d08950ba 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5171,9 +5171,6 @@ static bool __maybe_unused state_is_valid(struct lruvec *lruvec) for_each_gen_type_zone(gen, type, zone) { if (!list_empty(&lrugen->lists[gen][type][zone])) return false; - - /* unlikely but not a bug when reset_batch_size() is pending */ - VM_WARN_ON_ONCE(lrugen->nr_pages[gen][type][zone]); } } -- 2.37.3.968.ga6b4b080e4-goog