All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Fabio Estevam <festevam@denx.de>,
	Peng Fan <peng.fan@nxp.com>, Stefano Babic <sbabic@denx.de>,
	Teresa Remmet <t.remmet@phytec.de>
Subject: [PATCH 2/4] ARM: imx8m: phycore_imx8mm: Drop bogus spl_board_init()
Date: Mon, 19 Sep 2022 21:41:16 +0200	[thread overview]
Message-ID: <20220919194118.105820-2-marex@denx.de> (raw)
In-Reply-To: <20220919194118.105820-1-marex@denx.de>

The current implementation of spl_board_init() is not correct,
the MX8MM BootROM v1 does not support SDP load when re-entered
from U-Boot SPL, it is up to U-Boot to perform the next stage
load using its own internal CI gadget driver and SDP protocol
implementation. Drop the spl_board_init() to let SPL continue
with normal load in case the SDP support is enabled.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Teresa Remmet <t.remmet@phytec.de>
---
 board/phytec/phycore_imx8mm/spl.c | 10 ----------
 configs/phycore-imx8mm_defconfig  |  1 -
 2 files changed, 11 deletions(-)

diff --git a/board/phytec/phycore_imx8mm/spl.c b/board/phytec/phycore_imx8mm/spl.c
index d87ab6d4497..1bae9b1170d 100644
--- a/board/phytec/phycore_imx8mm/spl.c
+++ b/board/phytec/phycore_imx8mm/spl.c
@@ -42,16 +42,6 @@ static void spl_dram_init(void)
 	ddr_init(&dram_timing);
 }
 
-void spl_board_init(void)
-{
-	/* Serial download mode */
-	if (is_usb_boot()) {
-		puts("Back to ROM, SDP\n");
-		restore_boot_params();
-	}
-	puts("Normal Boot\n");
-}
-
 int board_fit_config_name_match(const char *name)
 {
 	return 0;
diff --git a/configs/phycore-imx8mm_defconfig b/configs/phycore-imx8mm_defconfig
index 9b8c09a73ab..e8d7905bb4a 100644
--- a/configs/phycore-imx8mm_defconfig
+++ b/configs/phycore-imx8mm_defconfig
@@ -30,7 +30,6 @@ CONFIG_BOARD_LATE_INIT=y
 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
 CONFIG_SPL_BSS_START_ADDR=0x910000
 CONFIG_SPL_BSS_MAX_SIZE=0x2000
-CONFIG_SPL_BOARD_INIT=y
 # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
 CONFIG_SPL_STACK=0x920000
 CONFIG_SYS_SPL_MALLOC=y
-- 
2.35.1


  reply	other threads:[~2022-09-19 19:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 19:41 [PATCH 1/4] ARM: imx8m: Deduplicate CAAM init with arch_misc_init() call Marek Vasut
2022-09-19 19:41 ` Marek Vasut [this message]
2022-09-21  5:31   ` [PATCH 2/4] ARM: imx8m: phycore_imx8mm: Drop bogus spl_board_init() Peng Fan
2022-10-21 11:42   ` sbabic
2022-09-19 19:41 ` [PATCH 3/4] ARM: imx8m: verdin-imx8mm: Drop bogus content from spl_board_init() Marek Vasut
2022-09-21  5:31   ` Peng Fan
2022-10-21 11:43   ` sbabic
2022-09-19 19:41 ` [PATCH 4/4] ARM: dts: imx8m: imx8mm-mx8menlo: Enable SPL SDP support Marek Vasut
2022-09-19 22:02   ` Fabio Estevam
2022-09-24 18:38     ` Adam Ford
2022-09-24 18:52       ` Michael Nazzareno Trimarchi
2022-09-24 18:54         ` Adam Ford
2022-09-24 19:00           ` Michael Nazzareno Trimarchi
2022-09-24 19:10             ` Adam Ford
2022-09-24 19:19               ` Michael Nazzareno Trimarchi
2022-09-24 21:47               ` Marek Vasut
2022-09-24 21:54                 ` Adam Ford
2022-09-26 16:58                   ` Tim Harvey
2022-09-26 17:06                     ` Adam Ford
2022-09-26 17:12                       ` Fabio Estevam
2022-09-26 17:28                         ` Adam Ford
2022-09-26 17:50                           ` Sean Anderson
2022-09-26 20:04                         ` Tim Harvey
2022-09-26 17:14                       ` Tim Harvey
2022-09-21  5:30   ` Peng Fan
2022-09-22  2:42     ` Marek Vasut
2022-10-21 11:43   ` sbabic
2022-09-21  5:31 ` [PATCH 1/4] ARM: imx8m: Deduplicate CAAM init with arch_misc_init() call Peng Fan
2022-10-21 11:52   ` Stefano Babic
2022-10-21 11:42 ` sbabic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919194118.105820-2-marex@denx.de \
    --to=marex@denx.de \
    --cc=festevam@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=t.remmet@phytec.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.