All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "hn.chen" <hn.chen@sunplusit.com>,
	linux-media@vger.kernel.org,
	Ricardo Ribalda <ribalda@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v2 1/8] media: uvc: Extend documentation of uvc_video_clock_decode()
Date: Fri, 02 Dec 2022 18:02:41 +0100	[thread overview]
Message-ID: <20220920-resend-hwtimestamp-v2-1-0d7978a817cc@chromium.org> (raw)
In-Reply-To: <20220920-resend-hwtimestamp-v2-0-0d7978a817cc@chromium.org>

Make a explicit reference to uvc 1.5, explaining how the algorithm
supports the different behaviour of uvc 1.1 and 1.5.

Tested-by: HungNien Chen <hn.chen@sunplusit.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/usb/uvc/uvc_video.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
index 170a008f4006..ab56e65ca324 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -517,6 +517,9 @@ uvc_video_clock_decode(struct uvc_streaming *stream, struct uvc_buffer *buf,
 	/*
 	 * To limit the amount of data, drop SCRs with an SOF identical to the
 	 * previous one.
+	 * This filtering is also needed for supporting UVC 1.5. Where all the
+	 * data packages of the same frame contains the same sof. In that case
+	 * only the first one will match the host_sof.
 	 */
 	dev_sof = get_unaligned_le16(&data[header_size - 2]);
 	if (dev_sof == stream->clock.last_sof)

-- 
2.39.0.rc0.267.gcb52ba06e7-goog-b4-0.11.0-dev-696ae

  reply	other threads:[~2022-12-02 17:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 17:02 [PATCH RESEND v2 0/8] uvcvideo: Fixes for hw timestamping Ricardo Ribalda
2022-12-02 17:02 ` Ricardo Ribalda [this message]
2022-12-30 13:36   ` [PATCH RESEND v2 1/8] media: uvc: Extend documentation of uvc_video_clock_decode() Laurent Pinchart
2022-12-02 17:02 ` [PATCH RESEND v2 2/8] media: uvc: Allow quirking by entity guid Ricardo Ribalda
2022-12-30 13:40   ` Laurent Pinchart
2023-01-03 15:40     ` Ricardo Ribalda
2023-01-03 21:16       ` Laurent Pinchart
2022-12-02 17:02 ` [PATCH RESEND v2 3/8] media: uvc: Create UVC_QUIRK_IGNORE_EMPTY_TS quirk Ricardo Ribalda
2022-12-30 13:45   ` Laurent Pinchart
2023-01-03 16:00     ` Ricardo Ribalda
2023-01-07  1:16     ` Laurent Pinchart
2022-12-02 17:02 ` [PATCH RESEND v2 4/8] media: uvcvideo: Quirk for invalid dev_sof in Logi C922 Ricardo Ribalda
2022-12-30 14:31   ` Laurent Pinchart
2022-12-02 17:02 ` [PATCH RESEND v2 5/8] media: uvcvideo: Quirk for autosuspend in Logi C910 Ricardo Ribalda
2022-12-30 13:52   ` Laurent Pinchart
2023-01-03 16:13     ` Ricardo Ribalda
2022-12-02 17:02 ` [PATCH RESEND v2 6/8] media: uvcvideo: Allow hw clock updates with buffers not full Ricardo Ribalda
2022-12-30 14:37   ` Laurent Pinchart
2022-12-02 17:02 ` [PATCH RESEND v2 7/8] media: uvcvideo: Refactor clock circular buffer Ricardo Ribalda
2022-12-30 14:39   ` Laurent Pinchart
2022-12-02 17:02 ` [PATCH RESEND v2 8/8] media: uvcvideo: Fix hw timestampt handling for slow FPS Ricardo Ribalda
2022-12-30 14:51   ` Laurent Pinchart
2023-01-03 23:34     ` Ricardo Ribalda
2023-01-07  0:54       ` Laurent Pinchart
2023-01-09  8:13         ` Ricardo Ribalda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920-resend-hwtimestamp-v2-1-0d7978a817cc@chromium.org \
    --to=ribalda@chromium.org \
    --cc=hn.chen@sunplusit.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.