From: Zorro Lang <zlang@redhat.com>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2 2/2] common/quota: fix grep pattern
Date: Tue, 20 Sep 2022 12:32:43 +0800 [thread overview]
Message-ID: <20220920043243.cx42bsa5xyr3skfq@zlang-mailbox> (raw)
In-Reply-To: <20220920031951.2098839-2-jencce.kernel@gmail.com>
On Tue, Sep 20, 2022 at 11:19:51AM +0800, Murphy Zhou wrote:
> The second dash is not needed now. Newer grep is complaining:
> +grep: warning: stray \ before -
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
> ---
> v1-->v2:
> Using -- option.
Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> common/quota | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/quota b/common/quota
> index 22be3c69..24251d09 100644
> --- a/common/quota
> +++ b/common/quota
> @@ -218,7 +218,7 @@ _qmount()
> quotacheck -ug $SCRATCH_MNT >>$seqres.full 2>&1
> quotaon -ug $SCRATCH_MNT >>$seqres.full 2>&1
> # try to turn on project quota if it's supported
> - if quotaon --help 2>&1 | grep -q '\-\-project'; then
> + if quotaon --help 2>&1 | grep -q -- '--project'; then
> quotaon --project $SCRATCH_MNT >>$seqres.full 2>&1
> fi
> fi
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-09-20 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 3:19 [PATCH v2 1/2] egrep, fgrep: deprecated Murphy Zhou
2022-09-20 3:19 ` [PATCH v2 2/2] common/quota: fix grep pattern Murphy Zhou
2022-09-20 4:32 ` Zorro Lang [this message]
2022-09-20 4:31 ` [PATCH v2 1/2] egrep, fgrep: deprecated Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920043243.cx42bsa5xyr3skfq@zlang-mailbox \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jencce.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.