From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1883C54EE9 for ; Tue, 20 Sep 2022 14:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbiITOZw (ORCPT ); Tue, 20 Sep 2022 10:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231839AbiITOZQ (ORCPT ); Tue, 20 Sep 2022 10:25:16 -0400 X-Greylist: delayed 463 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 20 Sep 2022 07:25:03 PDT Received: from sym2.noone.org (sym.noone.org [178.63.92.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFA572E9DC; Tue, 20 Sep 2022 07:25:03 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4MX3XF3jCKzvjfn; Tue, 20 Sep 2022 16:17:17 +0200 (CEST) Date: Tue, 20 Sep 2022 16:17:17 +0200 From: Tobias Klauser To: Jiri Slaby Cc: gregkh@linuxfoundation.org, Ilpo =?iso-8859-1?Q?J=E4rvinen?= , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 02/10] tty: serial: clean up stop-tx part in altera_uart_tx_chars() Message-ID: <20220920141716.kqvtrqfyaf5e3ijq@distanz.ch> References: <20220920052049.20507-1-jslaby@suse.cz> <20220920052049.20507-3-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920052049.20507-3-jslaby@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-20 at 07:20:42 +0200, Jiri Slaby wrote: > The "stop TX" path in altera_uart_tx_chars() is open-coded, so: > * use uart_circ_empty() to check if the buffer is empty, and > * when true, call altera_uart_stop_tx(). > > Cc: Tobias Klauser > Signed-off-by: Jiri Slaby Acked-by: Tobias Klauser