From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EC3C6FA92 for ; Tue, 20 Sep 2022 23:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbiITXbm (ORCPT ); Tue, 20 Sep 2022 19:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbiITXbj (ORCPT ); Tue, 20 Sep 2022 19:31:39 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E45C75E64C for ; Tue, 20 Sep 2022 16:31:37 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id b11-20020a170902d50b00b0017828988079so2641091plg.21 for ; Tue, 20 Sep 2022 16:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date; bh=yLvwOWuXtYmkq2gfHjtQ1MhX2AnqJW1myBmVRg299oc=; b=pq7XJBM0vZ9KBqZnYoj2EMzf3D9IQDFghpRQZgnIbzKHdFWniBp/yKBOkw5BFcrgEG XmMR0TP7OiMzg0S/Bl1P16+d+VyB/TQfTxI8IOQiMHCw9M7Jta1HLVQNbpyZ1x9ON4PF TNyu5PyT1XzbZA9e/iPzPUXLdkZRsdWc4UVDdvx6YfGw8Pu6kvlrPpTkSr8iGQ15P1DP jrdVZOkcm8/P3ClTHMk4+Me4qwUYHIvAn/bUhM3SpvIyqef5WLyOKiOjNm72fwLLlb+f qSQBuJ4nh6g1593Cnnro7xFEq1Oy8hJtD2nS+MJkYwqJkf/bZSxq9DOlA8R8e9p3xfyG j8KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date; bh=yLvwOWuXtYmkq2gfHjtQ1MhX2AnqJW1myBmVRg299oc=; b=bUk6GzbJaxbolnW3mQlzp0fwSe+HZwVwbqJEVJlnevI5nUfznEa0nT3GYaxeD8ZwS/ Ny8OtrNOERqj80Ty6q4XIHPYqF9Q1usMGZR7FzwEQINCJK8p9M7dyrpsXLAYKAkcMfWh M+zDjmKdcDc+g94LniKtHAoCX+j3Dz3ioqAGsfwGeRN3a35ecqlhb19BVDqX0Jd2VLD0 gCDEIt4omfkgZfeP7A5uI1ScuVXgVRVsWNPg0+bMOrLNo/90dWbgnue7qPn4ABFwvk1g 2FGHMI2E8eFg3/q3+jNV/IxqT6+yEu6IarQBPwt204QdZ4OKO1w55QMmZCyWgz8S4+rk pqPA== X-Gm-Message-State: ACrzQf2umZ7V8c1zNW58PvpzQd4lnvIo5Oa2dw94NMR9CBHnn7TAt+RS O/l4FW3XjMu5KzFgYeLeVVxS5fXukN8= X-Google-Smtp-Source: AMsMyM4v+iUjgkKBatNGzl5ZdWlqUnuoLW9A6Q+ClVGzUcSTXacOuBjve8AEVYyvMQuC9dbVqnkg8JXNvyw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:1942:b0:202:cf66:f37f with SMTP id nk2-20020a17090b194200b00202cf66f37fmr6235484pjb.15.1663716697425; Tue, 20 Sep 2022 16:31:37 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 20 Sep 2022 23:31:06 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.37.3.968.ga6b4b080e4-goog Message-ID: <20220920233134.940511-1-seanjc@google.com> Subject: [PATCH v3 00/28] KVM: x86: AVIC and local APIC fixes+cleanups From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alejandro Jimenez , Suravee Suthikulpanit , Maxim Levitsky , Li RongQing Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org TL;DR: KVM's AVIC and optimized APIC map code doesn't correctly handle various edge cases that are architecturally legal(ish), but are unlikely to occur in most real world scenarios. I have tested this heavily with KUT, but I haven't booted Windows and don't have access to x2AVIC, so additional testing would be much appreciated. v3: - Collect reviews. [Paolo] - Drop "partial" x2APIC inhibit and instead delete the memslot. [Maxim, Suravee] - Skip logical mode updates for x2APIC, which just reuses the phys_map with some clever logic. [Suravee] - Add a fix for "nodecode write" traps. [Alejandro] v2: - https://lore.kernel.org/all/20220903002254.2411750-1-seanjc@google.com - Collect reviews. [Li, Maxim] - Disable only MMIO access when x2APIC is enabled (instead of disabling all of AVIC). [Maxim] - Inhibit AVIC when logical IDs are aliased. [Maxim] - Tweak name of set_virtual_apic_mode() hook. [Maxim] - Straight up revert logical ID fastpath mess. [Maxim] - Reword changelog about skipping vCPU during logical setup. [Maxim] - Fix LDR updates on AVIC. [Maxim?] - Fix a nasty ISR caching bug. - Flush TLB when activating AVIC. v1: https://lore.kernel.org/all/20220831003506.4117148-1-seanjc@google.com Sean Christopherson (27): KVM: x86: Blindly get current x2APIC reg value on "nodecode write" traps KVM: x86: Purge "highest ISR" cache when updating APICv state KVM: SVM: Flush the "current" TLB when activating AVIC KVM: SVM: Process ICR on AVIC IPI delivery failure due to invalid target KVM: x86: Don't inhibit APICv/AVIC if xAPIC ID mismatch is due to 32-bit ID KVM: x86: Move APIC access page helper to common x86 code KVM: x86: Inhibit APIC memslot if x2APIC and AVIC are enabled KVM: SVM: Don't put/load AVIC when setting virtual APIC mode KVM: SVM: Replace "avic_mode" enum with "x2avic_enabled" boolean KVM: SVM: Compute dest based on sender's x2APIC status for AVIC kick Revert "KVM: SVM: Use target APIC ID to complete x2AVIC IRQs when possible" KVM: SVM: Document that vCPU ID == APIC ID in AVIC kick fastpatch KVM: SVM: Add helper to perform final AVIC "kick" of single vCPU KVM: x86: Explicitly skip optimized logical map setup if vCPU's LDR==0 KVM: x86: Explicitly track all possibilities for APIC map's logical modes KVM: x86: Skip redundant x2APIC logical mode optimized cluster setup KVM: x86: Disable APIC logical map if logical ID covers multiple MDAs KVM: x86: Disable APIC logical map if vCPUs are aliased in logical mode KVM: x86: Honor architectural behavior for aliased 8-bit APIC IDs KVM: x86: Inhibit APICv/AVIC if the optimized physical map is disabled KVM: SVM: Inhibit AVIC if vCPUs are aliased in logical mode KVM: SVM: Always update local APIC on writes to logical dest register KVM: SVM: Update svm->ldr_reg cache even if LDR is "bad" KVM: SVM: Require logical ID to be power-of-2 for AVIC entry KVM: SVM: Handle multiple logical targets in AVIC kick fastpath KVM: SVM: Ignore writes to Remote Read Data on AVIC write traps Revert "KVM: SVM: Do not throw warning when calling avic_vcpu_load on a running vcpu" Suravee Suthikulpanit (1): KVM: SVM: Fix x2APIC Logical ID calculation for avic_kick_target_vcpus_fast Documentation/virt/kvm/x86/errata.rst | 11 + arch/x86/include/asm/kvm_host.h | 51 +++- arch/x86/kvm/lapic.c | 224 +++++++++++++--- arch/x86/kvm/lapic.h | 2 + arch/x86/kvm/svm/avic.c | 363 ++++++++++++-------------- arch/x86/kvm/svm/svm.c | 4 +- arch/x86/kvm/svm/svm.h | 11 +- arch/x86/kvm/vmx/vmx.c | 36 +-- arch/x86/kvm/x86.c | 7 + 9 files changed, 426 insertions(+), 283 deletions(-) base-commit: 372d07084593dc7a399bf9bee815711b1fb1bcf2 -- 2.37.3.968.ga6b4b080e4-goog