* [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native
@ 2022-09-21 8:03 kai.kang
2022-09-21 9:08 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: kai.kang @ 2022-09-21 8:03 UTC (permalink / raw)
To: raj.khem; +Cc: martin.jansa, openembedded-core
From: Kai Kang <kai.kang@windriver.com>
0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch is not
required by target mesa any more. But it still fails to compile
mesa-native with DEBUG_BUILD enabled on Ubuntu 18.04 with gcc 7.5.0
without this patch:
| ../mesa-22.1.6/src/compiler/nir/nir_inline_helpers.h: In function ‘nir_opt_move_block’:
| ../mesa-22.1.6/src/compiler/nir/nir_opt_move.c:55:1: error: inlining failed in call to
always_inline ‘src_is_ssa’: indirect function call with a yet undetermined callee
| src_is_ssa(nir_src *src, void *state)
| ^~~~~~~~~~
So only apply it for mesa-native.
Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
v2:
* add comment
meta/recipes-graphics/mesa/mesa.inc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index ea7ed4fd27..913aec987d 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -22,9 +22,11 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
file://0001-util-format-Check-for-NEON-before-using-it.patch \
file://0001-Revert-egl-wayland-deprecate-drm_handle_format-and-d.patch \
file://0001-swrast_kms-use-swkmsDRI2Extension-instead-of-driDRI2.patch \
- file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch \
"
+# required by mesa-native on Ubuntu 18.04 with gcc 7.5 when DEBUG_BUILD enabled
+SRC_URI:append:class-native = " file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
+
SRC_URI[sha256sum] = "22ced061eb9adab8ea35368246c1995c09723f3f71653cd5050c5cec376e671a"
UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native
2022-09-21 8:03 [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native kai.kang
@ 2022-09-21 9:08 ` Richard Purdie
2022-09-29 9:20 ` Kai
0 siblings, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2022-09-21 9:08 UTC (permalink / raw)
To: kai, raj.khem; +Cc: martin.jansa, openembedded-core
On Wed, 2022-09-21 at 16:03 +0800, kai wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> 0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch is not
> required by target mesa any more. But it still fails to compile
> mesa-native with DEBUG_BUILD enabled on Ubuntu 18.04 with gcc 7.5.0
> without this patch:
>
> > ../mesa-22.1.6/src/compiler/nir/nir_inline_helpers.h: In function ‘nir_opt_move_block’:
> > ../mesa-22.1.6/src/compiler/nir/nir_opt_move.c:55:1: error: inlining failed in call to
> always_inline ‘src_is_ssa’: indirect function call with a yet undetermined callee
> > src_is_ssa(nir_src *src, void *state)
> > ^~~~~~~~~~
>
> So only apply it for mesa-native.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
> v2:
> * add comment
>
> meta/recipes-graphics/mesa/mesa.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> index ea7ed4fd27..913aec987d 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -22,9 +22,11 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
> file://0001-util-format-Check-for-NEON-before-using-it.patch \
> file://0001-Revert-egl-wayland-deprecate-drm_handle_format-and-d.patch \
> file://0001-swrast_kms-use-swkmsDRI2Extension-instead-of-driDRI2.patch \
> - file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch \
> "
>
> +# required by mesa-native on Ubuntu 18.04 with gcc 7.5 when DEBUG_BUILD enabled
> +SRC_URI:append:class-native = " file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
> +
> SRC_URI[sha256sum] = "22ced061eb9adab8ea35368246c1995c09723f3f71653cd5050c5cec376e671a"
>
> UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
This still generates warnings for musl builds, e.g.:
https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5882/steps/11/logs/warnings
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native
2022-09-21 9:08 ` [OE-core] " Richard Purdie
@ 2022-09-29 9:20 ` Kai
2022-09-29 22:15 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Kai @ 2022-09-29 9:20 UTC (permalink / raw)
To: Richard Purdie, raj.khem; +Cc: martin.jansa, openembedded-core
On 9/21/22 17:08, Richard Purdie wrote:
> On Wed, 2022-09-21 at 16:03 +0800, kai wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> 0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch is not
>> required by target mesa any more. But it still fails to compile
>> mesa-native with DEBUG_BUILD enabled on Ubuntu 18.04 with gcc 7.5.0
>> without this patch:
>>
>>> ../mesa-22.1.6/src/compiler/nir/nir_inline_helpers.h: In function ‘nir_opt_move_block’:
>>> ../mesa-22.1.6/src/compiler/nir/nir_opt_move.c:55:1: error: inlining failed in call to
>> always_inline ‘src_is_ssa’: indirect function call with a yet undetermined callee
>>> src_is_ssa(nir_src *src, void *state)
>>> ^~~~~~~~~~
>> So only apply it for mesa-native.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> v2:
>> * add comment
>>
>> meta/recipes-graphics/mesa/mesa.inc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
>> index ea7ed4fd27..913aec987d 100644
>> --- a/meta/recipes-graphics/mesa/mesa.inc
>> +++ b/meta/recipes-graphics/mesa/mesa.inc
>> @@ -22,9 +22,11 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
>> file://0001-util-format-Check-for-NEON-before-using-it.patch \
>> file://0001-Revert-egl-wayland-deprecate-drm_handle_format-and-d.patch \
>> file://0001-swrast_kms-use-swkmsDRI2Extension-instead-of-driDRI2.patch \
>> - file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch \
>> "
>>
>> +# required by mesa-native on Ubuntu 18.04 with gcc 7.5 when DEBUG_BUILD enabled
>> +SRC_URI:append:class-native = " file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
>> +
>> SRC_URI[sha256sum] = "22ced061eb9adab8ea35368246c1995c09723f3f71653cd5050c5cec376e671a"
>>
>> UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
> This still generates warnings for musl builds, e.g.:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5882/steps/11/logs/warnings
Hi Richard,
The warnings are related with binutils but not mesa. Would you like to
review it again, please?
Thanks,
Kai
>
> Cheers,
>
> Richard
>
--
Kai Kang
Wind River Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native
2022-09-29 9:20 ` Kai
@ 2022-09-29 22:15 ` Alexandre Belloni
2022-09-30 1:32 ` Kai
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2022-09-29 22:15 UTC (permalink / raw)
To: kai; +Cc: Richard Purdie, raj.khem, martin.jansa, openembedded-core
Hello,
On 29/09/2022 17:20:52+0800, kai wrote:
> On 9/21/22 17:08, Richard Purdie wrote:
> > On Wed, 2022-09-21 at 16:03 +0800, kai wrote:
> > > From: Kai Kang <kai.kang@windriver.com>
> > >
> > > 0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch is not
> > > required by target mesa any more. But it still fails to compile
> > > mesa-native with DEBUG_BUILD enabled on Ubuntu 18.04 with gcc 7.5.0
> > > without this patch:
> > >
> > > > ../mesa-22.1.6/src/compiler/nir/nir_inline_helpers.h: In function ‘nir_opt_move_block’:
> > > > ../mesa-22.1.6/src/compiler/nir/nir_opt_move.c:55:1: error: inlining failed in call to
> > > always_inline ‘src_is_ssa’: indirect function call with a yet undetermined callee
> > > > src_is_ssa(nir_src *src, void *state)
> > > > ^~~~~~~~~~
> > > So only apply it for mesa-native.
> > >
> > > Signed-off-by: Kai Kang <kai.kang@windriver.com>
> > > ---
> > > v2:
> > > * add comment
> > >
> > > meta/recipes-graphics/mesa/mesa.inc | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> > > index ea7ed4fd27..913aec987d 100644
> > > --- a/meta/recipes-graphics/mesa/mesa.inc
> > > +++ b/meta/recipes-graphics/mesa/mesa.inc
> > > @@ -22,9 +22,11 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
> > > file://0001-util-format-Check-for-NEON-before-using-it.patch \
> > > file://0001-Revert-egl-wayland-deprecate-drm_handle_format-and-d.patch \
> > > file://0001-swrast_kms-use-swkmsDRI2Extension-instead-of-driDRI2.patch \
> > > - file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch \
> > > "
> > > +# required by mesa-native on Ubuntu 18.04 with gcc 7.5 when DEBUG_BUILD enabled
> > > +SRC_URI:append:class-native = " file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
> > > +
> > > SRC_URI[sha256sum] = "22ced061eb9adab8ea35368246c1995c09723f3f71653cd5050c5cec376e671a"
> > > UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
> > This still generates warnings for musl builds, e.g.:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5882/steps/11/logs/warnings
>
> Hi Richard,
>
> The warnings are related with binutils but not mesa. Would you like to
> review it again, please?
>
Sure, but it doesn't apply on master anymore, could you rebase please?
> Thanks,
> Kai
>
> >
> > Cheers,
> >
> > Richard
> >
>
> --
> Kai Kang
> Wind River Linux
>
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native
2022-09-29 22:15 ` Alexandre Belloni
@ 2022-09-30 1:32 ` Kai
0 siblings, 0 replies; 5+ messages in thread
From: Kai @ 2022-09-30 1:32 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Richard Purdie, raj.khem, martin.jansa, openembedded-core
On 9/30/22 06:15, Alexandre Belloni wrote:
> Hello,
>
> On 29/09/2022 17:20:52+0800, kai wrote:
>> On 9/21/22 17:08, Richard Purdie wrote:
>>> On Wed, 2022-09-21 at 16:03 +0800, kai wrote:
>>>> From: Kai Kang <kai.kang@windriver.com>
>>>>
>>>> 0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch is not
>>>> required by target mesa any more. But it still fails to compile
>>>> mesa-native with DEBUG_BUILD enabled on Ubuntu 18.04 with gcc 7.5.0
>>>> without this patch:
>>>>
>>>>> ../mesa-22.1.6/src/compiler/nir/nir_inline_helpers.h: In function ‘nir_opt_move_block’:
>>>>> ../mesa-22.1.6/src/compiler/nir/nir_opt_move.c:55:1: error: inlining failed in call to
>>>> always_inline ‘src_is_ssa’: indirect function call with a yet undetermined callee
>>>>> src_is_ssa(nir_src *src, void *state)
>>>>> ^~~~~~~~~~
>>>> So only apply it for mesa-native.
>>>>
>>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>>> ---
>>>> v2:
>>>> * add comment
>>>>
>>>> meta/recipes-graphics/mesa/mesa.inc | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
>>>> index ea7ed4fd27..913aec987d 100644
>>>> --- a/meta/recipes-graphics/mesa/mesa.inc
>>>> +++ b/meta/recipes-graphics/mesa/mesa.inc
>>>> @@ -22,9 +22,11 @@ SRC_URI = "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
>>>> file://0001-util-format-Check-for-NEON-before-using-it.patch \
>>>> file://0001-Revert-egl-wayland-deprecate-drm_handle_format-and-d.patch \
>>>> file://0001-swrast_kms-use-swkmsDRI2Extension-instead-of-driDRI2.patch \
>>>> - file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch \
>>>> "
>>>> +# required by mesa-native on Ubuntu 18.04 with gcc 7.5 when DEBUG_BUILD enabled
>>>> +SRC_URI:append:class-native = " file://0001-nir-nir_opt_move-fix-ALWAYS_INLINE-compiler-error.patch"
>>>> +
>>>> SRC_URI[sha256sum] = "22ced061eb9adab8ea35368246c1995c09723f3f71653cd5050c5cec376e671a"
>>>> UPSTREAM_CHECK_GITTAGREGEX = "mesa-(?P<pver>\d+(\.\d+)+)"
>>> This still generates warnings for musl builds, e.g.:
>>>
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5882/steps/11/logs/warnings
>> Hi Richard,
>>
>> The warnings are related with binutils but not mesa. Would you like to
>> review it again, please?
>>
> Sure, but it doesn't apply on master anymore, could you rebase please?
OK.
Kai
>
>> Thanks,
>> Kai
>>
>>> Cheers,
>>>
>>> Richard
>>>
>> --
>> Kai Kang
>> Wind River Linux
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#171178): https://lists.openembedded.org/g/openembedded-core/message/171178
>> Mute This Topic: https://lists.openembedded.org/mt/93821960/3617179
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>
--
Kai Kang
Wind River Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-30 1:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 8:03 [PATCH v2] mesa: only apply patch to fix ALWAYS_INLINE for native kai.kang
2022-09-21 9:08 ` [OE-core] " Richard Purdie
2022-09-29 9:20 ` Kai
2022-09-29 22:15 ` Alexandre Belloni
2022-09-30 1:32 ` Kai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.