All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: <netdev@vger.kernel.org>
Cc: <f.fainelli@gmail.com>, <andrew@lunn.ch>,
	<vivien.didelot@gmail.com>, <olteanv@gmail.com>,
	<kurt@linutronix.de>, <hauke@hauke-m.de>,
	<Woojung.Huh@microchip.com>, <sean.wang@mediatek.com>,
	<linus.walleij@linaro.org>, <clement.leger@bootlin.com>,
	<george.mccollister@gmail.com>
Subject: [PATCH net-next 14/18] net: dsa: realtek: remove unnecessary set_drvdata()
Date: Wed, 21 Sep 2022 22:05:20 +0800	[thread overview]
Message-ID: <20220921140524.3831101-15-yangyingliang@huawei.com> (raw)
In-Reply-To: <20220921140524.3831101-1-yangyingliang@huawei.com>

Remove unnecessary set_drvdata(NULL) function in ->remove(),
the driver_data will be set to NULL in device_unbind_cleanup()
after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/dsa/realtek/realtek-mdio.c | 2 --
 drivers/net/dsa/realtek/realtek-smi.c  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
index c58f49d558d2..3e54fac5f902 100644
--- a/drivers/net/dsa/realtek/realtek-mdio.c
+++ b/drivers/net/dsa/realtek/realtek-mdio.c
@@ -245,8 +245,6 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev)
 	/* leave the device reset asserted */
 	if (priv->reset)
 		gpiod_set_value(priv->reset, 1);
-
-	dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static void realtek_mdio_shutdown(struct mdio_device *mdiodev)
diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
index 45992f79ec8d..1b447d96b9c4 100644
--- a/drivers/net/dsa/realtek/realtek-smi.c
+++ b/drivers/net/dsa/realtek/realtek-smi.c
@@ -522,8 +522,6 @@ static int realtek_smi_remove(struct platform_device *pdev)
 	if (priv->reset)
 		gpiod_set_value(priv->reset, 1);
 
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }
 
-- 
2.25.1


  parent reply	other threads:[~2022-09-21 13:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 14:05 [PATCH net-next 00/18] net: dsa: remove unnecessary set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 01/18] net: dsa: b53: " Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 02/18] net: dsa: bcm_sf2: remove unnecessary platform_set_drvdata() Yang Yingliang
2022-09-22 18:20   ` Florian Fainelli
2022-09-21 14:05 ` [PATCH net-next 03/18] net: dsa: loop: remove unnecessary dev_set_drvdata() Yang Yingliang
2022-09-22 18:20   ` Florian Fainelli
2022-09-21 14:05 ` [PATCH net-next 04/18] net: dsa: hellcreek: remove unnecessary platform_set_drvdata() Yang Yingliang
2022-09-22  6:23   ` Kurt Kanzenbach
2022-09-21 14:05 ` [PATCH net-next 05/18] net: dsa: lan9303: remove unnecessary dev_set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 06/18] net: dsa: lantiq_gswip: remove unnecessary platform_set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 07/18] net: dsa: microchip: remove unnecessary set_drvdata() Yang Yingliang
2022-09-22 14:12   ` [PATCH 7/18] " Arun.Ramadoss
2022-09-22 14:40     ` Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 08/18] net: dsa: mt7530: remove unnecessary dev_set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 09/18] net: dsa: mv88e6060: " Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 10/18] net: dsa: mv88e6xxx: " Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 11/18] net: dsa: ocelot: remove unnecessary set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 12/18] net: dsa: ar9331: remove unnecessary dev_set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 13/18] net: dsa: qca8k: " Yang Yingliang
2022-09-21 14:05 ` Yang Yingliang [this message]
2022-09-21 21:59   ` [PATCH net-next 14/18] net: dsa: realtek: remove unnecessary set_drvdata() Alvin Šipraga
2022-09-21 22:21   ` Linus Walleij
2022-09-21 14:05 ` [PATCH net-next 15/18] net: dsa: rzn1-a5psw: remove unnecessary platform_set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 16/18] net: dsa: sja1105: remove unnecessary spi_set_drvdata() Yang Yingliang
2022-09-21 14:05 ` [PATCH net-next 17/18] net: dsa: vitesse-vsc73xx: remove unnecessary set_drvdata() Yang Yingliang
2022-09-22 13:17   ` Linus Walleij
2022-09-21 14:05 ` [PATCH net-next 18/18] net: dsa: xrs700x: remove unnecessary dev_set_drvdata() Yang Yingliang
2022-09-23  2:40 ` [PATCH net-next 00/18] net: dsa: remove unnecessary set_drvdata() patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921140524.3831101-15-yangyingliang@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=clement.leger@bootlin.com \
    --cc=f.fainelli@gmail.com \
    --cc=george.mccollister@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=kurt@linutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=sean.wang@mediatek.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.