From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502BFC6FA82 for ; Wed, 21 Sep 2022 15:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbiIUPtR (ORCPT ); Wed, 21 Sep 2022 11:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231678AbiIUPsj (ORCPT ); Wed, 21 Sep 2022 11:48:39 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D7BE7C316; Wed, 21 Sep 2022 08:47:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16A0113D5; Wed, 21 Sep 2022 08:47:47 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A7DF3F73D; Wed, 21 Sep 2022 08:47:39 -0700 (PDT) Date: Wed, 21 Sep 2022 16:47:37 +0100 From: Sudeep Holla To: Huisong Li Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org, rafael.j.wysocki@intel.com, wanghuiqiang@huawei.com, huangdaode@huawei.com Subject: Re: [PATCH 1/2] ACPI: PCC: replace wait_for_completion() Message-ID: <20220921154737.az3d4ndxs3u3zwbl@bogus> References: <20220920094500.11283-1-lihuisong@huawei.com> <20220920094500.11283-2-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920094500.11283-2-lihuisong@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Sep 20, 2022 at 05:44:59PM +0800, Huisong Li wrote: > Currently, the function waiting for completion of mailbox operation is > 'wait_for_completion()'. The PCC method will be permanently blocked if > this mailbox message fails to execute. So this patch replaces it with > 'wait_for_completion_timeout()'. And set the timeout interval to an > arbitrary retries on top of nominal to prevent the remote processor is > slow to respond to PCC commands. > Sounds good to me. The only concern(may be not serious) is what happens if we receive response from the platform after the timeout. I have tested for that in non ACPI non PCC context. I don't have a setup to trigger that with ACPI PCC + this patch to test. Other than that, I am fine with this: Reviewed-by: Sudeep Holla -- Regards, Sudeep