All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regmap: mmio: replace return 0 with break in switch statement
@ 2022-09-22  8:04 Colin Ian King
  2022-09-22 17:54 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-09-22  8:04 UTC (permalink / raw)
  To: Mark Brown, Greg Kroah-Hartman, Rafael J . Wysocki
  Cc: kernel-janitors, linux-kernel

Variable min_stride is assigned a value that is never read, fix this by
replacing the return 0 with a break statement. This also makes the case
statement consistent with the other cases in the switch statement.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/base/regmap/regmap-mmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/regmap-mmio.c b/drivers/base/regmap/regmap-mmio.c
index 8bd8d42de3fe..3ccdd86a97e7 100644
--- a/drivers/base/regmap/regmap-mmio.c
+++ b/drivers/base/regmap/regmap-mmio.c
@@ -48,7 +48,7 @@ static int regmap_mmio_get_min_stride(size_t val_bits)
 	case 8:
 		/* The core treats 0 as 1 */
 		min_stride = 0;
-		return 0;
+		break;
 	case 16:
 		min_stride = 2;
 		break;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] regmap: mmio: replace return 0 with break in switch statement
  2022-09-22  8:04 [PATCH] regmap: mmio: replace return 0 with break in switch statement Colin Ian King
@ 2022-09-22 17:54 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-09-22 17:54 UTC (permalink / raw)
  To: Colin Ian King, Greg Kroah-Hartman, Rafael J . Wysocki
  Cc: linux-kernel, kernel-janitors

On Thu, 22 Sep 2022 09:04:45 +0100, Colin Ian King wrote:
> Variable min_stride is assigned a value that is never read, fix this by
> replacing the return 0 with a break statement. This also makes the case
> statement consistent with the other cases in the switch statement.
> 
> 

Applied to

   broonie/regmap.git for-next

Thanks!

[1/1] regmap: mmio: replace return 0 with break in switch statement
      commit: 01ed230761e51f0403b3f3845c11cb67014487e2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-22 17:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22  8:04 [PATCH] regmap: mmio: replace return 0 with break in switch statement Colin Ian King
2022-09-22 17:54 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.