From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2104C6FA82 for ; Thu, 22 Sep 2022 08:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbiIVIKy (ORCPT ); Thu, 22 Sep 2022 04:10:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbiIVIKm (ORCPT ); Thu, 22 Sep 2022 04:10:42 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0665CC8F6; Thu, 22 Sep 2022 01:10:37 -0700 (PDT) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MY7Fj0JwPzHpmF; Thu, 22 Sep 2022 16:08:25 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.63) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 16:10:35 +0800 From: Zhao Gongyi To: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 0/3] fix error when writing negative value to simple attribute files Date: Thu, 22 Sep 2022 16:06:48 +0800 Message-ID: <20220922080648.254312-1-zhaogongyi@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220919172418.45257-1-akinobu.mita@gmail.com> References: <20220919172418.45257-1-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.63] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2022 02:24:15 +0900 Akinobu Mita wrote: > The simple attribute files do not accept a negative value since the > commit 488dac0c9237 ("libfs: fix error cast of negative value in > simple_attr_write()"), but some attribute files want to accept > a negative value. > > Akinobu Mita (3): > libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value > lib/notifier-error-inject: fix error when writing -errno to debugfs > file > debugfs: fix error when writing negative value to atomic_t debugfs > file > > .../fault-injection/fault-injection.rst | 10 +++---- > fs/debugfs/file.c | 28 +++++++++++++++---- > fs/libfs.c | 22 +++++++++++++-- > include/linux/debugfs.h | 19 +++++++++++-- > include/linux/fs.h | 12 ++++++-- > lib/notifier-error-inject.c | 2 +- > 6 files changed, 73 insertions(+), 20 deletions(-) I have tested this version, it is ok. Tested-by: Zhao Gongyi