All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, netdev@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>,
	UNGLinuxDriver@microchip.com,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Lee Jones <lee@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Vladimir Oltean <olteanv@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 08/14] net: dsa: felix: update init_regmap to be string-based
Date: Thu, 22 Sep 2022 19:40:09 -0700	[thread overview]
Message-ID: <20220922194009.276371fc@kernel.org> (raw)
In-Reply-To: <20220922193906.7ab18960@kernel.org>

On Thu, 22 Sep 2022 19:39:06 -0700 Jakub Kicinski wrote:
> On Wed, 21 Sep 2022 21:00:56 -0700 Colin Foster wrote:
> > During development, it was believed that a wrapper for ocelot_regmap_init()
> > would be sufficient for the felix driver to work in non-mmio scenarios.
> > This was merged in during commit 242bd0c10bbd ("net: dsa: ocelot: felix:
> > add interface for custom regmaps")
> > 
> > As the external ocelot DSA driver grew closer to an acceptable state, it
> > was realized that most of the parameters that were passed in from struct
> > resource *res were useless and ignored. This is due to the fact that the
> > external ocelot DSA driver utilizes dev_get_regmap(dev, resource->name).
> > 
> > Instead of simply ignoring those parameters, refactor the API to only
> > require the name as an argument. MMIO scenarios this will reconstruct the
> > struct resource before calling ocelot_regmap_init(ocelot, resource). MFD
> > scenarios need only call dev_get_regmap(dev, name).

Ah, and the modpost:

ERROR: modpost: drivers/net/dsa/ocelot/mscc_seville: 'felix_init_regmap' exported twice. Previous export was in drivers/net/dsa/ocelot/mscc_felix.ko

  reply	other threads:[~2022-09-23  2:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  4:00 [PATCH v2 net-next 00/14] add support for the the vsc7512 internal copper phys Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 01/14] net: mscc: ocelot: expose ocelot wm functions Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 02/14] net: mscc: ocelot: expose regfield definition to be used by other drivers Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 03/14] net: mscc: ocelot: expose stats layout " Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 04/14] net: mscc: ocelot: expose vcap_props structure Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 05/14] net: mscc: ocelot: expose ocelot_reset routine Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 06/14] net: dsa: felix: add configurable device quirks Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 07/14] net: dsa: felix: populate mac_capabilities for all ports Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 08/14] net: dsa: felix: update init_regmap to be string-based Colin Foster
2022-09-23  2:39   ` Jakub Kicinski
2022-09-23  2:40     ` Jakub Kicinski [this message]
2022-09-23 15:53       ` Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 09/14] pinctrl: ocelot: avoid macro redefinition Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 10/14] mfd: ocelot: prepend resource size macros to be 32-bit Colin Foster
2022-09-22  4:00 ` [PATCH v2 net-next 11/14] mfd: ocelot: add regmaps for ocelot_ext Colin Foster
2022-09-22  4:01 ` [PATCH v2 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation Colin Foster
2022-09-23 18:08   ` Krzysztof Kozlowski
2022-09-23 18:18     ` Colin Foster
2022-09-23 18:31       ` Krzysztof Kozlowski
2022-09-22  4:01 ` [PATCH v2 net-next 13/14] net: dsa: ocelot: add external ocelot switch control Colin Foster
2022-09-22  4:01 ` [PATCH v2 net-next 14/14] mfd: " Colin Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922194009.276371fc@kernel.org \
    --to=kuba@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=colin.foster@in-advantage.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.