All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: markyacoub@google.com
Subject: [igt-dev] [PATCH] tests/kms_plane_cursor: update pipe to output for each test
Date: Thu, 22 Sep 2022 19:28:19 -0600	[thread overview]
Message-ID: <20220923012819.4174059-1-alex.hung@amd.com> (raw)

Pipe/pipe_id changes during test executions, and it
needs updating in test_cursor.

Resolved input/output error when reading CRC:

Test assertion failure function igt_pipe_crc_start ...
Failed assertion: pipe_crc->crc_fd != -1
Last errno: 5, Input/output error

Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 tests/kms_plane_cursor.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 6b7e5cef..d29dc327 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -87,8 +87,6 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe_id,
 					  INTEL_PIPE_CRC_SOURCE_AUTO);
 
-	igt_output_set_pipe(data->output, data->pipe_id);
-
 	/* Overlay rectangle for a rect in the center of the screen */
 	data->or.x = data->mode->hdisplay / 4;
 	data->or.y = data->mode->vdisplay / 4;
@@ -244,6 +242,7 @@ static void test_cursor(data_t *data, int size, unsigned int flags)
 			    1.0, 0.0, 1.0, &data->cfb);
 
 	igt_plane_set_fb(data->primary, &data->pfb);
+	igt_output_set_pipe(data->output, data->pipe_id);
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	test_cursor_spots(data, size, flags);
-- 
2.34.1

             reply	other threads:[~2022-09-23  1:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  1:28 Alex Hung [this message]
2022-09-23  2:33 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_cursor: update pipe to output for each test Patchwork
2022-09-23 11:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-23 15:27 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_plane_cursor: update pipe to output for each test (rev2) Patchwork
2022-09-23 15:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-09-24  5:06 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-26 15:28 ` [igt-dev] [PATCH] tests/kms_plane_cursor: update pipe to output for each test Mark Yacoub
2022-09-26 17:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_cursor: update pipe to output for each test (rev2) Patchwork
2022-09-26 18:47 ` Patchwork
2022-09-27 14:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923012819.4174059-1-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=markyacoub@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.