From: kernel test robot <lkp@intel.com>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Wolfram Sang <wsa-dev@sang-engineering.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
loongarch@lists.linux.dev, linux-acpi@vger.kernel.org,
WANG Xuerui <kernel@xen0n.name>,
Jianmin Lv <lvjianmin@loongson.cn>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH 1/5] i2c: core: Pick i2c bus number from ACPI if present
Date: Fri, 23 Sep 2022 02:58:59 +0800 [thread overview]
Message-ID: <202209230228.LIiHRmuw-lkp@intel.com> (raw)
In-Reply-To: <be5cd69c7c58d44ca119d4ca692d95a2ae924533.1663835855.git.zhoubinbin@loongson.cn>
Hi Binbin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linus/master v6.0-rc6 next-20220921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/i2c-ls2x-Add-support-for-the-Loongson-2K-LS7A-I2C/20220922-194252
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: hexagon-randconfig-r041-20220922 (https://download.01.org/0day-ci/archive/20220923/202209230228.LIiHRmuw-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/749fc796eb66dc42c209c6a5808c6b2a5e47fbb6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Binbin-Zhou/i2c-ls2x-Add-support-for-the-Loongson-2K-LS7A-I2C/20220922-194252
git checkout 749fc796eb66dc42c209c6a5808c6b2a5e47fbb6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/i2c/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/i2c/i2c-core-base.c:1568:12: error: call to undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
status = acpi_evaluate_integer(ACPI_HANDLE(dev->parent),
^
drivers/i2c/i2c-core-base.c:1568:12: note: did you mean 'acpi_evaluate_object'?
include/acpi/acpixf.h:550:8: note: 'acpi_evaluate_object' declared here
acpi_evaluate_object(acpi_handle object,
^
include/acpi/platform/aclinux.h:93:21: note: expanded from macro 'ACPI_EXTERNAL_RETURN_STATUS'
static ACPI_INLINE prototype {return(AE_NOT_CONFIGURED);}
^
1 error generated.
vim +/acpi_evaluate_integer +1568 drivers/i2c/i2c-core-base.c
1540
1541 /**
1542 * i2c_add_adapter - declare i2c adapter, use dynamic bus number
1543 * @adapter: the adapter to add
1544 * Context: can sleep
1545 *
1546 * This routine is used to declare an I2C adapter when its bus number
1547 * doesn't matter or when its bus number is specified by an dt alias.
1548 * Examples of bases when the bus number doesn't matter: I2C adapters
1549 * dynamically added by USB links or PCI plugin cards.
1550 *
1551 * When this returns zero, a new bus number was allocated and stored
1552 * in adap->nr, and the specified adapter became available for clients.
1553 * Otherwise, a negative errno value is returned.
1554 */
1555 int i2c_add_adapter(struct i2c_adapter *adapter)
1556 {
1557 struct device *dev = &adapter->dev;
1558 acpi_status status;
1559 unsigned long long id;
1560
1561 if (dev->of_node) {
1562 id = of_alias_get_id(dev->of_node, "i2c");
1563 if (id >= 0) {
1564 adapter->nr = id;
1565 return __i2c_add_numbered_adapter(adapter);
1566 }
1567 } else if (dev->parent->fwnode) {
> 1568 status = acpi_evaluate_integer(ACPI_HANDLE(dev->parent),
1569 "_UID", NULL, &id);
1570 if (ACPI_SUCCESS(status) && (id >= 0)) {
1571 adapter->nr = id;
1572 return __i2c_add_numbered_adapter(adapter);
1573 }
1574 }
1575
1576 mutex_lock(&core_lock);
1577 id = idr_alloc(&i2c_adapter_idr, adapter,
1578 __i2c_first_dynamic_bus_num, 0, GFP_KERNEL);
1579 mutex_unlock(&core_lock);
1580 if (WARN(id < 0, "couldn't get idr"))
1581 return id;
1582
1583 adapter->nr = id;
1584
1585 return i2c_register_adapter(adapter);
1586 }
1587 EXPORT_SYMBOL(i2c_add_adapter);
1588
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-22 18:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 11:39 [PATCH 0/5] i2c: ls2x: Add support for the Loongson-2K/LS7A I2C Binbin Zhou
2022-09-22 11:39 ` [PATCH 1/5] i2c: core: Pick i2c bus number from ACPI if present Binbin Zhou
2022-09-22 12:23 ` Mika Westerberg
2022-09-23 7:16 ` Huacai Chen
2022-09-23 8:55 ` Mika Westerberg
2022-09-22 12:29 ` Jinyang He
2022-09-22 18:48 ` kernel test robot
2022-09-22 18:58 ` kernel test robot [this message]
2022-09-26 6:02 ` kernel test robot
2022-09-22 11:39 ` [PATCH 2/5] i2c: gpio: Add support on ACPI-based system Binbin Zhou
2022-09-22 12:26 ` Mika Westerberg
2022-09-23 10:01 ` Binbin Zhou
2022-09-23 10:15 ` Mika Westerberg
2022-09-22 17:57 ` kernel test robot
2022-09-22 20:10 ` kernel test robot
2022-09-26 6:02 ` kernel test robot
2022-09-22 11:39 ` [PATCH 3/5] dt-bindings: i2c: add bindings for Loongson LS2X I2C Binbin Zhou
2022-09-22 11:39 ` [PATCH 4/5] i2c: Add driver for Loongson-2K/LS7A I2C controller Binbin Zhou
2022-09-23 2:26 ` kernel test robot
2022-09-22 11:39 ` [PATCH 5/5] LoongArch: Enable LS2X I2C in loongson3_defconfig Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209230228.LIiHRmuw-lkp@intel.com \
--to=lkp@intel.com \
--cc=chenhuacai@loongson.cn \
--cc=kbuild-all@lists.01.org \
--cc=kernel@xen0n.name \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa-dev@sang-engineering.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.