All of lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org,
	Lionel G Landwerlin <lionel.g.landwerlin@intel.com>,
	Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: [igt-dev] [PATCH i-g-t v4 16/17] lib/i915/perf: make warning message more helpful
Date: Fri, 23 Sep 2022 19:52:23 +0000	[thread overview]
Message-ID: <20220923195224.283045-17-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20220923195224.283045-1-umesh.nerlige.ramappa@intel.com>

From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

This helped debugging some XEHPSDV stuff but is also more readable.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 lib/i915/perf-configs/mdapi-xml-convert.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/lib/i915/perf-configs/mdapi-xml-convert.py b/lib/i915/perf-configs/mdapi-xml-convert.py
index f27d6657..1d161674 100755
--- a/lib/i915/perf-configs/mdapi-xml-convert.py
+++ b/lib/i915/perf-configs/mdapi-xml-convert.py
@@ -884,10 +884,15 @@ for arg in args.xml:
             # delta equations are expected to be identical so warn if that's
             # not true...
             if bool(raw_read_eq) ^ bool(delta_read_eq) or raw_read_eq != delta_read_eq:
-                print_err("WARNING: Inconsistent raw and delta report equations for " + \
-                          mdapi_set.get('ShortName') + " :: " + mdapi_counter.get('SymbolName') + \
-                          "(" + mdapi_counter.get('ShortName') + ")" + ": raw=\"" + str(raw_read_eq) + \
-                          "\" delta=\"" + str(delta_read_eq) + "\" (SKIPPING)")
+                print_err(("WARNING: Inconsistent raw and delta report equations for {0} :: {1} ({2}): " +
+                           "raw=\"{3}\" / \"{4}\" delta=\"{5}\" / \"{6}\" (SKIPPING)")
+                          .format(mdapi_set.get('ShortName'),
+                                  mdapi_counter.get('SymbolName'),
+                                  mdapi_counter.get('ShortName'),
+                                  str(raw_read_eq),
+                                  mdapi_counter.get('SnapshotReportReadEquation'),
+                                  str(delta_read_eq),
+                                  mdapi_counter.get('DeltaReportReadEquation')))
                 set.remove(counter)
                 continue
 
-- 
2.25.1

  parent reply	other threads:[~2022-09-23 19:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 19:52 [igt-dev] [PATCH i-g-t v4 00/17] Add DG2 OA test Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 01/17] i915/perf: Check regularly if we are done reading reports Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 02/17] i915/perf: Fix OA short_reads test Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 03/17] i915/perf: Check return value from getparam Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 04/17] i915/perf: Limit sseu-config tests for gen11 Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 05/17] i915/perf: Account for OA sampling interval in polling test Umesh Nerlige Ramappa
2022-09-28  7:52   ` Lionel Landwerlin
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 06/17] i915/perf: Define OA report types and fix oa-formats test Umesh Nerlige Ramappa
2022-09-28  7:50   ` Lionel Landwerlin
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 07/17] i915/perf: Use ARRAY_SIZE consistently for num_properties Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 08/17] i915/perf: Use gt in perf tests and lib Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 09/17] i915/perf: Explicitly state rendercopy needs for a test Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 10/17] i915/perf: Skip tests that use rendercopy Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 11/17] i915/perf: Add OA formats for DG2 Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 12/17] i915/perf: Fix CS timestamp vs OA timstamp mismatch Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 13/17] i915/perf: Wait longer for rc6 residency in DG2 Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 14/17] lib/i915/perf: implement report accumulation for new format Umesh Nerlige Ramappa
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 15/17] lib/i915/perf: fixup conversion script for XEHPSDV Umesh Nerlige Ramappa
2022-09-23 19:52 ` Umesh Nerlige Ramappa [this message]
2022-09-23 19:52 ` [igt-dev] [PATCH i-g-t v4 17/17] lib/i915/perf: Add DG2 metrics Umesh Nerlige Ramappa
2022-09-23 20:31 ` [igt-dev] ✓ Fi.CI.BAT: success for Add DG2 OA test (rev5) Patchwork
2022-09-24 11:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923195224.283045-17-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.