All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-scsi@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Bart Van Assche <bvanassche@acm.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Bean Huo <beanhuo@micron.com>, Avri Altman <avri.altman@wdc.com>,
	Jinyoung Choi <j-young.choi@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Peter Wang <peter.wang@mediatek.com>,
	Eric Biggers <ebiggers@google.com>,
	jongmin jeong <jjmin.jeong@samsung.com>
Subject: [PATCH 7/8] scsi: ufs: Add a PM notifier
Date: Fri, 23 Sep 2022 13:11:37 -0700	[thread overview]
Message-ID: <20220923201138.2113123-8-bvanassche@acm.org> (raw)
In-Reply-To: <20220923201138.2113123-1-bvanassche@acm.org>

Add a PM notifier to track whether or not the system is suspending. This
information will be used in a later patch to fix a deadlock between the
SCSI error handler and the suspend code.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/ufs/core/ufshcd.c | 24 ++++++++++++++++++++++++
 include/ufs/ufshcd.h      |  7 ++++++-
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index d7453f788d0d..abeb120b12eb 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -9246,6 +9246,25 @@ static int ufshcd_wl_runtime_resume(struct device *dev)
 }
 #endif
 
+static int ufshcd_pm_cb(struct notifier_block *nb, unsigned long action,
+			void *data)
+{
+	struct ufs_hba *hba = container_of(nb, typeof(*hba), pm_nb);
+
+	switch (action) {
+	case PM_HIBERNATION_PREPARE:
+	case PM_SUSPEND_PREPARE:
+		hba->system_suspending = true;
+		break;
+	case PM_POST_RESTORE:
+	case PM_POST_SUSPEND:
+		hba->system_suspending = false;
+		break;
+	}
+
+	return 0;
+}
+
 #ifdef CONFIG_PM_SLEEP
 static int ufshcd_wl_suspend(struct device *dev)
 {
@@ -9534,6 +9553,7 @@ EXPORT_SYMBOL(ufshcd_shutdown);
  */
 void ufshcd_remove(struct ufs_hba *hba)
 {
+	unregister_pm_notifier(&hba->pm_nb);
 	if (hba->ufs_device_wlun)
 		ufshcd_rpm_get_sync(hba);
 	ufs_hwmon_remove(hba);
@@ -9832,7 +9852,11 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
 	async_schedule(ufshcd_async_scan, hba);
 	ufs_sysfs_add_nodes(hba->dev);
 
+	hba->pm_nb = (struct notifier_block){ .notifier_call = ufshcd_pm_cb };
+	register_pm_notifier(&hba->pm_nb);
+
 	device_enable_async_suspend(dev);
+
 	return 0;
 
 free_tmf_queue:
diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 24c97e0772bb..9bc48c13006f 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -802,7 +802,10 @@ struct ufs_hba_monitor {
  * @caps: bitmask with information about UFS controller capabilities
  * @devfreq: frequency scaling information owned by the devfreq core
  * @clk_scaling: frequency scaling information owned by the UFS driver
- * @is_sys_suspended: whether or not the entire system has been suspended
+ * @system_suspending: system suspend has been started and system resume has
+ *	not yet finished.
+ * @is_sys_suspended: UFS device has been suspended because of system suspend
+ * @pm_nb: power management notifier block
  * @urgent_bkops_lvl: keeps track of urgent bkops level for device
  * @is_urgent_bkops_lvl_checked: keeps track if the urgent bkops level for
  *  device is known or not.
@@ -943,7 +946,9 @@ struct ufs_hba {
 
 	struct devfreq *devfreq;
 	struct ufs_clk_scaling clk_scaling;
+	bool system_suspending;
 	bool is_sys_suspended;
+	struct notifier_block pm_nb;
 
 	enum bkops_status urgent_bkops_lvl;
 	bool is_urgent_bkops_lvl_checked;

  parent reply	other threads:[~2022-09-23 20:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 20:11 [PATCH 0/8] Fix a deadlock in the UFS driver Bart Van Assche
2022-09-23 20:11 ` [PATCH 1/8] scsi: core: Fix a race between scsi_done() and scsi_times_out() Bart Van Assche
2022-09-23 20:11 ` [PATCH 2/8] scsi: core: Change the return type of .eh_timed_out() Bart Van Assche
2022-09-24  2:10   ` kernel test robot
2022-09-23 20:11 ` [PATCH 3/8] scsi: ufs: Remove an outdated comment Bart Van Assche
2022-09-23 20:11 ` [PATCH 4/8] scsi: ufs: Use 'else' in ufshcd_set_dev_pwr_mode() Bart Van Assche
2022-09-23 20:11 ` [PATCH 5/8] scsi: ufs: Try harder to change the power mode Bart Van Assche
2022-09-27 10:41   ` Avri Altman
2022-09-27 16:44     ` Bart Van Assche
2022-09-23 20:11 ` [PATCH 6/8] scsi: ufs: Split ufshcd_err_handler() Bart Van Assche
2022-09-23 20:11 ` Bart Van Assche [this message]
2022-09-23 20:11 ` [PATCH 8/8] scsi: ufs: Fix deadlock between power management and error handler Bart Van Assche
2022-09-24 15:06   ` kernel test robot
2022-09-27 17:06   ` Adrian Hunter
2022-09-27 17:54     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923201138.2113123-8-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=ebiggers@google.com \
    --cc=j-young.choi@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=jjmin.jeong@samsung.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.