From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED18BC07E9D for ; Sat, 24 Sep 2022 02:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mul9w/hpg9NCDXd8kHFPLFzWoP5dGurm9oLzNh0wLfI=; b=n/lTs2kv26Us6Y bQyuBr1u9bY0Ck1ly8+4Qgg7yW+o1zBC+ZQKZp46JH8EhabeakouTSKHmrC+xhw81OnQzZMGbWPpD BRJ9xE4iyIbS3PTmuAKrCP20O+fZ5mFjbRNfN35zLYoCrM+slXnKoBbaX5QJacPDMMpRi3KBnryh3 6KSIXohCi//8ImXtLp+ZOHSo3n6Mk7eq9TMbSaqtIMAgS/iyDafxwcoUxojcumnof0kgTuMjVnOD1 Ps8GOlEGC/rJJopIo6WwaUsHLPWqdWThkgnDbZtssgQKjvsMX3eMz9b0zSPDN3b1YLbIVL+jeZ5oV /umKf9p6bso5UfeTGaEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obvFm-006Bew-98; Sat, 24 Sep 2022 02:50:54 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obvFT-006BZt-Ab for linux-arm-kernel@lists.infradead.org; Sat, 24 Sep 2022 02:50:37 +0000 Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MZD0X0cWHzHtdm; Sat, 24 Sep 2022 10:45:48 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 24 Sep 2022 10:50:31 +0800 From: Yuan Can To: , , , , , CC: Subject: [PATCH 1/2] firmware: imx: scu: Use dev_err_probe() to simplify code Date: Sat, 24 Sep 2022 02:47:59 +0000 Message-ID: <20220924024800.27954-2-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220924024800.27954-1-yuancan@huawei.com> References: <20220924024800.27954-1-yuancan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_195035_552278_C2D02F13 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/firmware/imx/imx-scu.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index dca79caccd01..85bcda1637db 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -309,10 +309,9 @@ static int imx_scu_probe(struct platform_device *pdev) sc_chan->idx = i % (num_channel / 2); sc_chan->ch = mbox_request_channel_byname(cl, chan_name); if (IS_ERR(sc_chan->ch)) { - ret = PTR_ERR(sc_chan->ch); - if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to request mbox chan %s ret %d\n", - chan_name, ret); + ret = dev_err_probe(dev, PTR_ERR(sc_chan->ch), + "Failed to request mbox chan %s\n", + chan_name); kfree(chan_name); return ret; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel