From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] hwmon: sis5595: Reorder symbols to get rid of a few forward declarations
Date: Sat, 24 Sep 2022 17:05:10 +0200 [thread overview]
Message-ID: <20220924150510.fabwsnjwrjlwhvlu@pengutronix.de> (raw)
In-Reply-To: <20220924143729.GA2300272@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
Hello Guenter,
On Sat, Sep 24, 2022 at 07:37:29AM -0700, Guenter Roeck wrote:
> On Sat, Sep 24, 2022 at 03:57:38PM +0200, Uwe Kleine-König wrote:
> > Declarations for static symbols are useless repetition unless there are
> > cyclic dependencies.
> >
> > Reorder the functions and variables to get rid of 4 forward declarations.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Applied, after fixing up subject (via686a, not sis5595).
When I pasted that into citool I had the plan to fix that ...
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-24 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 13:57 [PATCH 1/2] hwmon: via686a: Introduce a #define for the driver name and use it Uwe Kleine-König
2022-09-24 13:57 ` [PATCH 2/2] hwmon: sis5595: Reorder symbols to get rid of a few forward declarations Uwe Kleine-König
2022-09-24 14:37 ` Guenter Roeck
2022-09-24 15:05 ` Uwe Kleine-König [this message]
2022-09-24 14:34 ` [PATCH 1/2] hwmon: via686a: Introduce a #define for the driver name and use it Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2022-09-22 7:48 [PATCH 1/2] hwmon: sis5595: " Uwe Kleine-König
2022-09-22 7:49 ` [PATCH 2/2] hwmon: sis5595: Reorder symbols to get rid of a few forward declarations Uwe Kleine-König
2022-09-23 21:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924150510.fabwsnjwrjlwhvlu@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=jdelvare@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.