From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2CA2C32771 for ; Mon, 26 Sep 2022 05:07:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DCD5584B5F; Mon, 26 Sep 2022 07:07:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 29BB584C5F; Mon, 26 Sep 2022 07:07:13 +0200 (CEST) Received: from soltyk.jannau.net (soltyk.jannau.net [144.76.91.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 077E784C3A for ; Mon, 26 Sep 2022 07:07:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=janne@jannau.net Received: by soltyk.jannau.net (Postfix, from userid 1000) id 8B18F269101; Mon, 26 Sep 2022 07:07:09 +0200 (CEST) Date: Mon, 26 Sep 2022 07:07:09 +0200 From: Janne Grunau To: Lukasz Majewski , u-boot@lists.denx.de Cc: AKASHI Takahiro , Simon Glass Subject: Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device" Message-ID: <20220926050709.GI4024@jannau.net> References: <20220810195422.4334-1-j@jannau.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220810195422.4334-1-j@jannau.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022-08-10 21:54:22 +0200, Janne Grunau wrote: > Fixes a crash during probing of sd card readers without medium present. > > Link: https://github.com/AsahiLinux/linux/issues/44 > Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html > Signed-off-by: Janne Grunau > --- > Changes since v1: > - changed unconditiona return to "continue" as proposed by AKASHI Takahiro > > common/usb_storage.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/usb_storage.c b/common/usb_storage.c > index eaa31374ef73..f9204552a683 100644 > --- a/common/usb_storage.c > +++ b/common/usb_storage.c > @@ -239,6 +239,7 @@ static int usb_stor_probe_device(struct usb_device *udev) > ret = device_unbind(dev); > if (ret) > return ret; > + continue; > } > > ret = blk_probe_or_unbind(dev); ping. Is there anything holding up merging this fix? Thanks, Janne