From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF5AC07E9D for ; Mon, 26 Sep 2022 08:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbiIZIAb (ORCPT ); Mon, 26 Sep 2022 04:00:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234407AbiIZH7k (ORCPT ); Mon, 26 Sep 2022 03:59:40 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD77D37188; Mon, 26 Sep 2022 00:56:44 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ociyl-0002ma-7Z; Mon, 26 Sep 2022 09:56:39 +0200 Date: Mon, 26 Sep 2022 09:56:39 +0200 From: Florian Westphal To: Michal Hocko Cc: Florian Westphal , linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, akpm@linux-foundation.org, urezki@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Martin Zaharinov Subject: Re: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Message-ID: <20220926075639.GA908@breakpoint.cc> References: <20220923103858.26729-1-fw@strlen.de> <20220923133512.GE22541@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Hocko wrote: > > kvzalloc(GFP_ATOMIC) was perfectly fine, is this illegal again? > > kvmalloc has never really supported GFP_ATOMIC semantic. It did, you added it: ce91f6ee5b3b ("mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags")