From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C274AC6FA83 for ; Mon, 26 Sep 2022 11:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238361AbiIZLpk (ORCPT ); Mon, 26 Sep 2022 07:45:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238436AbiIZLml (ORCPT ); Mon, 26 Sep 2022 07:42:41 -0400 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EBAC71BFE for ; Mon, 26 Sep 2022 03:45:59 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id z25so10190471lfr.2 for ; Mon, 26 Sep 2022 03:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=rNWG4JRe++162NhDsfBIYQjTSKMyRVIRJUKX50ptAGY=; b=apxdxC/SZwYOVZdXn24zNBfDFMi7EsEuSmVWj/G5E7GAKkNZyQyX/ID4c6HnZkHbEo gVMD4bQFbeOrQzgMFGXt6eu5MdTVjYOiSSK3WpdMOafWWegTCyoqHnLWdZoGsGIyhy3k iLFE1mtY8NVMrsD6yL0AKE0H8fz4x5egsl7ImWlfltr1xExX2ugkok9daCAdEp1QVZCx RxOIL3VKv3EttfaNcX9i+6zAP8GaBP2BX9PjdQz+mZcSyK9cbMbVeRUgFOGLGd5rD+ei YEcX0uNahfhoa/VxgdTxGNAt//86dEk0bX3m5temSnsyOz5wgR7zNsnGVteXqUuJ1no+ V0Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=rNWG4JRe++162NhDsfBIYQjTSKMyRVIRJUKX50ptAGY=; b=imOP4BlQm7uwd1TEw7K7p12EJP8d0pfteYaQ+4318ZC8FyVOQUF3AQCKoyHo+Zqjbj oqF2ERZlIhu0jlTFsEeC9JMHQ4T11zDCohVLlUN1R2vf60u3ZCVfCJlCUTI3BXwdXwzw MmQiUn6fnVTy8eSeuazKlJkWBK0eEWeu4cj9PxcWzeIOzspyNBe9ece1v+aW6nzU7jvw FZUMhqZY8wWcRmWULmu7osEXaXgwilL27h5LoFIWcRa7PvR9/jzXECE/eGgs7GznQqYr XLyVJDbi4IFGaE0lWFylE+ca1UDuxKMO7iR15eOqSZ2kG3o54VBl/LT9AVWRIeLQnOGu +yGg== X-Gm-Message-State: ACrzQf0Di4IQzH3uV1PiFc79QBFd1kRKqbIaPUAC60MhcYbolOOrYLNx pQw4az+p7APboGFZQ7YcRfTflw== X-Google-Smtp-Source: AMsMyM7CTPcD1Iie9wuX6WkBzCWvvWDCPmmDKnQ42CjusRkxdgW8d+lPCLtPFyFHH5xQbvrQRr7TgQ== X-Received: by 2002:a19:4f01:0:b0:49c:94fc:1848 with SMTP id d1-20020a194f01000000b0049c94fc1848mr8103685lfb.415.1664189046445; Mon, 26 Sep 2022 03:44:06 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id y1-20020a05651c020100b0026c423959desm2313408ljn.25.2022.09.26.03.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 03:44:03 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Russell King , Kukjin Kim , Tomasz Figa , Kyungmin Park , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Olof Johansson , Arnd Bergmann , arm@kernel.org, soc@kernel.org Cc: Dmitry Torokhov , Linus Walleij , Krzysztof Kozlowski Subject: [PATCH PULL 1/2] ARM: dts: exynos: correct s5k6a3 reset polarity on Midas family Date: Mon, 26 Sep 2022 12:43:53 +0200 Message-Id: <20220926104354.118578-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220926104354.118578-1-krzysztof.kozlowski@linaro.org> References: <20220926104354.118578-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Torokhov According to s5k6a3 driver code, the reset line for the chip appears to be active low. This also matches the typical polarity of reset lines in general. Let's fix it up as having correct polarity in DTS is important when the driver will be switched over to gpiod API. Fixes: b4fec64758ab ("ARM: dts: Add camera device nodes for Exynos4412 TRATS2 board") Signed-off-by: Dmitry Torokhov Reviewed-by: Linus Walleij Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220913164104.203957-1-dmitry.torokhov@gmail.com --- arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi index b967397a46c5..8e1c19a8ad06 100644 --- a/arch/arm/boot/dts/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi @@ -586,7 +586,7 @@ image-sensor@10 { clocks = <&camera 1>; clock-names = "extclk"; samsung,camclk-out = <1>; - gpios = <&gpm1 6 GPIO_ACTIVE_HIGH>; + gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { is_s5k6a3_ep: endpoint { -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37B31C32771 for ; Mon, 26 Sep 2022 10:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vHtZ6Vh8VRwz2/Cbr/eOkpHXjXu9jkkeroDji0jiigw=; b=wQyY2u6fqtYzSb FJREdTpQvOkD239PlIGbUAe13YWO3UbRqcktAcAEBOFOnC5JPXNXE2GgEYlp1PCptU7sK5l5H9M/y 3S7iQb/E5HlinuvIdbaNTdiOYWykiuu7FA9lSGC6cNBD5gockX9c+p+9qv+lGfg3PH/qGDJ9HeE8C Zqd1JwakPS4BDU0yC09qYCgqrn7RqqEYLFoTx2fHVR/SJuUpWPo6JOJA2N5wrczFQY+fh3LVKsBX8 xV4V4zpAIDbeY3rGnFf6wiuTETPAZveNo1GMZHVWz0k98PPJW/f52oxyhJwjafqp+rqgOMlmFq5B8 IUCwo+J6OjK2iqKizArw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oclbT-004Fer-N5; Mon, 26 Sep 2022 10:44:48 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oclas-004FJY-7i for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 10:44:12 +0000 Received: by mail-lf1-x135.google.com with SMTP id w8so10119709lft.12 for ; Mon, 26 Sep 2022 03:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=rNWG4JRe++162NhDsfBIYQjTSKMyRVIRJUKX50ptAGY=; b=apxdxC/SZwYOVZdXn24zNBfDFMi7EsEuSmVWj/G5E7GAKkNZyQyX/ID4c6HnZkHbEo gVMD4bQFbeOrQzgMFGXt6eu5MdTVjYOiSSK3WpdMOafWWegTCyoqHnLWdZoGsGIyhy3k iLFE1mtY8NVMrsD6yL0AKE0H8fz4x5egsl7ImWlfltr1xExX2ugkok9daCAdEp1QVZCx RxOIL3VKv3EttfaNcX9i+6zAP8GaBP2BX9PjdQz+mZcSyK9cbMbVeRUgFOGLGd5rD+ei YEcX0uNahfhoa/VxgdTxGNAt//86dEk0bX3m5temSnsyOz5wgR7zNsnGVteXqUuJ1no+ V0Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=rNWG4JRe++162NhDsfBIYQjTSKMyRVIRJUKX50ptAGY=; b=lJYlXzyivzmh9eJF/Baa1EmJsk9o23sKN/PR+1gQfO4FQnqnqP8Z6eG5d7dXs3aErQ DlJcopziNCBNkE49X9TBWdw1N2TBbnu+/nB/M3mTrygvEYCpUfLPNvrf4zuBQVfIxE5y 0kTtrJIGEMog5z+IOgiiXG5OLX+gMzKOYS0pUpnvdu4Pax1FEbJwBVeKRf74UXeqcYAT SZ+sCYEP7/JwqQthvJw/tAKtXyZniFC3nok1Kc1p63vi/eoWZPgSNjX+DbCCIbzR9s1x plXM3CGD8vNHqubjgv/g+TP+HuPg30tq/7SHKh6rDR67FeboA8rCy7XjCC3EhpzA4+ys fLsQ== X-Gm-Message-State: ACrzQf33n0xOsd2P2lJea2IU658x6j/GiOQB2Iw3FnYfsHv9cjIeW+B7 oOdJOQsUoVDBgH+pT9z8jMnVOA== X-Google-Smtp-Source: AMsMyM7CTPcD1Iie9wuX6WkBzCWvvWDCPmmDKnQ42CjusRkxdgW8d+lPCLtPFyFHH5xQbvrQRr7TgQ== X-Received: by 2002:a19:4f01:0:b0:49c:94fc:1848 with SMTP id d1-20020a194f01000000b0049c94fc1848mr8103685lfb.415.1664189046445; Mon, 26 Sep 2022 03:44:06 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id y1-20020a05651c020100b0026c423959desm2313408ljn.25.2022.09.26.03.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 03:44:03 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Russell King , Kukjin Kim , Tomasz Figa , Kyungmin Park , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Olof Johansson , Arnd Bergmann , arm@kernel.org, soc@kernel.org Cc: Dmitry Torokhov , Linus Walleij , Krzysztof Kozlowski Subject: [PATCH PULL 1/2] ARM: dts: exynos: correct s5k6a3 reset polarity on Midas family Date: Mon, 26 Sep 2022 12:43:53 +0200 Message-Id: <20220926104354.118578-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220926104354.118578-1-krzysztof.kozlowski@linaro.org> References: <20220926104354.118578-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_034410_333209_E8817330 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dmitry Torokhov According to s5k6a3 driver code, the reset line for the chip appears to be active low. This also matches the typical polarity of reset lines in general. Let's fix it up as having correct polarity in DTS is important when the driver will be switched over to gpiod API. Fixes: b4fec64758ab ("ARM: dts: Add camera device nodes for Exynos4412 TRATS2 board") Signed-off-by: Dmitry Torokhov Reviewed-by: Linus Walleij Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220913164104.203957-1-dmitry.torokhov@gmail.com --- arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi index b967397a46c5..8e1c19a8ad06 100644 --- a/arch/arm/boot/dts/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi @@ -586,7 +586,7 @@ image-sensor@10 { clocks = <&camera 1>; clock-names = "extclk"; samsung,camclk-out = <1>; - gpios = <&gpm1 6 GPIO_ACTIVE_HIGH>; + gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { is_s5k6a3_ep: endpoint { -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel