All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, robh+dt@kernel.org,
	Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node
Date: Tue, 27 Sep 2022 11:03:42 +0100	[thread overview]
Message-ID: <20220927100347.176606-2-jean-philippe@linaro.org> (raw)
In-Reply-To: <20220927100347.176606-1-jean-philippe@linaro.org>

The devicetree specification requires a 'model' property in the root
node. Fix the corresponding dt-validate warning:

  /: 'model' is a required property
  From schema: dtschema/schemas/root-node.yaml

Use the same name for model as for compatible. The specification
recommends that 'compatible' follows the format 'manufacturer,model' and
'model' follows the format 'manufacturer,model-number'. Since our
'compatible' doesn't observe this, 'model' doesn't really need to
either.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
 hw/arm/virt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 1a6480fd2a..83ab1a37fb 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -252,6 +252,7 @@ static void create_fdt(VirtMachineState *vms)
     qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt");
     qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2);
     qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2);
+    qemu_fdt_setprop_string(fdt, "/", "model", "linux,dummy-virt");
 
     /* /chosen must exist for load_dtb to fill in necessary properties later */
     qemu_fdt_add_subnode(fdt, "/chosen");
-- 
2.37.3



  reply	other threads:[~2022-09-27 10:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 10:03 [PATCH v2 0/8] hw/arm/virt: Fix dt-schema warnings Jean-Philippe Brucker
2022-09-27 10:03 ` Jean-Philippe Brucker [this message]
2022-09-27 11:30   ` [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node Peter Maydell
2022-09-27 12:48   ` Eric Auger
2022-09-27 10:03 ` [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node Jean-Philippe Brucker
2022-09-27 11:33   ` Peter Maydell
2022-09-27 12:48   ` Eric Auger
2022-09-27 10:03 ` [PATCH v2 3/8] hw/arm/virt: Use "msi-map" devicetree property for PCI Jean-Philippe Brucker
2022-09-27 11:36   ` Peter Maydell
2022-09-27 12:48   ` Eric Auger
2022-09-27 10:03 ` [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node Jean-Philippe Brucker
2022-09-27 11:56   ` Peter Maydell
2022-10-13 21:46     ` Rob Herring
2022-10-14 11:37       ` Peter Maydell
2022-09-27 12:48   ` Eric Auger
2022-09-27 10:03 ` [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node Jean-Philippe Brucker
2022-09-27 11:25   ` Peter Maydell
2022-11-29 20:55     ` Rob Herring
2022-11-30 12:27       ` Peter Maydell
2022-09-27 10:03 ` [PATCH v2 6/8] hw/arm/virt: Fix devicetree warning about the SMMU node Jean-Philippe Brucker
2022-09-27 11:37   ` Peter Maydell
2022-09-27 13:24   ` Eric Auger
2022-09-27 10:03 ` [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node Jean-Philippe Brucker
2022-09-27 11:46   ` Peter Maydell
2022-09-27 14:35     ` Eric Auger
2022-10-21 14:33       ` Jean-Philippe Brucker
2022-10-24 10:44         ` Peter Maydell
2022-09-27 10:03 ` [PATCH v2 8/8] hw/arm/virt: Fix devicetree warnings about node names Jean-Philippe Brucker
2022-09-27 11:28   ` Peter Maydell
2022-10-13 21:27     ` Rob Herring
2022-09-29 16:53 ` [PATCH v2 0/8] hw/arm/virt: Fix dt-schema warnings Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927100347.176606-2-jean-philippe@linaro.org \
    --to=jean-philippe@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.