All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH v2 1/2] linux-user: handle /proc/self/exe with execve() syscall
Date: Tue, 27 Sep 2022 14:43:56 +0200	[thread overview]
Message-ID: <20220927124357.688536-2-laurent@vivier.eu> (raw)
In-Reply-To: <20220927124357.688536-1-laurent@vivier.eu>

If path is /proc/self/exe, use the executable path
provided by exec_path.

Don't use execfd as it is closed by loader_exec() and otherwise
will survive to the exec() syscall and be usable child process.

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f4091212027c..ddf09d7eb61a 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8843,7 +8843,11 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int num, abi_long arg1,
              * before the execve completes and makes it the other
              * program's problem.
              */
-            ret = get_errno(safe_execve(p, argp, envp));
+            if (is_proc_myself(p, "exe")) {
+                ret = get_errno(safe_execve(exec_path, argp, envp));
+            } else {
+                ret = get_errno(safe_execve(p, argp, envp));
+            }
             unlock_user(p, arg1, 0);
 
             goto execve_end;
-- 
2.37.3



  reply	other threads:[~2022-09-27 14:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 12:43 [PATCH v2 0/2] linux-user: handle /proc/self/exe with execve() syscall Laurent Vivier
2022-09-27 12:43 ` Laurent Vivier [this message]
2022-10-21 15:10   ` [PATCH v2 1/2] " Laurent Vivier
2022-09-27 12:43 ` [PATCH v2 2/2] linux-user: don't use AT_EXECFD in do_openat() Laurent Vivier
2022-10-21 15:10   ` Laurent Vivier
2022-10-26 15:25 ` [PATCH v2 0/2] linux-user: handle /proc/self/exe with execve() syscall Michael Tokarev
2022-10-27  6:40   ` Laurent Vivier
2022-10-27 10:42     ` Michael Tokarev
     [not found]     ` <ff22a2ac-d058-2448-0e76-03223f7f46dc@tls.msk.ru>
2022-10-27 12:09       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927124357.688536-2-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.